Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Mon, 4 Dec 2023 19:49:36 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Sean Christopherson <seanjc@google.com>
Cc:     Yan Zhao <yan.y.zhao@intel.com>, iommu@lists.linux.dev,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        alex.williamson@redhat.com, pbonzini@redhat.com, joro@8bytes.org,
        will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com,
        baolu.lu@linux.intel.com, dwmw2@infradead.org, yi.l.liu@intel.com
Subject: Re: [RFC PATCH 00/42] Sharing KVM TDP to IOMMU
Message-ID: <20231204234936.GB2692119@nvidia.com>
References: <20231202091211.13376-1-yan.y.zhao@intel.com>
 <ZW4Fx2U80L1PJKlh@google.com>
 <20231204173028.GJ1493156@nvidia.com>
 <ZW4nCUS9VDk0DycG@google.com>
 <20231204195055.GA2692119@nvidia.com>
 <ZW4ygoqOq2JpXml3@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZW4ygoqOq2JpXml3@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BDmqVpHH1bMExtwlv5xUYWhEYRvSfCsC5WBeAUpuwTtUCwPrunW9yI1BBQFV?=
 =?us-ascii?Q?JZWouz1nivri7Ytmy/MD1j0u6iIQTWfFAY7vYBXA8DXFmapxJ8uECnNgQSc4?=
 =?us-ascii?Q?104EAgsTlxo5vuxyBZtNZ1oBwroVr2aSKdCLQq+6jCDNMD/94orpNWAyu9Zv?=
 =?us-ascii?Q?UMkCkYlF9jZlsViy6WAZxsHACHH3pohv/QmM4GeXtO7EzR3KyXKKkKp/FVg9?=
 =?us-ascii?Q?6hGwyH3RBy6GcM6cBe/8Mqr2JlKpRZoWMBuKZ6l25PLKa1VA7euI732mbZNn?=
 =?us-ascii?Q?LJkJ2D7wp18l4nmKUbVwYJwhRUmIWujHnHbHU7M3x/CqXhHT1ymwLaedzuIh?=
 =?us-ascii?Q?33WpB1L88hciZMlB90oERuCUCY/BcKp4bUDN4OtBI4pafZ0qDJ/yIO4bhRGE?=
 =?us-ascii?Q?/OKlBbbjis5kKCuJHZUwW1Y3XP8XTpjB69UxZa6TFlFwTLc9pwVTvtejaSpb?=
 =?us-ascii?Q?4o4NqnMr54fScNGzqSH/mAqDJa71fDOqnIC91eX6ZKeeB8qEX70Ler+WoaAQ?=
 =?us-ascii?Q?Ns9Hdovf4iYBztvLq0Q1jFkv7YxDMyD5d6Dph/AVgpYufmV7buuhq4eORpT8?=
 =?us-ascii?Q?vIyNGaJSNq1TE59EnHup7tQRRjzYwUpjIBRL76y09iAsx3T7agrGYDVEsc4O?=
 =?us-ascii?Q?v5yA67ktXZB6U2O/QhidUU6l31stZa4yFgc1lAjImQNskORdCwBl5tv8aBPq?=
 =?us-ascii?Q?9d/eM7ugPpnd8ug/z8lZR1SrvdJIoOvYJLdR/2D3rYXKjAN1GtESrHAo2s7v?=
 =?us-ascii?Q?T+1U4IV3zJlUItthaaDKNWBEGvf/7NgNzOk3zvnLW9vJYX8bSpprf7wViKyf?=
 =?us-ascii?Q?xjCgf0uvMlmC9Gsk1DTEg0+U8Qjb+ItazYIpZBwesFDnpeLjx+LNnYr+wItE?=
 =?us-ascii?Q?e9ATaRwrX5aLk+kzZ51fUqd7PZKOjsK6MNu6JN5NybK4QjYd7TiPZsf0E2bA?=
 =?us-ascii?Q?RgfKPo+Mr99UDN3e+T+5vpgjeJxtFq0HCtT5ZVGoV7Sok4xjMyldSrwppKqU?=
 =?us-ascii?Q?ZCqwGrbOqyCYiTqDWlQvQG4pqLtO5xvKcbDpm7Gs8pnfhcJTF3f4vRTZvBBk?=
 =?us-ascii?Q?6gXOwrr0HgzCqUoRoo3D1f0gPQn12w4kLEBZm8Vq4TINNp4zBXX6IwjvbqCl?=
 =?us-ascii?Q?fua1U+MQTX+URyhHhjuN2d8gpe0roGV+Z3O9vTLDQK7MJaJESIpvfyXH3A1I?=
 =?us-ascii?Q?138Bxjp7NdD3i3py1ay/edK0fvElFLxbmNQHCvz6Wp+CIpC2IPjzpbbJF5vK?=
 =?us-ascii?Q?FmR3H2xBgFygJmYa1GHovsUOytpsvUJ4FcyObZzybaJ6WEyaXm1+k0m1rn94?=
 =?us-ascii?Q?sJYPaJtClDL5FjizLR+r17sUswhtJrr3urnEgm8N0j3dmqIrECXSHF7rCS7J?=
 =?us-ascii?Q?DtXZcGikA46rmFFyrvl5E66RR4Jbyv1mvf4T0UpYT1dwM6rDsewfe/4Es1AO?=
 =?us-ascii?Q?SpOShkyeW+ohIgrRmuDCCkbGma1xH8F5EZtUGa7zQ25emQF8jDYpSinBXnu7?=
 =?us-ascii?Q?lvuYLQ/RG1sWyUoRz0Nuw6cOjOxlg9fy1AaMhrhoKcrZSNuQOl2VaJ5x+07V?=
 =?us-ascii?Q?u1d6eMDivsdBaDLIi3Sdru8pb7dtNsihFsHTgUsT?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12aecfbb-d6bd-4e8b-babe-08dbf523ac9c
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 23:49:37.2941
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iQRwPB7IcBnduIhMaHRjpsJra91YIa8vUU5tFEMo07am9+rINzlTefsc66XPt7vm
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5230
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 04 Dec 2023 15:50:21 -0800 (PST)

On Mon, Dec 04, 2023 at 12:11:46PM -0800, Sean Christopherson wrote:

> > could we design the memfd stuff to not have the same challenges with
> > mirroring as normal VMAs? 
> 
> What challenges in particular are you concerned about?  And maybe also define
> "mirroring"?  E.g. ensuring that the CPU and IOMMU page tables are synchronized
> is very different than ensuring that the IOMMU page tables can only map memory
> that is mappable by the guest, i.e. that KVM can map into the CPU page tables.

IIRC, it has been awhile, it is difficult to get a new populated PTE
out of the MM side and into an hmm user and get all the invalidation
locking to work as well. Especially when the devices want to do
sleeping invalidations.

kvm doesn't solve this problem either, but pushing populated TDP PTEs
to another observer may be simpler, as perhaps would pushing populated
memfd pages or something like that?

"mirroring" here would simply mean that if the CPU side has a
popoulated page then the hmm side copying it would also have a
populated page. Instead of a fault on use model.

Jason