Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp3061267rdb; Mon, 4 Dec 2023 16:01:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IFVR/r4DFnK85WUEf8wAYsm27I0hwUaGQ7vwH9oSPAZ+pEGII3mSI5hPAvDPBj7wFUBHkXb X-Received: by 2002:a05:6870:6590:b0:1fa:d0:57b0 with SMTP id fp16-20020a056870659000b001fa00d057b0mr5878517oab.52.1701734487437; Mon, 04 Dec 2023 16:01:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701734487; cv=none; d=google.com; s=arc-20160816; b=IFKDywFuUu8teEAy6FNmt51uZ0UYEY7F2OQQA7lBylAlvXfONlMKdiB1G/dJ6NT1Tj gg0Yd+vCuZYXKXwgHEz2UPxkGsrz0suIP+AvWjc3BrQSBZ4Sl1L5x1otQ6zTsqcEHFYH T5feypwlW7OiQiEnsqd8VkBLP8MMs0dlc4CoZnnO7RSofX3ZExCXsPMcbAB8MqN5ft0q DMSt4z19DP9ALEHmdvEQiI5HfKIhixrsE+d1gaQczTnqYmlm29YE/PPlWguC1mnXY9eZ hTH2egbUL8ZNA+58oXkecOtM+aKJfS6/63aDwlbnK2YOGgcZEcmIu9eRIfHz/VBUsWQU WYrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=93s1ELgfxstgbB9hpuLBR3wLORjWDRcMjxyeQXV1qHs=; fh=F9FQ+XH215iMFZaGpIHBpf/r6NFX51YSj0ASq2WTBT0=; b=IU2Y/XDQj0IOfVaHp1imLndPdYTevA0PjYlRGPa3ozdq/nloqXdV0T414kn332fZiY 0XgXo+zkQzvcpBl82YnBn7/W+Yq8qZoDxaGW8rtKnRhy0KHOT7peWoNOz7N7KXzxdN39 VP5J60fqY8H4DGz/C4XWsrks2TrqUQNst0tgjABuW5JpXgzqIu2QEwMe7h8sokAvVsij EFR41gjLEHOHVV3iQ85D9x4SpS0zDaiwGArIbpIhhJKMr9X3HZKO4fjr49fop/wD/xZv sJ20NFqHc9PeLSiblBXDYtPZffXqCShelFadI7OTKIO9Iz0SatEo3wcJrOcMwls23J/p 4eqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=L30hPDlA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id pk9-20020a0568704c0900b001fb2f8ef45fsi1231928oab.270.2023.12.04.16.01.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 16:01:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=L30hPDlA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id A598480227E8; Mon, 4 Dec 2023 16:01:24 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234661AbjLEABJ (ORCPT + 99 others); Mon, 4 Dec 2023 19:01:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229742AbjLEABI (ORCPT ); Mon, 4 Dec 2023 19:01:08 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D963BFF for ; Mon, 4 Dec 2023 16:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701734474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=93s1ELgfxstgbB9hpuLBR3wLORjWDRcMjxyeQXV1qHs=; b=L30hPDlAyzQ5/4jPlkBwPwo+C35s6VyL8ADUi4UuceQ8TyEaR2LzLhqOXGspd8vAMhk8So V5dOkUnCsNZE7XN+Nytz3V/61133NagABHoAfjO9OCtgsU4ntG/6XICUBOvMuQhdubnfX8 qBebl+Sf/2ITVpQFvm5dW0Bhlz8oXas= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-523-Ec1Xjut3PqKkrCuiSNMb0Q-1; Mon, 04 Dec 2023 19:01:12 -0500 X-MC-Unique: Ec1Xjut3PqKkrCuiSNMb0Q-1 Received: by mail-io1-f70.google.com with SMTP id ca18e2360f4ac-7affd581173so416384539f.3 for ; Mon, 04 Dec 2023 16:01:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701734472; x=1702339272; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=93s1ELgfxstgbB9hpuLBR3wLORjWDRcMjxyeQXV1qHs=; b=dEFdO7SiGrhiuT8ZdPMk5xgZLk6PnMJpxNt6TEcrfvxmLGuFFUg+1HSCQY+I9lyCA/ rm6+6eYMkcNo1XMgsM9p8pnLefaCfKcomZf/i6FaYktYZbmD1VOiUZYMceevYQ5nJbMW HALHE6AGs1Nnri0wmFR2Tv0eMueaEeQqMSsJLq8IquaeC1IivKH741H4eEQTomX2Wkbr tcMetVt/TBfOTBnIaRnufWmoLI1Yow3+acIKdgNj9GpPvoZy0KECodUQx4z0xn+vk+Ye oRlxm26b1kPAz3WF9sy4oRZWLVEHvKNr0eSOVCqOG/e5ypBIK2rUweFcQDZ/4J0V6o0N chjw== X-Gm-Message-State: AOJu0Yx98K2pgWEoeKBEkv29FGus+ZGiMLusKUMlrYmj7GuvBLvx/6kP zjKVig32AibeQw3aRuZmphUeazon9qFBgU/6IRUlUG7zCsQ4ktR+2wwDdyVbDb3y86YxNJC8UVh 9BUIwFyNHfWirdyvRRatHSqmk X-Received: by 2002:a6b:ef16:0:b0:7b3:989f:ee57 with SMTP id k22-20020a6bef16000000b007b3989fee57mr4464346ioh.7.1701734472026; Mon, 04 Dec 2023 16:01:12 -0800 (PST) X-Received: by 2002:a6b:ef16:0:b0:7b3:989f:ee57 with SMTP id k22-20020a6bef16000000b007b3989fee57mr4464338ioh.7.1701734471701; Mon, 04 Dec 2023 16:01:11 -0800 (PST) Received: from redhat.com ([38.15.60.12]) by smtp.gmail.com with ESMTPSA id 22-20020a5d9c56000000b007b35043225fsm3092323iof.32.2023.12.04.16.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 16:01:10 -0800 (PST) Date: Mon, 4 Dec 2023 17:00:48 -0700 From: Alex Williamson To: Brett Creeley Cc: , , , , , , Subject: Re: [PATCH v2 vfio 0/6] vfio/pds: Clean-ups and multi-region support Message-ID: <20231204170048.232760ee.alex.williamson@redhat.com> In-Reply-To: <20231117001207.2793-1-brett.creeley@amd.com> References: <20231117001207.2793-1-brett.creeley@amd.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 04 Dec 2023 16:01:24 -0800 (PST) On Thu, 16 Nov 2023 16:12:01 -0800 Brett Creeley wrote: > This series contains various clean-ups, improvements, and support > for multiple dirty tracking regions. The majority of clean-up and > improvements are in preparation for the last patch in the series, > which adds support for multiple dirty tracking regions. > > Changes: > > v2: > - Make use of BITS_PER_BYTE #define > - Use C99 style for loops > - Fix subject line to use vfio/pds instead of pds-vfio-pci > - Separate out some calculation fixes into another patch > so it can be backported to 6.6-stable > - Fix bounds check in pds_vfio_get_region() > > v1: > https://lore.kernel.org/kvm/20231114210129.34318-1-brett.creeley@amd.com/T/ > > Brett Creeley (6): > vfio/pds: Fix calculations in pds_vfio_dirty_sync > vfio/pds: Only use a single SGL for both seq and ack > vfio/pds: Move and rename region specific info > vfio/pds: Pass region info to relevant functions > vfio/pds: Move seq/ack bitmaps into region struct > vfio/pds: Add multi-region support > > drivers/vfio/pci/pds/dirty.c | 309 ++++++++++++++++++++++------------- > drivers/vfio/pci/pds/dirty.h | 18 +- > 2 files changed, 204 insertions(+), 123 deletions(-) > Applied to vfio next branch for v6.8. Thanks, Alex