Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Mon, 4 Dec 2023 16:15:50 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     muchun.song@linux.dev, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] mm: hugetlb_vmemmap: convert page to folio
Message-ID: <20231205001550.GE4129@monkey>
References: <20231127084645.27017-1-songmuchun@bytedance.com>
 <20231127084645.27017-5-songmuchun@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231127084645.27017-5-songmuchun@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?it3STp8Xp5Dy2I8QEPPShPDd1zqPqeX1hzRIpyEXyvl5NbQ8a16Z8yKcCOuG?=
 =?us-ascii?Q?YnbYXIQalFGRkIljT2QecYnlkvQMbYak/g7QA57PNdoHL1kRpLexMB300i0Z?=
 =?us-ascii?Q?EmDXopG+/NMJlL+9M4jyv+DIKD6XSTHtOpJIMalJJx/Z0eSD9HEigwuC6+1G?=
 =?us-ascii?Q?M/wh90Es7RUhYLCIAkic5AVm2T3/doC5PSVqmyNG1Mm+EBSjGX41oAY1DCE/?=
 =?us-ascii?Q?du0YWtKV7kC2FEyGqzVelM4U1l8UIy8bwG9NX/Q4i7K8S8qL4zv8x+70DTtE?=
 =?us-ascii?Q?fucmNISIgS/d3lHPSjfUKnuyQtZk5QcOuwtKnBN362AM1dXKH4c/Wl3Dh0Gy?=
 =?us-ascii?Q?yIfI4g9QcuZicNGCXSTpUwBTFazhMAi9Axgba5AuirFCGYMm2cOz2/xHPf/k?=
 =?us-ascii?Q?SmgbYtE2hXwBEI5q97/QkVa0xZkfI3K1ErtHxf3aDeh2hRY6BuGXZwIRTH3U?=
 =?us-ascii?Q?/1gQSZhd5lyXl//JVVgDWCiimYCQqRD8q0mrlzbrR3cl6fA+MhZ4rA9W7Ddy?=
 =?us-ascii?Q?37tFEZOiRlY53uDIqcJ+BPg9nDKRs9bEMOhGBgYVuW229zJ6b3Im/o/SnrJE?=
 =?us-ascii?Q?xhJ8xjuBFPbRtzcbZ30FaGWges/2PAbMIhvXEalrGYwQwdzm+dJ7/lUXgwGf?=
 =?us-ascii?Q?lH3z+3ZW/5tsY6jUUZwc5ZVpnyGUIXhDAKjuB1OTy5GfZ0Si0vFXsIKMWzbH?=
 =?us-ascii?Q?/OBoIquUoGOWTDAGRBogKFsgBiVVesXHmSwxnflZ9cdd9kp3FQTSemloxaKx?=
 =?us-ascii?Q?KK2e6OUL/XK6BudxK5tPKZsgXd9A8ewDHTlCEncEAUlBjppdJsBkQuivdDXD?=
 =?us-ascii?Q?Sc26Fh2lfGmb8WaEqiwZnNHRUksWuglAaooRc+l46MoRhO3Ma/4/3/GEyEjC?=
 =?us-ascii?Q?Az4Ek6mwnmi26SWewdWW43aGdMRoqmvdiTBRSUh8WdmkfWvchm/4XE5uE+hh?=
 =?us-ascii?Q?K22I8tuEoYFEd82TQgMwajNHEBxYB52C9pQR9fbMK8W8ramVtlJadDLN67hF?=
 =?us-ascii?Q?KYk8bgjNEAik2ml88pdDady2uLCJPp/9ZbEcVLH4usqgNoy2YV2+vN1d6KRn?=
 =?us-ascii?Q?3XjGk68+cnA+5HYgmLlKjYtVr/aRwToX/HCQy49/MJ02jqjUjdbXbuyiKIJF?=
 =?us-ascii?Q?K4iydAaslM1IoO2IcQ0/UoNwUvAzQg7mjMroRHYH8duMheb6VHIIk7TjN2uk?=
 =?us-ascii?Q?UcS+yncyiRXRPBkOuyVzqkAW/y9n8kY830tjRlwB7CBA0txUVRFPskyYx/7I?=
 =?us-ascii?Q?sxUO8u1ls4B9h88ZGVvTBXfUwUi2bil0aFkguDzjs1YrUxL7Ys0Jz1Ft7mgc?=
 =?us-ascii?Q?4/0Tw+9C5enmg2ybcScpOQoJhr6aAztSdXPt2BmRFgI2eVL2JWf25+3byux5?=
 =?us-ascii?Q?+nt/LIbZK6sfcot6oyeRPDyat+GGUy8TEV4WrtG2xeQwLpx0ZLa0BghtFakg?=
 =?us-ascii?Q?ai6xLSL+8D1kV0nIYXkSzfQzafD89cGN/K0XXR7d8LzZCal9igd49Pslf1U1?=
 =?us-ascii?Q?oJsEq0Kt7n/OXpouXJ6DsbapGlp+WaGjQhHv9p38JtKkAAEA9UZZadbMoIf7?=
 =?us-ascii?Q?uiVFQz/bXqjVh28P9abZxrvE73PA05fKdBDnhXQP1fJYoJNydfBuFY/L7prc?=
 =?us-ascii?Q?yw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: KTKHi//0sUH13ihBOR9E5ox/pviHVmZgMK3aiJHmAVJu5kKQ7rtfju5lmR+FiOu1XGbeLdSNmTyjsU3RbOxAEFZERAlXA2SP98Oujl7feG8xr5pSTaARhfkLUOV8xwpM46RNwT6ETgAusIIDYZ92qSmofHz7QkdlJ8l26jc3WIcslkLh8JkRfkiev+sybMBOLqsLBywJ8lMjpp6VqMCcWzPrLgWpGKZQ64j+ChOGLRodkCbFFxH2ihjhELTCOVMBctNlY8+T/V65d/enbA8xj+Y5bYDC4iA3mA+Sb2xQHH+rpKhpTx0d4ntfdm8G1viLcfJ62gM76U+OR+b9jLAA5xg62lPhb3rYrsDLTxlVeXgpBgyvOejlUCJD9Fgb+kRVT219YLuD9GARjj7N1rHMhE/6AY/TovJNPrssdc8Ug9VL+ipYDfO+CZgmFO7JmGOgN20rLSIJEmn1cLVSHioqNeFUF9qGqzu+39OJHLu1DywNIrtRo3146bnTysYT7n22MuO+1fs9NSHzdkH8as4d7t/DhpE1J0FRvkhmzMHy9AJKloW5E/2/JYDGLukSnXNRcHvn/R56qERSmCkWsrCE5S6zz4+6a40WqcLSm3NL3tY26IwLc0y5udae+a5CfCdUlDFjsBc/LZAyCOH4ClZSUsr9hiE2ItROH9ZTHBSkFtwX3fylwOF9f7u8NvC2yRyQZMWJyKmPgyjHHWJEUaszeDki+jzyI9wGN6gVFojU1pJdGMutubxjK9HyXNnqct0UgyU0aT4TQYCGyTlrJHNajJn0ygfeWF/LcXH24GHM4zKq9R+CEKcz54fmlFMBnGQcOCzjJeoHLuiduPg/MD4WIkmJYs1ZmlD+G1A5CgOGDMj62/vMpWHav93DBao7rzy9odjJDj17JPskD91jVwzBAWW+0qtXctBDjtqlZVppZYA=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aad28495-4af1-44ce-42cc-08dbf5275819
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2023 00:15:53.5426
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jxWHCr5aVU3DRUqTc2B51ytpzayxTXK3Faec+vtnvSXk/k7Orl/+nnquE5vmJ+BAz/uX+fkoQpBNLOPen7jtyA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR10MB7094
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-04_22,2023-12-04_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 mlxlogscore=999 mlxscore=0 suspectscore=0 adultscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311060000 definitions=main-2312050000
X-Proofpoint-ORIG-GUID: sI8RZx8kbbSEYJcIapbotD-IWReszCvc
X-Proofpoint-GUID: sI8RZx8kbbSEYJcIapbotD-IWReszCvc
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 04 Dec 2023 16:28:48 -0800 (PST)

On 11/27/23 16:46, Muchun Song wrote:
> There is still some places where it does not be converted to folio,
> this patch convert all of them to folio. And this patch also does
> some trival cleanup to fix the code style problems.
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
>  mm/hugetlb_vmemmap.c | 51 ++++++++++++++++++++++----------------------
>  1 file changed, 25 insertions(+), 26 deletions(-)
...
> @@ -535,9 +535,9 @@ long hugetlb_vmemmap_restore_folios(const struct hstate *h,
>  }
>  
>  /* Return true iff a HugeTLB whose vmemmap should and can be optimized. */
> -static bool vmemmap_should_optimize(const struct hstate *h, const struct page *head)
> +static bool vmemmap_should_optimize_folio(const struct hstate *h, struct folio *folio)
>  {
> -	if (HPageVmemmapOptimized((struct page *)head))
> +	if (folio_test_hugetlb_vmemmap_optimized(folio))

Nice!  After this, there is only one remaining use of 'page based'
hugetlb specific flag macros.

	mm/memory_hotplug.c:            if (HPageMigratable(head))

When that is converted, all those macros can be removed from linux/hugetlb.h

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz