Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752531AbXLBWQ1 (ORCPT ); Sun, 2 Dec 2007 17:16:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751181AbXLBWQT (ORCPT ); Sun, 2 Dec 2007 17:16:19 -0500 Received: from mx0.towertech.it ([213.215.222.73]:49706 "HELO mx0.towertech.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751132AbXLBWQT (ORCPT ); Sun, 2 Dec 2007 17:16:19 -0500 Date: Sun, 2 Dec 2007 23:13:22 +0100 From: Alessandro Zummo To: Jiri Kosina Cc: Andrew Morton , Alessandro Zummo , David Brownell , Nickk Piggin , linux-kernel@vger.kernel.org Subject: Re: [RESEND] [PATCH] RTC: assure proper memory ordering with respect to RTC_DEV_BUSY flag (was Re: RTC: convert mutex to bitfield) Message-ID: <20071202231322.2c104d8c@i1501.lan.towertech.it> In-Reply-To: References: <200711301355.03139.nickpiggin@yahoo.com.au> Organization: Tower Technologies X-Mailer: Sylpheed Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1017 Lines: 37 On Sun, 2 Dec 2007 23:00:04 +0100 (CET) Jiri Kosina wrote: > [ nobody seems to have picked this up, resending. This is a fix for > commit 8853c202b4 in Linus' tree ] > > From: Jiri Kosina > > RTC: assure proper memory ordering with respect to RTC_DEV_BUSY flag > > We must make sure that the RTC_DEV_BUSY flag has proper lock semantics, > i.e. that the RTC_DEV_BUSY stores clearing the flag don't get reordered > before the preceeding stores and loads and vice versa. > > Spotted by Nick Piggin. > > Signed-off-by: Jiri Kosina missed it, sorry. Acked-by: Alessandro Zummo -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/