Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <d639b4e3-e12a-47e8-9b03-2398b076fdbf@linux.dev>
Date:   Tue, 5 Dec 2023 09:50:39 +0800
MIME-Version: 1.0
Subject: Re: [PATCH for-next v7 0/7] On-Demand Paging on SoftRoCE
To:     Jason Gunthorpe <jgg@nvidia.com>,
        Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
Cc:     linux-rdma@vger.kernel.org, leon@kernel.org, zyjzyj2000@gmail.com,
        linux-kernel@vger.kernel.org, rpearsonhpe@gmail.com,
        yangx.jy@fujitsu.com, lizhijian@fujitsu.com, y-goto@fujitsu.com
References: <cover.1699503619.git.matsuda-daisuke@fujitsu.com>
 <20231205001139.GA2772824@nvidia.com>
From:   Zhu Yanjun <yanjun.zhu@linux.dev>
In-Reply-To: <20231205001139.GA2772824@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

在 2023/12/5 8:11, Jason Gunthorpe 写道:
> On Thu, Nov 09, 2023 at 02:44:45PM +0900, Daisuke Matsuda wrote:
>>
>> Daisuke Matsuda (7):
>>    RDMA/rxe: Always defer tasks on responder and completer to workqueue
>>    RDMA/rxe: Make MR functions accessible from other rxe source code
>>    RDMA/rxe: Move resp_states definition to rxe_verbs.h
>>    RDMA/rxe: Add page invalidation support
>>    RDMA/rxe: Allow registering MRs for On-Demand Paging
>>    RDMA/rxe: Add support for Send/Recv/Write/Read with ODP
>>    RDMA/rxe: Add support for the traditional Atomic operations with ODP
> 
> What is the current situation with rxe? I don't recall seeing the bugs
> that were reported get fixed?

Exactly. A problem is reported in the link 
https://www.spinics.net/lists/linux-rdma/msg120947.html

It seems that a variable 'entry' set but not used 
[-Wunused-but-set-variable]

And ODP is an important feature. Should we suggest to add a test case 
about this ODP in rdma-core to verify this ODP feature?

Zhu Yanjun

> 
> I'm reluctant to dig a deeper hold until it is done?
> 
> Thanks,
> Jason