Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp30282rdb; Mon, 4 Dec 2023 19:06:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IHxqsfn3off67ph83Su/F3o+GmWXUxqIq3h08IMZf9Z+KPYL9HmOyNxj84FZols7QdoJB2f X-Received: by 2002:a05:6e02:f02:b0:35d:59a2:bb2 with SMTP id x2-20020a056e020f0200b0035d59a20bb2mr3250381ilj.72.1701745569404; Mon, 04 Dec 2023 19:06:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701745569; cv=none; d=google.com; s=arc-20160816; b=diCnEhkp+Y/7TxWqC3QWve2Ufx2yCBfG1z8xk1DkokQ7YtnscpZUW8rPCxl9PXMgUs mouxJ3DxvrSUdopi0Q+Zol7jpi+1Ec1fi1br++vJriLC8snJAkoowedCe4Agvjwgb6n6 5mcQMaukaf6r5KnDKojQVLR4jnf67wQRxtP9F/m2ys0gpLHATGrdxXv5RPch8jzTVAp9 0dURvRgzJ0J2Rk6fCFHweB7lqor2f0wTBMlZgxO8c33IooRnNJGz2LMQHqbIJtA+UdxM jf8+eUUj3AyN+fWnguoMIcIphVCXnD/Yx+jfUr78zlK4iDwKtlAWJn42pRA1ziGfUCQp puvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id; bh=GXdE7q2snZgcYDc0lcSm04CGse284EcKw3WSiofnrIc=; fh=dUkDikjyxqjLboOF7jMeHHHM0015U08tuQT4y4L00to=; b=djaQAdRjgAXu9266ynSjQI68GP2agB8IrgtoJQGw+5NZ6cA1iyEFbUAWJdR/cTewaj 8ApImlNvLCRaF7gYEX3d0QIGRfxVzsQ5m4uwxu1WETtthxGRbS/du5ZToLg36V1ACZbH qVWjmGJ3RMLNaSU+lgMSR+dSuI2/YoiSX95Kjb1c4RqDdoddZKB30iLajC3/TIg+0oc+ xD5Ul0TJ2GlZJpIXeXSoGlveg0STWXhRINTwnMCZZApWwuO5mj02GCj9MH5cJVOyH5W+ xbmttXNAAM4N+aDZZVttviAmq2tI/iyFFdQ8s3x5A1N6V9Y+xRZuEplopMCTaY9GzQjQ Y9hw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id 33-20020a631061000000b00578a44df6c1si8594616pgq.640.2023.12.04.19.06.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 19:06:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 36E178042C10; Mon, 4 Dec 2023 19:06:05 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344116AbjLEDFs (ORCPT + 99 others); Mon, 4 Dec 2023 22:05:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234848AbjLEDFr (ORCPT ); Mon, 4 Dec 2023 22:05:47 -0500 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BD3EBF; Mon, 4 Dec 2023 19:05:50 -0800 (PST) X-UUID: b1ae75138d6e4ab4b5b51354363fe8e4-20231205 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.33,REQID:8ce5544b-bf9c-4849-94e4-0899eb8f545b,IP:5,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-15 X-CID-INFO: VERSION:1.1.33,REQID:8ce5544b-bf9c-4849-94e4-0899eb8f545b,IP:5,URL :0,TC:0,Content:-5,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-15 X-CID-META: VersionHash:364b77b,CLOUDID:805d4afd-4a48-46e2-b946-12f04f20af8c,B ulkID:231204205248UVJ6B54Y,BulkQuantity:4,Recheck:0,SF:24|17|19|44|66|102, TC:nil,Content:0,EDM:-3,IP:-2,URL:0,File:nil,Bulk:40,QS:nil,BEC:nil,COL:0, OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_FSD,TF_CID_SPAM_FSI,TF_CID_SPAM_SNR,TF_CID_SPAM_FAS X-UUID: b1ae75138d6e4ab4b5b51354363fe8e4-20231205 X-User: chentao@kylinos.cn Received: from [172.20.15.254] [(116.128.244.169)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 1111733163; Tue, 05 Dec 2023 11:05:43 +0800 Message-ID: Date: Tue, 5 Dec 2023 11:05:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 iwl-next] i40e: Use correct buffer size in i40e_dbg_command_read To: Alexander Lobakin Cc: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jeffrey.t.kirsher@intel.com, shannon.nelson@amd.com, kunwu.chan@hotmail.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Simon Horman References: <20231204014455.2444734-1-chentao@kylinos.cn> <81dbf657-6513-4a8c-a0a9-5a98951c8356@intel.com> Content-Language: en-US From: Kunwu Chan In-Reply-To: <81dbf657-6513-4a8c-a0a9-5a98951c8356@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 04 Dec 2023 19:06:05 -0800 (PST) Hi Alexander, Thanks for your reply. It's my bad, I'll follow your suggestion in v4 patch: 1. keep 'buf' as it defined before. 2. resolve memory leak as your suggestion. 3. make 'bytes_not_copied' as a return value for error path. Thanks again, Kunwu On 2023/12/4 20:51, Alexander Lobakin wrote: > This is unneeded.