Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp49183rdb; Mon, 4 Dec 2023 20:06:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IEpLnrUuZkjLENBGTrIy8vFHti/5wxPIwuNAzFTJSt/+pvnaejT69yq8zgquxRArqXUSPFv X-Received: by 2002:a05:6a21:1204:b0:18b:9093:ff13 with SMTP id oe4-20020a056a21120400b0018b9093ff13mr4458883pzb.52.1701749161875; Mon, 04 Dec 2023 20:06:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701749161; cv=none; d=google.com; s=arc-20160816; b=FuF0N+x4byE1Rl/TOmaiYeGRmyMwg7xW0bbkrEzRIbz7abwSYhuzzwefMaTewYQp/P YXPHFeRhWPCbE8vuF3XkMENJEyV2qlJOWze0x+ktq1jIM7heJtWUa3bezivcdnKy2a4n FVJTHH/AgW4mxTp+9t8E6m7tH9WZehB38qn1hUn1BwFaLy/wl8p2WKrFlG8p0CLVP9Zq a11LUQPWgPzrb9/Vgxy/pZoyJjqVpFS8vmRF5tvxCcAmisVJ15t/QGtY7Rxq5iu9ANT+ aZwBwpMj8WRCbs7IDzGmu0Afz14icCsRcMFUazxBIFJIJb/pif2OqSVXqrcwjOYbfcOu z8VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=2k7iixUT5DlTn6h1rQEcCyY4ImOO7JGoRLtRpOFAc8o=; fh=G7naAY3YbREVqy+i8VP5gqcoBaGnk5RFRIZpn6+av28=; b=V3Rgdn+ZeIJdU+UMh7WrnCAZ1+wNCOQ4D7FgoKFjGqrZWn2AOtH3daOVDGOPctMY8I JntUGFSVgbX4DqApb3foZyQgH011iwV3eorC5kZZwiap8i6hSPBfZqJKHZGwibQIilBF CVjuTkaC7gYplLbsUejiehtoL1IFl8bTPPrBO19A+uASLvkzSREbF+nrBnCzXXRtDX4s /QO+eXCt35/xBI9hHWnZfShVlWJ65sx+hzWkpA3e5JRkZDmFgqjSN6bz+YQHzw3cK15Q 4vgsYcRzuyuwKdQDTSD4dFGW0LUiCfJsRY+UwXSpdBJN70bDm3JRMn/EHx4/OYQZy7z4 auPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=aD+6kY7o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id j33-20020a632321000000b005c676beba09si3707487pgj.74.2023.12.04.20.06.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 20:06:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=aD+6kY7o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id EBD9F805B6C7; Mon, 4 Dec 2023 20:05:58 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231639AbjLEEFg (ORCPT + 99 others); Mon, 4 Dec 2023 23:05:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230074AbjLEEFf (ORCPT ); Mon, 4 Dec 2023 23:05:35 -0500 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23D2BD3; Mon, 4 Dec 2023 20:05:41 -0800 (PST) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-a1a496a73ceso487463466b.2; Mon, 04 Dec 2023 20:05:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701749139; x=1702353939; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2k7iixUT5DlTn6h1rQEcCyY4ImOO7JGoRLtRpOFAc8o=; b=aD+6kY7oEUbMvsvS2Ooh3gkQdxirDXK6g3GM8e6tdAFewVrLnfdUwDnngAvdTZVJ8O pz0wuZkkEx5TDOR2InNCU3utlYmTA1hktnTQO49mkAeIEUA8KILiw33s6VA70EBU+RsB Z2iTkA9FaqYSHR0EXimsGxFqH35GwEiEVcCsEoZUCf3IRvxeWcXMb+NYFZHs2ti0ILFS oWjqZLdS9qq7FMO3Tw7JyJ2WweibHtyCFf2fbb/Y7sQytyZfRjJueCzQJ3W2EoVjJ0pQ LGaG/j/tzoOdSklfwrnBB7xKUWI9jpwlQpuQzZOqya1ikYxKRjU0pyXbe/UY1gXuR9/I L4aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701749139; x=1702353939; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2k7iixUT5DlTn6h1rQEcCyY4ImOO7JGoRLtRpOFAc8o=; b=pqXf5sFQr32oHyMLsVPZFPJjlmQBCQamJbtSu4ISnDXkiNXyu/hvK2nEos/ECZ/ARg VcN1Oeytkw4Mb1ivBf5eE72xv87G8Ctn055ulkkcoHumobJ2yYZMAs9G87dBu3MTUkOa DAq82gRhvSmOQFrvJw0z9sapo0GCbMF7DZ4w7yw/iqj8NYd6Pf8z9jn2/EtiBSf8f66P RkWiRitqhYDw8P01jv/ERa3g7FJsd6Zcnqx6CLZqie32nTDv5DSRarU3xqXfI4fBIFp7 HTFW9rdAj1yyZ8OykB2B+latm8deULUC9hE2dwDHpcyX3odUFZWN9C3Bcwmi45duhSUC fLaQ== X-Gm-Message-State: AOJu0YymP7pfpEyv8PnQm1gln0QgORc8oB/RUUybd3WPAOCDZMJ3N8Ki CQMaCLSPV2aJo+qGHfMBh6kDhGA2D41omkFEXqI= X-Received: by 2002:a17:906:10d0:b0:a19:a19b:7897 with SMTP id v16-20020a17090610d000b00a19a19b7897mr94028ejv.90.1701749139497; Mon, 04 Dec 2023 20:05:39 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrii Nakryiko Date: Mon, 4 Dec 2023 20:05:27 -0800 Message-ID: Subject: Re: [PATCH bpf-next v4 06/10] libbpf: selftests: Add verifier tests for CO-RE bitfield writes To: Daniel Xu Cc: daniel@iogearbox.net, shuah@kernel.org, andrii@kernel.org, ast@kernel.org, steffen.klassert@secunet.com, antony.antony@secunet.com, alexei.starovoitov@gmail.com, yonghong.song@linux.dev, eddyz87@gmail.com, mykolal@fb.com, martin.lau@linux.dev, song@kernel.org, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, devel@linux-ipsec.org, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 04 Dec 2023 20:05:59 -0800 (PST) On Mon, Dec 4, 2023 at 12:57=E2=80=AFPM Daniel Xu wrote: > > Add some tests that exercise BPF_CORE_WRITE_BITFIELD() macro. Since some > non-trivial bit fiddling is going on, make sure various edge cases (such > as adjacent bitfields and bitfields at the edge of structs) are > exercised. > > Acked-by: Andrii Nakryiko > Signed-off-by: Daniel Xu > --- nit: please drop "libbpf: " prefix from the patch subject, this is "selftests/bpf: " actually > .../selftests/bpf/prog_tests/verifier.c | 2 + > .../bpf/progs/verifier_bitfield_write.c | 100 ++++++++++++++++++ > 2 files changed, 102 insertions(+) > create mode 100644 tools/testing/selftests/bpf/progs/verifier_bitfield_w= rite.c > [...]