Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp70477rdb; Mon, 4 Dec 2023 21:13:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IHgODGyTczjHp3CWpkB4hMxwkFy6Y5CMsmL6/wZQoaD3UOx4rPpKSbckPyUhAfF9LGr0Nmv X-Received: by 2002:a05:6808:1786:b0:3b9:b8ee:82f8 with SMTP id bg6-20020a056808178600b003b9b8ee82f8mr2140931oib.6.1701753185290; Mon, 04 Dec 2023 21:13:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701753185; cv=none; d=google.com; s=arc-20160816; b=CI316iEg1m/xmwGcrixr507w5QhglrWUBHBOvHhp5URPVWa7pgx1B3duL3rNUjgvdY ooXmdqbvXQKU9ivXJFBvXjPzfJyPcM5N7wLBSCLyIwUcDy38JawFS2sDyyOhLmwHY9YV ANPsKgLMbvlNYsV+gyHr22eRk/LjmhCvar28XsmMUY8Zj4VrVgwf+OTK5fQJ5VG8ZMD2 L2+ZseS+upWXX2cY4svPwcZy34Tf3+01+hrLjx6DhloUw4wvi8FWv9/IV+8q9rr5rgG4 haR61vPh1HOJSg67lzs1uqMXhrHLH8M6kOEzIX/UqMfPovBR40j7vpEWgpGrkYd7uFkp qx3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ncz6t9/1ak5tQzeNdq4sicxqCjunw4/Fask4L2znKlk=; fh=Xhyuuicc99jZlJX4wCP/Zn/eU8H3/eTtWgVZwEm3/BI=; b=UnVh/kVg8Y0+qXf6+bNfvO0nkhXC10BX6g4lnbgMd0gENnpeSqRLDdlMpdToYKPs/E tysvo7uqHqmJkYuAGAnby8UxXiFenCwFJ3St4tjFbV07nIMmwB9/QljlFPkg/yC3FVGU utAiiWASNKCiZGxQrAdRMiDqBL8t9GXJ1gqJxB8Sng+aOBp83mGp2DdeOYdFHD4XmqDP FesZts5bI0U9zvq37HsQ4sFcFBr7/1LJFT93fbfh5g/Ud18/+KaOJUyW1ix/THpxuHhn 8fC95+IGEj83PPwU6Vi8BhfmUZH+7fNGWL6it3P379UL3Y3YLhOi73Ur1JdAQCddJbAZ ZdIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=QM3JaUd6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id g71-20020a636b4a000000b005b90b310e26si8909714pgc.403.2023.12.04.21.13.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 21:13:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=QM3JaUd6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id AB6BD8027070; Mon, 4 Dec 2023 21:13:02 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344278AbjLEFMq (ORCPT + 99 others); Tue, 5 Dec 2023 00:12:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344252AbjLEFMo (ORCPT ); Tue, 5 Dec 2023 00:12:44 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6243C11F for ; Mon, 4 Dec 2023 21:12:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ncz6t9/1ak5tQzeNdq4sicxqCjunw4/Fask4L2znKlk=; b=QM3JaUd6O6kjwVIotWLkMsWcxw FFEFIyTuo20WeeS3rQnMzCF5h5fdXw9F8hUIsor4c9xc0N3vv6XuUql4TGd5zAU7DeNSunKZTUTU1 Fj79EOc9Kbkma5HiXEq/Gq99kU0kl5OUzVHOcJ+JETE8Az/fbNGD3MdK9b+P7GMFQDfMISGDcbdw5 75pQZ50ioG1Xcx228O5yXnqapN4gUJhQtz6LEPQmk0UR1PYqG3CIsox+F2Ra3seecq3Gml6BZbSQa YZqTv9VZrMp/f4mPzxJf5+4i2o6K0HuMH1xDxdDNkxEvipwM5Qq263/xrEmUNXKh8kRNfPOeVbE2o 0iODzysw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rANjj-006Hnu-0y; Tue, 05 Dec 2023 05:12:47 +0000 Date: Mon, 4 Dec 2023 21:12:47 -0800 From: Christoph Hellwig To: SeongJae Park Cc: Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] mm/damon: export DAMON symbols and add sample loadable modules Message-ID: References: <20231205022858.1540-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231205022858.1540-1-sj@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 04 Dec 2023 21:13:02 -0800 (PST) On Tue, Dec 05, 2023 at 02:28:55AM +0000, SeongJae Park wrote: > DAMON cannot be used from loadable modules since it is not exporting its > symbols. And that is a good thing. We should absolutely not allow random modules probing MM internals. What you posted here is basically just adding hooks without even real in-kernel users.