Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp82496rdb; Mon, 4 Dec 2023 21:54:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IHi5MSLB/SZlsDyBf5TG1JUbxxe/uGYaRWvlsh8rFR2aLbaAWxbXnZOmX7qCC3pFUFClo+t X-Received: by 2002:a17:902:db06:b0:1d0:c229:a01b with SMTP id m6-20020a170902db0600b001d0c229a01bmr908925plx.48.1701755664007; Mon, 04 Dec 2023 21:54:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701755663; cv=none; d=google.com; s=arc-20160816; b=dJNbDz85mQEGm2mvafHrT2RuMSTY9PiwUgS4SwAeOIZVR8f4YUappf0wlOB3U90suZ VA5YBxSS2MLBLFxa9bV50UHGOGtzNqeJVdI2X15aFLxX5AMsXOS1szexU8AYyBRTr+cH v/W2Qvu5viu9QxGjzQBNW0EQgJkptcT9W3bAszHGzvOwE87bgXCoLzbnyIyswuQHdcox U95vBH95SUO38kdaostIHRQ31hlaxkPMl+XHCEHQLlEl8RBUMJYwOCXwAMiziXT0UWPo VFdLHkAoJB/xUC4mZdV8bwfPRmI8s09bhAMcM188WGTJmzu0yx4mra4MChlz2TanKelR 5QSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=1Iv/JPivv8gaXFUDuV+9Dfaf9FrsyxCnmRcQFTbhR4s=; fh=FS0iof5TmAMpdVsG9e8HSeu/jnA497uQ+Nt8/g+MwHU=; b=Q3OP98x5H6q/znn6IU2WTVenkeUpTUCawZjaRyJMJMroKCHAQC/rmaCunPqhZDKQhF wwS5ca10r+JHZ0hhDcWM+gAQKl4GwAK5F1sUmcQd20Ie1N68ESQfIJx/29DEPuId7JwQ CAXyjiIZEYOWF/0aSSN6yji+A9FEjQ/bp76by6zvKV6fTR4cudvm6pqwIjBH/9bwuuNX JLObAhx7Lz51lgcBkbBoiCyimwnpTYCG1J99W9r7k8Ma2KMz/SPGdatUm+PGH3jeUJnO OwT4QCZ1aUGk4vzP0Y5zObFO/p+VRZ9+D9zcS0sZnDI+WKSS51PmqIPVP+hKqa4cXgiy qzBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=ZaSI6JeP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id j1-20020a170902690100b001d0748ffd2esi2837386plk.163.2023.12.04.21.54.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 21:54:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=ZaSI6JeP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id A0DD680AD127; Mon, 4 Dec 2023 21:54:21 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344258AbjLEFyI (ORCPT + 99 others); Tue, 5 Dec 2023 00:54:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234796AbjLEFyF (ORCPT ); Tue, 5 Dec 2023 00:54:05 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7C07124; Mon, 4 Dec 2023 21:54:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1Iv/JPivv8gaXFUDuV+9Dfaf9FrsyxCnmRcQFTbhR4s=; b=ZaSI6JePFj0g4boTbd7Suz2Xtp bvwRuDF87jIcod2C9Ez/gKpVeHe7+PNwOntjlaOUB2wzXYKL+dLt7C8l+pWOy4mutwV2KIDQBnLNF scBQ0BGcmXN/Ca6IjOzgKdOjYHoBvq8xdhDong2oYY8Haa18K7sV1q3soSW8FJlGKdhwdRVASC/zn m17541x3C2k6C2C/99bOX+NlD+ggPeTtrp1aLNjYYllf7X2xzePbgUBepy070arvKu9FCYIuduYSs /kuWwBA3j/B9iCMXrEJdQ3zYiCVT6fSQq4k4FbocU0TZO7a6hGFz68+9kIYW2hO1PvDQ+kncNeevO pUO82Yqg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rAONo-006LQO-1e; Tue, 05 Dec 2023 05:54:12 +0000 Date: Mon, 4 Dec 2023 21:54:12 -0800 From: Luis Chamberlain To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Paul Gortmaker , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] init: move THIS_MODULE from to Message-ID: References: <20231126071914.932241-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231126071914.932241-1-masahiroy@kernel.org> Sender: Luis Chamberlain X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 04 Dec 2023 21:54:21 -0800 (PST) On Sun, Nov 26, 2023 at 04:19:14PM +0900, Masahiro Yamada wrote: > Commit f50169324df4 ("module.h: split out the EXPORT_SYMBOL into > export.h") appropriately separated EXPORT_SYMBOL into > because modules and EXPORT_SYMBOL are orthogonal; modules are symbol > consumers, while EXPORT_SYMBOL are used by symbol providers, which > may not be necessarily a module. > > However, that commit also relocated THIS_MODULE. As explained in the > commit description, the intention was to define THIS_MODULE in a > lightweight header, but I do not believe was the > suitable location because EXPORT_SYMBOL and THIS_MODULE are unrelated. > > Move it to another lightweight header, . The reason for > choosing is to make self-contained > without relying on incorrectly including > . > > With this adjustment, the role of becomes clearer as > it only defines EXPORT_SYMBOL. > > Signed-off-by: Masahiro Yamada Reviewed-by: Luis Chamberlain Do you want this this to go through modules-next or your tree? I'm fine it goes either way. Luis