Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <692cd503-5b14-4be6-831d-d8e9c282a95e@quicinc.com>
Date:   Tue, 5 Dec 2023 11:28:51 +0530
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2 1/3] ufs: core: Add CPU latency QoS support for ufs
 driver
To:     Bart Van Assche <bvanassche@acm.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Peter Wang <peter.wang@mediatek.com>,
        Manivannan Sadhasivam <mani@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        "Matthias Brugger" <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>, <chu.stanley@gmail.com>
CC:     Alim Akhtar <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>,
        <linux-arm-msm@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <quic_cang@quicinc.com>,
        <quic_nguyenb@quicinc.com>, Nitin Rawat <quic_nitirawa@quicinc.com>
References: <20231204143101.64163-1-quic_mnaresh@quicinc.com>
 <20231204143101.64163-2-quic_mnaresh@quicinc.com>
 <590ade27-b4da-49be-933b-e9959aa0cd4c@acm.org>
Content-Language: en-US
From:   Naresh Maramaina <quic_mnaresh@quicinc.com>
In-Reply-To: <590ade27-b4da-49be-933b-e9959aa0cd4c@acm.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12/5/2023 12:30 AM, Bart Van Assche wrote:
> On 12/4/23 06:30, Maramaina Naresh wrote:
>> +    u32    (*config_qos_vote)(struct ufs_hba *hba);
> 
> Please remove the above callback since this patch series does not
> introduce any instances of this callback.
> 

Sure Bart, i will take care of this comment in next patch set.
If some SoC vendor have a different qos vote value then this callback 
can be added in future.

>> +
>> +    /* This capability allows the host controller driver to use the 
>> PM QoS
>> +     * feature.
>> +     */
>> +    UFSHCD_CAP_PM_QOS                = 1 << 13,
>>   };
> 
> Why does it depend on the host driver whether or not PM QoS is
> enabled? Why isn't it enabled unconditionally?

For some platform vendors power KPI might be more important than random 
io KPI. Hence this flag is disabled by default and can be enabled based 
on platform requirement.

> 
>> + * @pm_qos_req: PM QoS request handle
>> + * @pm_qos_init: flag to check if pm qos init completed
>>    */
> 
> Documentation for pm_qos_init is missing.
> 
Sorry, i didn't get your comment, i have already added documentation for 
@pm_qos_init, @pm_qos_req variable as above. Do you want me to add this 
information some where else as well?


>>   struct ufs_hba {
>>       void __iomem *mmio_base;
>> @@ -1076,6 +1089,9 @@ struct ufs_hba {
>>       struct ufs_hw_queue *uhq;
>>       struct ufs_hw_queue *dev_cmd_queue;
>>       struct ufshcd_mcq_opr_info_t mcq_opr[OPR_MAX];
>> +    struct pm_qos_request pm_qos_req;
>> +    bool pm_qos_init;
>> +    u32 qos_vote;
> 
> Please rename "pm_qos_init" into "pm_qos_initialized".
> 

Sure Bart, i will take care of this comment in next patch set.

> Thanks,
> 
> Bart.
> 

Thanks,
Naresh.