Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>,
        Sean Christopherson <seanjc@google.com>
CC:     "Zhao, Yan Y" <yan.y.zhao@intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "will@kernel.org" <will@kernel.org>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "Liu, Yi L" <yi.l.liu@intel.com>
Subject: RE: [RFC PATCH 00/42] Sharing KVM TDP to IOMMU
Thread-Topic: [RFC PATCH 00/42] Sharing KVM TDP to IOMMU
Thread-Index: AQHaJQO3kBR+d+LKkUe3K6mDC1fRXbCZXNyAgAAIQQCAAB9kgIAAB9qAgAC3GPA=
Date:   Tue, 5 Dec 2023 07:17:31 +0000
Message-ID: <BN9PR11MB52762F1CE520E127D0B7250C8C85A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20231202091211.13376-1-yan.y.zhao@intel.com>
 <ZW4Fx2U80L1PJKlh@google.com> <20231204173028.GJ1493156@nvidia.com>
 <ZW4nCUS9VDk0DycG@google.com> <20231204195055.GA2692119@nvidia.com>
In-Reply-To: <20231204195055.GA2692119@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8WNip2meP4XdS0QpooomPrSphF6H0qs4FEWhP6/hfK/sPeK3I6rfQX0YmNfH?=
 =?us-ascii?Q?M1Jq7YT8+otnnfOWGyMqOkSvEawOi2XTrIglV4mqVEwk29C+wFJjxizXoi2l?=
 =?us-ascii?Q?aUCM2xOZbSmE9N5MTcIr8edIJ0zA9qwIy+G5i6JKHzmrYpmNTWkVSL7+AXq1?=
 =?us-ascii?Q?b4b7dQ+ftO62Dxok2ZhLbukb1YYdHwuO9zRF6k9b8Ki1vegMd5uDtM7E0b9J?=
 =?us-ascii?Q?gIwijMUFISck6RhEcdGYigDIYwkF6FxEuO8M5hJm4h8+VZkv5+wvH6Y1kGGY?=
 =?us-ascii?Q?mchazAoSmQ8XiIDL1KHcJUf7gDfs4LZrC6YDmLPAW1vUFaCVBnCfC83lnfSb?=
 =?us-ascii?Q?UurOEuI3173M5MdWELRyMVW9sKLWT56s7ahEuOVzwJpMjwWb8vYJqbetabNx?=
 =?us-ascii?Q?lV9KLbbaXfdGz3jdz7Y6WEr/WSD3FfpaPtnKwSqoeHdmcpVXF8yeUCAXQdZb?=
 =?us-ascii?Q?DUX5wYfnwQLkjZSiL5IwK15LueVD1nL/72zOr0gHANDDcvtEsTqA6ZXhqZrH?=
 =?us-ascii?Q?TjXag3E1WyWwC7VYwKZ7U7iYglvYCsLmul28TjaqpM10pJWxRGokbFsa8jfI?=
 =?us-ascii?Q?FjBZjHI+LNWT8iWT0JCH7bVxSNac/ifELosOjt4Qu+ZeaRdTKut8pwTQWPmd?=
 =?us-ascii?Q?jlyXwODvRRBGV2IR8yvkfafgHV0DK9BAfzY172rt4393ZqWcRsOzJY/b9mbN?=
 =?us-ascii?Q?yit91lfkxGMGs757gN9PLQr6bVnoPbTIcRUSVWGOvPJbat0bNc+5lGUPUO/j?=
 =?us-ascii?Q?0sY0BipRrbBZ1Es2tzd2q6aJ9LXmxGcnihv9vx8PtPdgx10k7qaI//dvrRWA?=
 =?us-ascii?Q?466aoFlRTfFV2vIrwNhpsUnw4iBwjfOucuuStxWB2puO2GfiucVTr1g8u4ZS?=
 =?us-ascii?Q?XCBdDzwd91SeDSdgu7o5hWIHH4C08ftyvkQotn8vARe9xyDt32O+fnX5ePAH?=
 =?us-ascii?Q?8JqvSqYgnqB3haIPw6MslNEr1ASxUsqjvFBUxuoJ2iF1b6bgNuwfCjJHNjt3?=
 =?us-ascii?Q?xjl1nZsIYSImm5PPGD30776gkYQr+Xk/5w9/N10dMKHr3QCSmbCcO7lnS8o2?=
 =?us-ascii?Q?ZDHP1qNp9ctElWBHdVPSBM869fYpZKl48J/ampTTTgPnbl2NyU9hI40hZpGD?=
 =?us-ascii?Q?3G5vRVpZserD1qSdJyP7nFnm3ix80yr2sfUU6Ew6ON/ocHSg+8VcIQPEuxcY?=
 =?us-ascii?Q?Fp4FyBeRN9hgCnkN1Z0jqtKX7rE53/Tz2vVPVE3lFYbi9keAik7KhvALxpVV?=
 =?us-ascii?Q?UeFvX/t4ow4i/xkr6vDAVMSmbBuAUuGrDECnNTYtZEAPluALt4Uo8L/oEpIq?=
 =?us-ascii?Q?xEq/aIK/a28InNo4GqF6/VIUmK4bazC9cuw8xIli7WPXmHxvZVhztZDUZLEC?=
 =?us-ascii?Q?edBHuMRaBToSy+fQhTzViJTCe8sMigVO/xbEkcBXhohRR3ApPE3qBThQiZrA?=
 =?us-ascii?Q?7uXqE4wLTyZEEqJ0KSAOsBEDt14RSQFHlOurKILUz6XDfpsVHrvzWwaDtXTr?=
 =?us-ascii?Q?Q/p/17oCckRgQ8xnEOSlt63VGiESMspT7lZAJwVU22P7cUXlobahznFwFd3K?=
 =?us-ascii?Q?NwjI5n4zv6K+uL5FBI1+/+tSyjWdvIUxso0YGCob?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1df7865-5b8d-4e40-6053-08dbf5623f1a
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2023 07:17:31.6847
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +wAoUk0CR9hPgqzwtEZS8SW+BfpA+zWvNiGCyQQGZflCCiBcvMtGPanvHnPnw6R1dgJjCVhxQptnI7V5WEy3FQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6981
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 04 Dec 2023 23:17:58 -0800 (PST)

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Tuesday, December 5, 2023 3:51 AM
>=20
> On Mon, Dec 04, 2023 at 11:22:49AM -0800, Sean Christopherson wrote:
> > It wouldn't even necessarily need to be a notifier per se, e.g. if we t=
aught
> KVM
> > to manage IOMMU page tables, then KVM could simply install mappings for
> multiple
> > sets of page tables as appropriate.

iommu driver still needs to be notified to invalidate the iotlb, unless we =
want
KVM to directly call IOMMU API instead of going through iommufd.

>=20
> This somehow feels more achievable to me since KVM already has all the
> code to handle multiple TDPs, having two parallel ones is probably
> much easier than trying to weld KVM to a different page table
> implementation through some kind of loose coupled notifier.
>=20

yes performance-wise this can also reduce the I/O page faults as the
sharing approach achieves.

but how is it compared to another way of supporting IOPF natively in
iommufd and iommu drivers? Note that iommufd also needs to support
native vfio applications e.g. dpdk. I'm not sure whether there will be
strong interest in enabling IOPF for those applications. But if the=20
answer is yes then it's inevitable to have such logic implemented in
the iommu stack given KVM is not in the picture there.

With that is it more reasonable to develop the IOPF support natively
in iommu side, plus an optional notifier mechanism to sync with
KVM-induced host PTE installation as optimization?