Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\))
Subject: Re: [PATCH 36/48] perf annotate-data: Introduce struct data_loc_info
From:   Athira Rajeev <atrajeev@linux.vnet.ibm.com>
In-Reply-To: <CAM9d7cgdUfdMnhmMpqnkpJyV5hJE9dgGuwPetSNM0KfDuYfs6A@mail.gmail.com>
Date:   Tue, 5 Dec 2023 12:47:29 +0530
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-perf-users <linux-perf-users@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Stephane Eranian <eranian@google.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        linux-toolchains@vger.kernel.org, linux-trace-devel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <4A9408B2-46A8-45B2-BC0E-A4187F7AD462@linux.vnet.ibm.com>
References: <20231012035111.676789-1-namhyung@kernel.org>
 <20231012035111.676789-37-namhyung@kernel.org>
 <852644CC-CF12-475A-A7D2-84EFDCE9D248@linux.vnet.ibm.com>
 <CAM9d7cgdUfdMnhmMpqnkpJyV5hJE9dgGuwPetSNM0KfDuYfs6A@mail.gmail.com>
To:     Namhyung Kim <namhyung@kernel.org>
Precedence: bulk


> On 05-Dec-2023, at 5:40=E2=80=AFAM, Namhyung Kim <namhyung@kernel.org> =
wrote:
>=20
> Hello,
>=20
> On Sun, Dec 3, 2023 at 8:22=E2=80=AFAM Athira Rajeev
> <atrajeev@linux.vnet.ibm.com> wrote:
>> Hi Namhyung,
>>=20
>> I have a thought there. For the type and typeoff sort keys to work, =
we depend on Dwarf support in perf, right ?
>> If the perf is built without dwarf support ( either due to older =
elfutils or missing libdw.h ) , find_data_type will return NULL and we =
will get =E2=80=9Cunknown=E2=80=9D for Data Type and Data Type Offset in =
the result.
>=20
> Yes, right.
>=20
>>=20
>> Can we add a pr_debug line in find_data_type (which is in else part =
for HAVE_DWARF_SUPPORT) so that user can understand if =E2=80=9Cunknown=E2=
=80=9D is due to missing devel during the build ? Or may be restrict -s =
type,typeoff if dwarf support is missing ?
>=20
> I think it's better to add a warning if DWARF is not supported.
> Thanks for your review!

Sure, having a warning if DWARF is not supported will help

Thanks
Athira
>=20
> Namhyung