Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 5 Dec 2023 15:08:03 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>
CC:     <iommu@lists.linux.dev>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <alex.williamson@redhat.com>,
        <pbonzini@redhat.com>, <seanjc@google.com>, <joro@8bytes.org>,
        <will@kernel.org>, <robin.murphy@arm.com>, <kevin.tian@intel.com>,
        <baolu.lu@linux.intel.com>, <dwmw2@infradead.org>,
        <yi.l.liu@intel.com>
Subject: Re: [RFC PATCH 12/42] iommufd: Introduce allocation data info and
 flag for KVM managed HWPT
Message-ID: <ZW7MU4L9vybiDqZt@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20231202091211.13376-1-yan.y.zhao@intel.com>
 <20231202092113.14141-1-yan.y.zhao@intel.com>
 <20231204182928.GL1493156@nvidia.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231204182928.GL1493156@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HqDjlyDdu1p+M9wctIEDKIWqrZMSIVCuYSbym9zWVYYk4qQUXZS4mnlfg8s5?=
 =?us-ascii?Q?aytUlXR8I0MWEJ/qlY5Y6YJhpLZ/SgQIv6s6MUfVHdssBfgk3M3YW2RYa1IQ?=
 =?us-ascii?Q?lzWu385xieZG47+w0bvH9KinK17Pgw8R61nLBzsCJ3eHknkFXvhXz+2fGZdR?=
 =?us-ascii?Q?cVJdhwLGwvXsdNsS92EU2k7pxIjvHz3964pQ07nkpWTakE7imJudJymjorJl?=
 =?us-ascii?Q?di1y51WtQrcVYpO1BbbygJdNQMJ9X6Rx4yYNllc4Ja0dcK1jnXv3GXaQydtm?=
 =?us-ascii?Q?8cUcVJdX/8HgyxzGqdaNIQc7ODr17sMEg34jTeo3mEbxD/UAMe5K3IKUEX65?=
 =?us-ascii?Q?IPSRmwqy+j6trswmiPCW+gy/b657fOP+yQ+zZTdIYuKprM1k1tjtfEEkzoJb?=
 =?us-ascii?Q?xxZgcgFrV2DEz1Yqs2hE/OMWqQrxm7GVor3oI4JaaXpa+qkSIXlX8PikITJ5?=
 =?us-ascii?Q?qvGg6HK0JJONkyRE4Jh0qWaeSV/vC4f6p902lHjlSA6UzR3qeQ9G01l/MF8I?=
 =?us-ascii?Q?zd3ANRtRaTR/6BqYNTz5k2Xe0H3NrEqseilt/mvoh9DLyZoNdgW367EgBDFE?=
 =?us-ascii?Q?pZZBVgWfjnUZ6CTHFxJ3GzJNm2z9bu8nMSllgO5gSR+5P6H3aeDOuzTC/h9R?=
 =?us-ascii?Q?fM5aLoIDOm8SjcMWmnS6KLb9Y1pP12QmZzYjeFceYKz4dSXqRjqSCWc7Jo0R?=
 =?us-ascii?Q?Bx2LZ+yRKbCFqOMfKwG38sQh9XTQQBLSRNGRwr23CUIIvx4i5BYFalb4VTUj?=
 =?us-ascii?Q?F4hzLyhb2BoBbM7+6Lxttx2L/ZaFJO46inz1DlrvaKU6zXWvAA2XHs3bfY4M?=
 =?us-ascii?Q?V9J6wjzZxcNmNVeVPB1A3AEGknaBqwcOhbCWTP1Rt+epYguQyRu6v2ZxJP3F?=
 =?us-ascii?Q?fAjB+wSYiPOUOIX+1eULmMWMG+XLw2U4Ycp+c/8DAt4t73EnN2EPbdeeQGCi?=
 =?us-ascii?Q?YwX5wsN4GFH/tFBh6FzPgwAZnX+QezMC8uw9tb9atxwqbYj9SOQ3ojAx0BTz?=
 =?us-ascii?Q?xUJsF4LdmgKAW19O0oEs3tYv8d2a9rxwM5P3fPIGTc5S3MEQ3Caqgbr2ADob?=
 =?us-ascii?Q?djeHR31QWkv0m2qjQOTQeTkbw1sg4RZ9Uuf8p77odWEOj3hzHr7MASgQ9kPU?=
 =?us-ascii?Q?NkXRaKI77tA+ysJEtMSNTWW30Eqt77svYihrdxT0IBsww91u6sAO8Pq8mnHd?=
 =?us-ascii?Q?oW0ZgAB5Hn4mUFO7HegnX8ox+td/CHNoBxzEHnyg4H3zV1UnG8xbUlzjlqkw?=
 =?us-ascii?Q?dA8ytrhqfNekp/UQU4trHIh9Jj++GKw8oh7rkCxD/aYfA4O3563F3JC6y/q5?=
 =?us-ascii?Q?kk34I+yhSBWIQO1SmtuDMV7Erh96mqVrqvGuJTtOGjLN5+0zk2yfw1m2mpE5?=
 =?us-ascii?Q?JU60VAm29/EGdT8x2cx9mfdVlI4FhmB2aFCz2XvsABhVe6LIrEb2Nebjg8pw?=
 =?us-ascii?Q?d4UwlzTBZrzPk8axmJEVYxsvHomgx1kh2rm48vou2kJkSFiS7HGzQYH6LuKa?=
 =?us-ascii?Q?tDDMH4cEPIZJm5OJ2SyWsjYy6rd+s7E154DK+BEHaX/jLVyRRQETBZRDNt+S?=
 =?us-ascii?Q?STKDMhm030IM1VPEWPXcf8gTxZFyfCh5bcEW//IX?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 60fd52e1-f5b5-4c4d-3e00-08dbf564fb60
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2023 07:37:06.9062
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zeenYO+IxxLL71p7FxiZVtN3D7sm1TKOSWKfbZRHHybw0Skn7I967JXVXJap33spzLgKwswuYuHssV7dAIXwJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4514
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 04 Dec 2023 23:37:22 -0800 (PST)

On Mon, Dec 04, 2023 at 02:29:28PM -0400, Jason Gunthorpe wrote:
> On Sat, Dec 02, 2023 at 05:21:13PM +0800, Yan Zhao wrote:
> 
> > @@ -413,11 +422,13 @@ struct iommu_hwpt_arm_smmuv3 {
> >   * @IOMMU_HWPT_DATA_NONE: no data
> >   * @IOMMU_HWPT_DATA_VTD_S1: Intel VT-d stage-1 page table
> >   * @IOMMU_HWPT_DATA_ARM_SMMUV3: ARM SMMUv3 Context Descriptor Table
> > + * @IOMMU_HWPT_DATA_KVM: KVM managed stage-2 page table
> >   */
> >  enum iommu_hwpt_data_type {
> >  	IOMMU_HWPT_DATA_NONE,
> >  	IOMMU_HWPT_DATA_VTD_S1,
> >  	IOMMU_HWPT_DATA_ARM_SMMUV3,
> > +	IOMMU_HWPT_DATA_KVM,
> >  };
> 
> Definately no, the HWPT_DATA is for the *driver* - it should not be
> "kvm".
> 
> Add the kvm fd to the main structure
>
Do you mean add a "int kvm_fd" to "struct iommu_hwpt_alloc" ?
struct iommu_hwpt_alloc {
        __u32 size;
        __u32 flags;
        __u32 dev_id;
        __u32 pt_id;
        __u32 out_hwpt_id;
        __u32 __reserved;
        __u32 data_type;
        __u32 data_len;
        __aligned_u64 data_uptr;
};

Then always create the HWPT as IOMMUFD_OBJ_HWPT_KVM as long as kvm_fd > 0 ?