Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 5 Dec 2023 15:14:09 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>
CC:     <iommu@lists.linux.dev>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <alex.williamson@redhat.com>,
        <pbonzini@redhat.com>, <seanjc@google.com>, <joro@8bytes.org>,
        <will@kernel.org>, <robin.murphy@arm.com>, <kevin.tian@intel.com>,
        <baolu.lu@linux.intel.com>, <dwmw2@infradead.org>,
        <yi.l.liu@intel.com>
Subject: Re: [RFC PATCH 16/42] iommufd: Enable device feature IOPF during
 device attachment to KVM HWPT
Message-ID: <ZW7NwSCzswweHZh6@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20231202091211.13376-1-yan.y.zhao@intel.com>
 <20231202092311.14392-1-yan.y.zhao@intel.com>
 <20231204183603.GN1493156@nvidia.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231204183603.GN1493156@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5hHi28MY4mBD7vFLISClG2oam/lA9c6I3ksdj1mtc3urqJ6846E0cwLTvPQV?=
 =?us-ascii?Q?qHCYXe7VRqOs5il59IouFmTipCDePqlt7Y/IyV1Y5PJJZhCv7qZT8uDYk6el?=
 =?us-ascii?Q?UOl4mxbemWobYlGz4HHnINzabXAJ4Y8V3FSHJPRpDu/M9vud8Od5fJH22R3m?=
 =?us-ascii?Q?jE/lW2VmEXmTC9nuNjJtQSxly/H07ob88jDIw8Kr9VuOaKFrfnsR3Fuy/LVV?=
 =?us-ascii?Q?yLQID7gS6qufy2WbFlDSZTRJKkkWzaxMD6KtwBfKkqN66bt+wgm0mf71c/5i?=
 =?us-ascii?Q?EkbuHIANDgJueupZpvnm/EkSYkhfoZD7FTrJkpkv2lVaBgGaE2BeLBO8MRoF?=
 =?us-ascii?Q?OwIdzkTUobqfuptza0w8TbZmGLtcBRQtWK2qWRbp1vMiDna69rVB1WLYrXIj?=
 =?us-ascii?Q?t2ZWpHxFG6Wah1NK3t9ycDZ5z8LKOPPy3OIE8cOmF3ns4TPr0ZpdEb8Wimdr?=
 =?us-ascii?Q?BY0Gq4e3vEkrCXXBUk8mih/QNnSAaXJVehcLR8tPiqtshBuJu8JlWURtcdUJ?=
 =?us-ascii?Q?p/3MSDTbMoPC30ZY3Gl9zlbrkvW+w8W89WcdA2skgRF6u7sVv4p8glLkxrGx?=
 =?us-ascii?Q?ewb1bk9ULCprxysaMjQGJ5cA4qmIOOIKNUKhMlNE2Uo3a/yuW0oinTWma2yT?=
 =?us-ascii?Q?l6PqzG6E8MZ+Ww8vNRJFM3+qkEE+U2PDb8txa5LHmo8X0dk6szGjRifjZEtt?=
 =?us-ascii?Q?qAyIteFVzOLjafjcvL549l0iWRLryxes9v6NbaQiezjQrKNQmtuC+lNhvv6+?=
 =?us-ascii?Q?ow+23GcDVhN49jUWISu2JtKfHtUFTBW4VqC6q1zgUkUWrHAEFDX7qlAZACN6?=
 =?us-ascii?Q?EcMYNts25Ms663jz9Vz0wtoFIKsDPS2aoNaJ+GlGVWtlswXsBuTwn/KejLtx?=
 =?us-ascii?Q?FqpV17qOppZiAG+8hMbSYDagaqNB8A7pCasbIepYLUFPFVQpRwOIWCSz4YF3?=
 =?us-ascii?Q?0+jo1v/+lZX/xYm9jKh7s+PzYeCDvxsG6bUFjaRtJdKmw4nTxo6uaKL7Dc+o?=
 =?us-ascii?Q?FRjJM8JcXtvqa3cYzrXi/C9MVtuyGo26kwWGGxdud2nFAArxoaYrOQw1vIYX?=
 =?us-ascii?Q?tnq9F9oXcDFqFpg7Xda43J0ot8zbNemjMXikWBWUZaPP4jrphaBHXpwKwwsk?=
 =?us-ascii?Q?8Cte/TH80eaMkOiBKihT4Hr/K7sDrKU6dBTODc7YoP5gd+dod9O7QX5hqKLv?=
 =?us-ascii?Q?slMsthCXuVokzjjZxDcl4/+lOH9JprrHU82tkqplNX5Burf6rnjmSNVnE/Dw?=
 =?us-ascii?Q?8tnee0z2kdwDhl+1LLMv4NR0Iosk9/QaxS6NGgUpfG7x1nptBei6GP1KHekI?=
 =?us-ascii?Q?XqwGyjB+oW+6b+wtNutWY1GxSIWLzobajGBCtmOxyFlaqon2h9dA0Eeg9efh?=
 =?us-ascii?Q?QT94TNIpPZp8vyWmfyxH1GV3FD41dQBP8WDWKDZipL1l3yNzLWW4WetZ0RgH?=
 =?us-ascii?Q?bqNaAEnff+BkZykkU6MdzkEqrthQ+H4c3CiNSBxiqwELdaPZbujWzDavCRnu?=
 =?us-ascii?Q?y7U73XnKd/7gfkULPs9oRVqe2vMYSOyZrlZPw+Y7dczBVEXSco9axaICTUjj?=
 =?us-ascii?Q?Hm1SwVDJoXeoicA+szXZVZn6IzxhmrFg/F1eEOEM?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d4337d9a-63fd-4bee-9b0e-08dbf565d4d5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2023 07:43:11.5776
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PSAiFO4tcKpLdFP65wxUnVpD3+o5yChm75SJm1JQDf3sR54/K2pxh/ArEnmMvztSJ9j3znAyn4Qm6PXC/dNlrg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6249
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 04 Dec 2023 23:43:33 -0800 (PST)

On Mon, Dec 04, 2023 at 02:36:03PM -0400, Jason Gunthorpe wrote:
> On Sat, Dec 02, 2023 at 05:23:11PM +0800, Yan Zhao wrote:
> > Enable device feature IOPF during device attachment to KVM HWPT and abort
> > the attachment if feature enabling is failed.
> > 
> > "pin" is not done by KVM HWPT. If VMM wants to create KVM HWPT, it must
> > know that all devices attached to this HWPT support IOPF so that pin-all
> > is skipped.
> > 
> > Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
> > ---
> >  drivers/iommu/iommufd/device.c | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> > 
> > diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c
> > index 83af6b7e2784b..4ea447e052ce1 100644
> > --- a/drivers/iommu/iommufd/device.c
> > +++ b/drivers/iommu/iommufd/device.c
> > @@ -381,10 +381,26 @@ int iommufd_hw_pagetable_attach(struct iommufd_hw_pagetable *hwpt,
> >  			goto err_unresv;
> >  		idev->igroup->hwpt = hwpt;
> >  	}
> > +	if (hwpt_is_kvm(hwpt)) {
> > +		/*
> > +		 * Feature IOPF requires ats is enabled which is true only
> > +		 * after device is attached to iommu domain.
> > +		 * So enable dev feature IOPF after iommu_attach_group().
> > +		 * -EBUSY will be returned if feature IOPF is already on.
> > +		 */
> > +		rc = iommu_dev_enable_feature(idev->dev, IOMMU_DEV_FEAT_IOPF);
> > +		if (rc && rc != -EBUSY)
> > +			goto err_detach;
> 
> I would like to remove IOMMU_DEV_FEAT_IOPF completely please

So, turn on device PRI during device attachment in IOMMU vendor driver?