Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp125902rdb; Tue, 5 Dec 2023 00:03:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IGs1HI0xHeA83cN1hlOzUXOEHJ/tq0eCCwx7bhAtN+bRWwWKCftzgwKgm5tz8jyJtJNisl/ X-Received: by 2002:a92:cb50:0:b0:35c:8410:84ee with SMTP id f16-20020a92cb50000000b0035c841084eemr3389502ilq.24.1701763405101; Tue, 05 Dec 2023 00:03:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701763405; cv=none; d=google.com; s=arc-20160816; b=mdCRQPtvW3YX4aOdgPKkoUcKJ2ttAwJPcm33+E/TbfpNZhLcbH1HzxkscCMxXBVbVI qPg4eyH+qCXdPxTN1SMYdmW/VF6gOaO2eW7Txo/mBvfUBYSMNEIqf5RAbvt8CZd+/hl0 w8Wq5+aBUAD13pBx+Ra1H5fwcAPQe5ntlELGSigdthLZ6sSZLXw86do1ehku0m0BTr5u b32JBY5a+GtK4pVqumNf4pjH8oK907dguyceeyzfQjR4GZGSzIK5gb+5sbaoo2ZBn3b1 5QyV6Pn4qjElUIm87fOVpF/ycDkDkTf/qppzN9pNyDXmqrT/03ZCHCB9FX/t8SKqOBHj 4mWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:content-language:references:cc:to:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=NBBsY27wq9VmY+KpTBAEj8LMUoBYVmtkIhuVKVNt4x0=; fh=69u6sHx0lSvGYbGuc0phkbpr8Ti/tIs12OwNE4E0ywQ=; b=lz51pF+iO/rkqyvRUvcYmKqNfnAFDxdBTOZsSd0QLSnPiWzyo/0M4M1w4+HcbHHGjC g8tLOIKf/mndGXtZ8Aqq3F1hBaFT0GCMF01/2GeSVvq3Lo1Pn7k6GNJzbFxV2y/+tIWK CYKToSysaw/MZ8zSPV5+RTYrbv9AM1gvZ2vS9b3aZL+AZv9LqiAxx5RrjDqOlmLqOsJ2 mo3e8FAyeARryJQRPtyYbkqkeIzyhR+Km7PCqkwqOCW9r+2vt4Z/B6Uwz0L5+KwsEl7G F0XSsVO0yUUIlt2pTvRcTszbUqPjwQxUcd2cmBSxN6zKsQlf7uyFK9ZfLnWWobE7BDdI lJiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=D1mHGXGw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id d22-20020a63ed16000000b005c6248a0cd8si8980308pgi.23.2023.12.05.00.03.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 00:03:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=D1mHGXGw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id BD59B80A9AB3; Tue, 5 Dec 2023 00:03:22 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229980AbjLEIDI (ORCPT + 99 others); Tue, 5 Dec 2023 03:03:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229641AbjLEIDH (ORCPT ); Tue, 5 Dec 2023 03:03:07 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4448A127 for ; Tue, 5 Dec 2023 00:03:13 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a1c890f9b55so25208166b.1 for ; Tue, 05 Dec 2023 00:03:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701763391; x=1702368191; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=NBBsY27wq9VmY+KpTBAEj8LMUoBYVmtkIhuVKVNt4x0=; b=D1mHGXGwccHJELggpcBHmTymM1jtrkPEc+uU5b2eGoBL2xAkyA4DqpjScs0Qgk5qmR qZkMCv86uf2+tUoaDykRDKo4bAz/iXMpu1fNPdQD8WKXQiVFEEhFs9quni3s+Eh6ahN7 BEDKdryB/ykvnQzR/u8EUHlSqCQFp2DzH0vFvrR2uH4ntak1gz/vdkUsbmJQkQp9A0pY c7tYyySgWDVvIasKMV5Z3i09L5vwLvCClQC9YAsoe4LuUKg8kFuz4UvQtDEgyXUMtNQS q8YVvYXp8VWOcuQf6yIQmvyVOBXTNlz9ezMRneRNJCa3xYAErWkJmizK9zznsGHWznWI 0eyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701763391; x=1702368191; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NBBsY27wq9VmY+KpTBAEj8LMUoBYVmtkIhuVKVNt4x0=; b=pSZ1dlNSdTAbVci6ALuJ74CoyywcI/bmGyd+5ARfpi5aaZglOJbpYQoJzLwgeeZ8vL PLseX010vv2qRgJSUkRF85OaaTlRvcq1XzaprjzbJI2qmQq0unNmqDjnQA3h7rSS3tPC txRVUnuElgvgfu0NO6RhlS8fFJxTNcl66CSRjeBizk9QzMcHst8rVOxonMEg93ZqNmw+ YpfBxAHV4QuRlnP32jkLlbkvx9ex2HQO4KNJj08C+HVJ4cNJIYSFmAOL7xRZuf62fwV2 iq5odo22c8E0AAeGmUDRld2h1eN6OE6qyjq7VH3DHvHvBMDJW1VJP1yxf7JXuMGYYkCq bLPg== X-Gm-Message-State: AOJu0YwfuhAOa7Xfb1p2ViZp9wI9uP1Ij8IGoMoYoTCGG4TGxl+LTi8d lqkex9t+h04ap8TN/mOVZo6SBg== X-Received: by 2002:a17:906:3f17:b0:a19:a1ba:da39 with SMTP id c23-20020a1709063f1700b00a19a1bada39mr3858179ejj.96.1701763391609; Tue, 05 Dec 2023 00:03:11 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id g2-20020a1709064e4200b00a1cb351dd4fsm174276ejw.9.2023.12.05.00.03.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Dec 2023 00:03:11 -0800 (PST) Message-ID: Date: Tue, 5 Dec 2023 09:03:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs To: Tony Lindgren Cc: Andrew Davis , Frank Binns , Donald Robson , Matt Coster , "H . Nikolaus Schaller" , Adam Ford , Ivaylo Dimitrov , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Paul Cercueil , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-omap@vger.kernel.org, linux-mips@vger.kernel.org References: <20231204182245.33683-1-afd@ti.com> <20231204182245.33683-2-afd@ti.com> <20231205075657.GN5169@atomide.com> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231205075657.GN5169@atomide.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 05 Dec 2023 00:03:22 -0800 (PST) On 05/12/2023 08:56, Tony Lindgren wrote: > * Krzysztof Kozlowski [231205 07:10]: >> On 04/12/2023 19:22, Andrew Davis wrote: >>> @@ -56,6 +76,43 @@ allOf: >>> properties: >>> clocks: >>> maxItems: 1 >>> + required: >>> + - clocks >>> + - clock-names >> >> You need to define the clocks for your variants or disallow them. The >> original code should be fixed as well and make the clocks fixed for all >> img-axe cases. > > To clarify, the clocks may be optional as they can be hardwired and coming > from the interconnect target wrapper module and enabled with runtime PM. What does runtime PM have to do with it? If runtime PM enables clocks, these are real signals and not optional. The bindings is quite unspecific in that matter which is not what we want usually. If you have implementation which does not have these clocks exposed, then disallow them. Just don't make it floating like it is in existing binding and how Andrew continues for new devices. Best regards, Krzysztof