Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1178-geeaf0069a7-fm-20231114.001-geeaf0069
MIME-Version: 1.0
Message-Id: <820dd18d-21a9-4c0d-ad92-021dc9b782b4@app.fastmail.com>
In-Reply-To: <8f5f9a4b-f809-44cb-8f26-05e39b29dfb6@wanadoo.fr>
References: <20231204085735.4112882-1-arnd@kernel.org>
 <8f5f9a4b-f809-44cb-8f26-05e39b29dfb6@wanadoo.fr>
Date:   Mon, 04 Dec 2023 21:06:53 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
        "Arnd Bergmann" <arnd@kernel.org>,
        "Yisen Zhuang" <yisen.zhuang@huawei.com>,
        "Salil Mehta" <salil.mehta@huawei.com>,
        "David S . Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>
Cc:     "Jijie Shao" <shaojijie@huawei.com>,
        "Hao Chen" <chenhao418@huawei.com>,
        Netdev <netdev@vger.kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] net: hns3: reduce stack usage in hclge_dbg_dump_tm_pri()
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Dec 4, 2023, at 19:54, Christophe JAILLET wrote:
> Le 04/12/2023 =C3=A0 09:57, Arnd Bergmann a =C3=A9crit=C2=A0:
>>=20
>> Use dynamic allocation for the largest stack object instead. It
>> would be nice to rewrite this file to completely avoid the extra
>> buffer and just use the one that was already allocated by debugfs,
>> but that is a much larger change.
>>=20
> could :
>     pos +=3D scnprintf(buf + pos, len - pos, "%s", <something>);
> be more widely used to avoid the alloc()/free() + copy of strings?

Yes, I think that would help, but this is beyond what I trust
myself to do blindly.

     Arnd