Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Tue, 5 Dec 2023 09:39:02 +0100
From:   Maxime Ripard <mripard@kernel.org>
To:     Jessica Zhang <quic_jesszhan@quicinc.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Clark <robdclark@gmail.com>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Sean Paul <sean@poorly.run>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        quic_abhinavk@quicinc.com, ppaalanen@gmail.com,
        contact@emersion.fr, laurent.pinchart@ideasonboard.com,
        sebastian.wick@redhat.com, ville.syrjala@linux.intel.com,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
        wayland-devel@lists.freedesktop.org
Subject: Re: [PATCH RFC v7 07/10] drm/atomic: Loosen FB atomic checks
Message-ID: <nxxuloh65mlajjwvu5tazxraolrhvpz3kcsjji4alda76xgctv@ua6zwrrgucml>
References: <20231027-solid-fill-v7-0-780188bfa7b2@quicinc.com>
 <20231027-solid-fill-v7-7-780188bfa7b2@quicinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="vg2ogmm6wxqd5eta"
Content-Disposition: inline
In-Reply-To: <20231027-solid-fill-v7-7-780188bfa7b2@quicinc.com>
Precedence: bulk


--vg2ogmm6wxqd5eta
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, Oct 27, 2023 at 03:32:57PM -0700, Jessica Zhang wrote:
> Loosen the requirements for atomic and legacy commit so that, in cases
> where pixel_source !=3D FB, the commit can still go through.
>=20
> This includes adding framebuffer NULL checks in other areas to account for
> FB being NULL when non-FB pixel sources are enabled.
>=20
> To disable a plane, the pixel_source must be NONE or the FB must be NULL
> if pixel_source =3D=3D FB.
>=20
> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>

This breaks some plane kunit tests we have:

See https://lore.kernel.org/dri-devel/20231204173536.51003-1-naresh.kamboju=
@linaro.org/

Maxime

--vg2ogmm6wxqd5eta
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZW7hpgAKCRDj7w1vZxhR
xRaSAP4ozFoBHnSVpdZs8a5pPi+lP4+/seXLresmMqgkjyFRNQD/ZVWVZ6F9ldOa
j7LNrKY0oxu+rklJhK3G1KPgR+rzyg4=
=3ESI
-----END PGP SIGNATURE-----

--vg2ogmm6wxqd5eta--