Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <d4cacfdc-873a-46ae-86d6-8838e867bbe4@linux.intel.com>
Date:   Tue, 5 Dec 2023 10:02:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/4] ASoC: topology: Replace fake root_device with
 kunit_device in tests
Content-Language: en-US
To:     davidgow@google.com, Rae Moar <rmoar@google.com>,
        Brendan Higgins <brendan.higgins@linux.dev>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Matti Vaittinen <mazziesaccount@gmail.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Kees Cook <keescook@chromium.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Maxime Ripard <mripard@kernel.org>
Cc:     linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org, linux-sound@vger.kernel.org
References: <20231205-kunit_bus-v1-0-635036d3bc13@google.com>
 <20231205-kunit_bus-v1-4-635036d3bc13@google.com>
From:   =?UTF-8?Q?Amadeusz_S=C5=82awi=C5=84ski?= 
        <amadeuszx.slawinski@linux.intel.com>
In-Reply-To: <20231205-kunit_bus-v1-4-635036d3bc13@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/5/2023 8:31 AM, davidgow@google.com wrote:
> Using struct root_device to create fake devices for tests is something
> of a hack. The new struct kunit_device is meant for this purpose, so use
> it instead.
> 
> Signed-off-by: David Gow <davidgow@google.com>
> ---
>   sound/soc/soc-topology-test.c | 11 +++--------
>   1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/sound/soc/soc-topology-test.c b/sound/soc/soc-topology-test.c
> index 2cd3540cec04..1d7696e5bffc 100644
> --- a/sound/soc/soc-topology-test.c
> +++ b/sound/soc/soc-topology-test.c
> @@ -10,6 +10,7 @@
>   #include <sound/soc.h>
>   #include <sound/soc-topology.h>
>   #include <kunit/test.h>
> +#include <kunit/device.h>

Nitpick:
Can we add device.h before test.h, to keep it in alphabetical order?

>   
>   /* ===== HELPER FUNCTIONS =================================================== */
>   
> @@ -21,26 +22,20 @@
>    */
>   static struct device *test_dev;
>   
> -static struct device_driver test_drv = {
> -	.name = "sound-soc-topology-test-driver",
> -};
> -
>   static int snd_soc_tplg_test_init(struct kunit *test)
>   {
> -	test_dev = root_device_register("sound-soc-topology-test");
> +	test_dev = kunit_device_register(test, "sound-soc-topology-test");
>   	test_dev = get_device(test_dev);
>   	if (!test_dev)
>   		return -ENODEV;
>   
> -	test_dev->driver = &test_drv;
> -
>   	return 0;
>   }
>   
>   static void snd_soc_tplg_test_exit(struct kunit *test)
>   {
>   	put_device(test_dev);
> -	root_device_unregister(test_dev);
> +	kunit_device_unregister(test, test_dev);
>   }
>   
>   /*
>