Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Tue, 5 Dec 2023 10:05:02 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     POPESCU Catalin <catalin.popescu@leica-geosystems.com>
Cc:     "srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>,
        "michael@walle.cc" <michael@walle.cc>,
        "rafal@milecki.pl" <rafal@milecki.pl>,
        "robh@kernel.org" <robh@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        GEO-CHHER-bsp-development 
        <bsp-development.geo@leica-geosystems.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Luca Ceresoli <luca.ceresoli@bootlin.com>
Subject: Re: [PATCH] nvmem: fix issue within nvmem_register with
 fixed-layout.
Message-ID: <20231205100502.623863ff@xps-13>
In-Reply-To: <16c4c272-1a19-4fb8-8a2d-b2cf61ba37f2@leica-geosystems.com>
References: <20231130162922.2989774-1-catalin.popescu@leica-geosystems.com>
        <16c4c272-1a19-4fb8-8a2d-b2cf61ba37f2@leica-geosystems.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Catalin,

+ GKH
+ Luca (who initially reported this issue)

catalin.popescu@leica-geosystems.com wrote on Tue, 5 Dec 2023 08:48:27
+0000:

> Adding more people.
>=20
> On 30.11.23 17:29, Catalin Popescu wrote:
> > fixed-layout is natively supported by NVMEM framework.
> > Yet, it's not been declared as a supported layout. As a
> > result, nvmem_register always returns -EPROBE_DEFER if
> > configuration has no layout and the NVMEM provider DT
> > uses a fixed layout.
> >
> > As a fix, declare fixed-layout as a supported layout
> > and use add_cells callback to parse the cells. This adds
> > consistency over layouts parsing as fixed-layout parsing
> > is handled in the same way than others nvmem layouts.

I believe this patch (not taken yet) should fix your issue and should be
queued to fixes.

Link: https://lore.kernel.org/lkml/20231124193814.360552-1-miquel.raynal@bo=
otlin.com/

However I like your approach which should probably be taken into
consideration for the next cycle, as I think it fits Rafal's
original idea pretty well.

> >
> > Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
> > ---
> >   drivers/nvmem/core.c | 24 +++++++++++++++++-------
> >   1 file changed, 17 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> > index bf42b7e826db..3467c94207e8 100644
> > --- a/drivers/nvmem/core.c
> > +++ b/drivers/nvmem/core.c
> > @@ -746,7 +746,9 @@ static int nvmem_add_cells_from_legacy_of(struct nv=
mem_device *nvmem)
> >   	return nvmem_add_cells_from_dt(nvmem, nvmem->dev.of_node);
> >   }
> >  =20
> > -static int nvmem_add_cells_from_fixed_layout(struct nvmem_device *nvme=
m)
> > +static int nvmem_add_cells_from_fixed_layout(struct device *dev,
> > +					     struct nvmem_device *nvmem,
> > +					     struct nvmem_layout *layout)

I've sent another series (on top of the fix mentioned above) to
simplify a bit this list of parameters, so both will conflict. But that
will be easy to solve.

Link: https://lore.kernel.org/lkml/20231129163737.698317-1-miquel.raynal@bo=
otlin.com/

> >   {
> >   	struct device_node *layout_np;
> >   	int err =3D 0;
> > @@ -755,8 +757,7 @@ static int nvmem_add_cells_from_fixed_layout(struct=
 nvmem_device *nvmem)
> >   	if (!layout_np)
> >   		return 0;
> >  =20
> > -	if (of_device_is_compatible(layout_np, "fixed-layout"))
> > -		err =3D nvmem_add_cells_from_dt(nvmem, layout_np);
> > +	err =3D nvmem_add_cells_from_dt(nvmem, layout_np);
> >  =20
> >   	of_node_put(layout_np);
> >  =20
> > @@ -1003,10 +1004,6 @@ struct nvmem_device *nvmem_register(const struct=
 nvmem_config *config)
> >   			goto err_remove_cells;
> >   	}
> >  =20
> > -	rval =3D nvmem_add_cells_from_fixed_layout(nvmem);
> > -	if (rval)
> > -		goto err_remove_cells;
> > -
> >   	rval =3D nvmem_add_cells_from_layout(nvmem);
> >   	if (rval)
> >   		goto err_remove_cells;
> > @@ -2126,6 +2123,19 @@ const char *nvmem_dev_name(struct nvmem_device *=
nvmem)
> >   }
> >   EXPORT_SYMBOL_GPL(nvmem_dev_name);
> >  =20
> > +static const struct of_device_id fixed_layout_of_match_table[] =3D {
> > +	{ .compatible =3D "fixed-layout", },
> > +	{},
> > +};
> > +MODULE_DEVICE_TABLE(of, fixed_layout_of_match_table);
> > +
> > +static struct nvmem_layout fixed_layout =3D {
> > +	.name =3D "NVMEM fixed layout",
> > +	.of_match_table =3D fixed_layout_of_match_table,
> > +	.add_cells =3D nvmem_add_cells_from_fixed_layout,
> > +};
> > +module_nvmem_layout_driver(fixed_layout);
> > +
> >   static int __init nvmem_init(void)
> >   {
> >   	return bus_register(&nvmem_bus_type); =20
>=20
>=20

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>


Thanks,
Miqu=C3=A8l