Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <6292bf7a-e56f-4f7f-843f-b95c1cbd343e@kylinos.cn>
Date:   Tue, 5 Dec 2023 17:12:54 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ASoC: SOF: Fix null pointer dereference in sof_pci_probe
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>
Cc:     pierre-louis.bossart@linux.intel.com, lgirdwood@gmail.com,
        peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com,
        ranjani.sridharan@linux.intel.com, daniel.baluta@nxp.com,
        kai.vehmanen@linux.intel.com, perex@perex.cz, tiwai@suse.com,
        chao.song@intel.com, kunwu.chan@hotmail.com,
        sound-open-firmware@alsa-project.org, linux-sound@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20231123155424.1275919-1-chentao@kylinos.cn>
 <7ddeea58-f5d8-415c-8c07-c34be04d6a9c@sirena.org.uk>
From:   Kunwu Chan <chentao@kylinos.cn>
In-Reply-To: <7ddeea58-f5d8-415c-8c07-c34be04d6a9c@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Thanks for your reply.
I'll check the patch and modify it by a better way.

Thanks again,
Kunwu

On 2023/12/4 20:38, Mark Brown wrote:
> On Thu, Nov 23, 2023 at 11:54:24PM +0800, Kunwu Chan wrote:
>> devm_kasprintf() returns a pointer to dynamically allocated memory
>> which can be NULL upon failure.
> 
> In addition to the issues others mentioned this doesn't apply against
> current code, please check and resend.