Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp163137rdb; Tue, 5 Dec 2023 01:35:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IHD6MPMLR8IBfmpjAEn6YefjY29MIeWNfAC4TsegKWKRqKVbQxA3ifmQonO49oeui35+qr8 X-Received: by 2002:a05:6a00:a1b:b0:6ce:493a:d7c2 with SMTP id p27-20020a056a000a1b00b006ce493ad7c2mr789466pfh.32.1701768958503; Tue, 05 Dec 2023 01:35:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701768958; cv=none; d=google.com; s=arc-20160816; b=rG+vw+BZEogxthMzsot4LLDP/tuIsUNMCctYhca0R+Afv7LLQRjchbOfrwHL6oEsll YJu7uwIs9qrz73l6zWM8zJ/f2ir/5Azq+7tVUVGYajZNc3888Mpc5l7nvsqJXpLjLEzg i0wWlPCUc8uRtEpfkN+dBR5UDLSFl5tr7sHKiGlRs/L2zHL+5U41XFtpxiJnL29QcabM 3ePvvu4Q/pWYIN8GZsj1jrvg1Bc8NP6OxHmYJu/WoL3GxTJCpDlvQ217dM0Ob0k5KU0G KX4XeTCc6Evpc6XaNLPSUrBLy88FDeRvl0u+dDz7IbjliqhIWoteGe3IuLWaZ9eq/B2z bI1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=B1rBdtoagUmcufp2b7ITzSwBiWi6KNIbRPB1h9WFswQ=; fh=M9qXMmjW4V5+dTtAmZ8W+48oRvQno9U/fljVEY8EFrE=; b=jRQ+92NECc1jLgU5tK1KtKKG2YtkFfy8436RzzmZ1hkvce/gcKwqU9JlsS37XwE5H/ /oIcO4k+y7H4ayiADd74d2eCHIleUrbi2jKEoV+pN9faks3QnGlSaQxAzp7T7PYXmZdv qb3GOjWxz6t0oPQ+FboS5DAUkvseD1kk/YzMccd31AGoAc1Q3QHGX8r2R4cu8+AOoRyr xXkuxd3mvPdobwd2H+S39LkPuwPgkLMy3VoUvPE8hkPye7+fso05OM7q/y0J7J222SsC I/wcNSkJSuWkmdJI2QkfYSOLI1gR7B9r6PCXQeuJC1ntqnp6sRtBEV0oXLkXLyPBc6ox F1fw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id u14-20020a056a00158e00b0069026254582si8313404pfk.98.2023.12.05.01.35.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 01:35:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id A407E807749B; Tue, 5 Dec 2023 01:35:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344889AbjLEJfV (ORCPT + 99 others); Tue, 5 Dec 2023 04:35:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235042AbjLEJfH (ORCPT ); Tue, 5 Dec 2023 04:35:07 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AD52B186; Tue, 5 Dec 2023 01:35:12 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 139CEC15; Tue, 5 Dec 2023 01:35:59 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CB5E33F6C4; Tue, 5 Dec 2023 01:35:10 -0800 (PST) Date: Tue, 5 Dec 2023 09:35:08 +0000 From: Sudeep Holla To: Anshuman Khandual Cc: James Clark , linux-arm-kernel@lists.infradead.org, Sudeep Holla , suzuki.poulose@arm.com, Lorenzo Pieralisi , Mike Leach , Maxime Coquelin , Alexandre Torgue , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH V2 6/7] coresight: stm: Move ACPI support from AMBA driver to platform driver Message-ID: References: <20231201062053.1268492-1-anshuman.khandual@arm.com> <20231201062053.1268492-7-anshuman.khandual@arm.com> <0adc3a16-0fc4-2a25-cd48-4667881b9490@arm.com> <7825dcd4-94e1-7a5f-b388-90e748dfc47f@arm.com> <81cad3a6-a080-424c-ad0b-0f08c4fe51a2@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81cad3a6-a080-424c-ad0b-0f08c4fe51a2@arm.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 05 Dec 2023 01:35:51 -0800 (PST) On Tue, Dec 05, 2023 at 10:50:19AM +0530, Anshuman Khandual wrote: > Something like this works ? > > diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c > index 3387ebc9d8ab..2b6834c4cac6 100644 > --- a/drivers/hwtracing/coresight/coresight-stm.c > +++ b/drivers/hwtracing/coresight/coresight-stm.c > @@ -906,7 +906,7 @@ static int __stm_probe(struct device *dev, struct resource *res, void *dev_caps) > pm_runtime_put(dev); > > dev_info(&drvdata->csdev->dev, "%s initialized\n", > - (char *)dev_caps); > + dev_caps ? (char *)dev_caps: "STM"); > return 0; > > cs_unregister: Yes, looks good to me. -- Regards, Sudeep