Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <c0542b0e-4b36-7774-ec6f-7c54a3ec2b2b@suse.cz>
Date:   Tue, 5 Dec 2023 10:39:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v5 9/9] slub: Update frozen slabs documentations in the
 source
Content-Language: en-US
To:     Chengming Zhou <chengming.zhou@linux.dev>,
        "Christoph Lameter (Ampere)" <cl@linux.com>
Cc:     penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
        akpm@linux-foundation.org, roman.gushchin@linux.dev,
        42.hyeyoo@gmail.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Chengming Zhou <zhouchengming@bytedance.com>
References: <20231102032330.1036151-1-chengming.zhou@linux.dev>
 <20231102032330.1036151-10-chengming.zhou@linux.dev>
 <dd73fdd6-b093-b32a-85a3-25cd22c21652@linux.com>
 <29bd5cc7-e8e6-4a4d-b526-651c7885a185@linux.dev>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <29bd5cc7-e8e6-4a4d-b526-651c7885a185@linux.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/5/23 07:06, Chengming Zhou wrote:
> On 2023/12/5 05:41, Christoph Lameter (Ampere) wrote:
>> On Thu, 2 Nov 2023, chengming.zhou@linux.dev wrote:
>> 
>>> From: Chengming Zhou <zhouchengming@bytedance.com>
>>>
>>> The current updated scheme (which this series implemented) is:
>>> - node partial slabs: PG_Workingset && !frozen
>>> - cpu partial slabs: !PG_Workingset && !frozen
>>> - cpu slabs: !PG_Workingset && frozen
>>> - full slabs: !PG_Workingset && !frozen
>> 
>> The above would be good to include in the comments.
>> 
>> Acked-by: Christoph Lameter (Ampere) <cl@linux.com>
>> 
> 
> Thanks for your review and suggestion!
> 
> Maybe something like this:

Thanks, added.

> diff --git a/mm/slub.c b/mm/slub.c
> index 623c17a4cdd6..21f88bd9c16b 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -93,6 +93,12 @@
>   *   by clearing the PG_workingset flag when moving out of the node
>   *   partial list. Please see __slab_free() for more details.
>   *
> + *   To sum up, the current scheme is:
> + *   - node partial slab: PG_Workingset && !frozen
> + *   - cpu partial slab: !PG_Workingset && !frozen
> + *   - cpu slab: !PG_Workingset && frozen
> + *   - full slab: !PG_Workingset && !frozen
> + *
>   *   list_lock
>   *
>   *   The list_lock protects the partial and full list on each node and