Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
MIME-Version: 1.0
References: <20231128140718.3866978-1-naresh.solanki@9elements.com> <e0953578-1c61-4461-af07-8cf1e3d1837e@sirena.org.uk>
In-Reply-To: <e0953578-1c61-4461-af07-8cf1e3d1837e@sirena.org.uk>
From:   Naresh Solanki <naresh.solanki@9elements.com>
Date:   Tue, 5 Dec 2023 16:26:55 +0530
Message-ID: <CABqG17j8bA1edpr8nzceqis=XjctmhCh+M9qWFXr-H59QK0emg@mail.gmail.com>
Subject: Re: [PATCH v3] regulator: event: Add regulator netlink event support
To:     Mark Brown <broonie@kernel.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi

On Tue, 5 Dec 2023 at 04:54, Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Nov 28, 2023 at 02:07:16PM +0000, Naresh Solanki wrote:
> > This commit introduces netlink event support to the regulator subsystem.
> >
> > Changes:
> > - Introduce event.c and regnl.h for netlink event handling.
> > - Implement reg_generate_netlink_event to broadcast regulator events.
> > - Update Makefile to include the new event.c file.
>
> This looks good however it breaks an allmodconfig build:
>
>    ERROR: modpost: missing MODULE_LICENSE() in drivers/regulator/event.o
>
> > +config REGULATOR_NETLINK_EVENTS
> > +     tristate "Enable support for receiving regulator events via netlink"
> > +     depends on NET
>
> I think this needs to be a bool (NET is a bool so there's no dependency
> issues there hopefully).
Thanks for pointing this out. I missed testing build with allmodconfig.
As suggested, after updating Kconfig from tristate to bool this
issue got resolved.

Will push v4  with the fix.

Regards,
Naresh

>
> Thanks for pushing this forwards.