Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp195995rdb; Tue, 5 Dec 2023 02:57:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqrn4N7BqCSPHX4RTSIkdtBYEqKR/1iPZS8XVk1IpOTmwzlRh6pOcP4olw28R7o/hZgNt/ X-Received: by 2002:a17:902:d2cf:b0:1d0:c460:6ab0 with SMTP id n15-20020a170902d2cf00b001d0c4606ab0mr806285plc.49.1701773855078; Tue, 05 Dec 2023 02:57:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701773855; cv=none; d=google.com; s=arc-20160816; b=bK4SvSVIgUlh6elGBUIVsjyBR4Qy8xyAcRYCQi6ye9yB2i+qF/j2LZt6ffiWpS09pc HWQwyzNCWWDhHCzayttQ249SrKoxQQC5G7jpI4XHepEdtCkyTM3KQG0TO0uaF6Gmb2Tc Qi6w45r9ZDRSkqibd8oOFWMQ9yvjIhYjB8Z716N3L4+adx04TXGBWl9I/x5Smucub4Xd eXNy5AZXCHaLG0UJHYOSAHcjj/KP8eRfgieL4caQJrYkHjvunK6fTeFvLzZtlo7k09tF 93XcHaBsxEr/xeXZY+8ym3vcbXL4Al2jqxfwUBXEFHsziN1W4BtAjl5uwUpKCXWcmSGt cUng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Y8KWCPPPQ8CIJ/u3TjtBY0k0gyPDsYVmVto621+YS0w=; fh=4bl8T5jQJK5ZTI5yRDcZitH2G7yaCwue9V5ocE+43sc=; b=tUvx4yNdeFG0PKKLG3biPhC7RdNLHDb8pbnlGZJWkSnLTwLRltMM5qgFtQRnWo1Zur YCAwU41qLDAhxsJSka27N1npPov2a5rrGmktgVnEkizEDKxEuXZ8wZUevlUstH6NQs4y U9ul9J/WovaDNZy7RTHRFGh1DOqmiu0yRARMP2xsEK+Gx7GZLbFhyIcvvS5h+oVzXjHx lceEvtBZ2rNUorzwXeWnYhbYX7KwZkJYgPgC1zG56vf7BH+5v1lBZoj+eUk1cjX8CId8 umxPoo730i+arF6ScrS0F30KBf/HRf8ek5UQEFCtUwdHGo9HbbTPgQiVLUlWAtzTngit qjqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="kZqSyY/Z"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id n5-20020a170902e54500b001cfc9894958si9843544plf.379.2023.12.05.02.57.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 02:57:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="kZqSyY/Z"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 6890D80A4998; Tue, 5 Dec 2023 02:57:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346789AbjLEK5R (ORCPT + 99 others); Tue, 5 Dec 2023 05:57:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345153AbjLEK5Q (ORCPT ); Tue, 5 Dec 2023 05:57:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF6BF184 for ; Tue, 5 Dec 2023 02:57:22 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DB70C433CA; Tue, 5 Dec 2023 10:57:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701773842; bh=YqpV12wF1wW4FbDYUwIQqQF3MI0jix0N68VmlJ6caHI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kZqSyY/Zse2ysr5oLlPSkX8cWt1V6ESwJEwFozwLMgK7KYO+Ef+LTcxwyM4btJfk6 p8qXXtVOlnTUpaZ1SXPO4TLbPFQva0SasThKzoeM5CKKaYFY2UXJyz0MzjGv85tTFK mhaHFs2kTBF6Z0KU/8q5Vr47Czer9PNVv+Uvs1OslaMxtDda0O8Sz74D/ncikxako1 z2zDCeXHcaENcFwJ2zwDOV7DRJz1X1eu3xtXFjVC0cKzx+QJNp8X9oGK6KFvgQAUQE aGBl/r6tDZgBbHUuUPieNZKjo7JGVUdbSplvOPcdtKThH9RRQHeNPwSy49kWI8lwiH RpBQXVLZAW8bQ== Date: Tue, 5 Dec 2023 11:57:18 +0100 From: Christian Brauner To: Jens Axboe Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk Subject: Re: [PATCHSET 0/2] Get rid of import_single_range() Message-ID: <20231205-kaminholz-halstuch-280db992267b@brauner> References: <20231204174827.1258875-1-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231204174827.1258875-1-axboe@kernel.dk> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 05 Dec 2023 02:57:32 -0800 (PST) On Mon, Dec 04, 2023 at 10:47:48AM -0700, Jens Axboe wrote: > Hi, > > While looking at this today, I noticed that the 'iov' argument to this > function is totally dead code. Patch 1 gets rid of it, and with this > function and import_ubuf() now being identical, converts the callers > to just use import_ubuf(). > > No functional changes here, just a cleanup removing some dead code. Looks good. I've picked this up into vfs.iov_iter but let me know if you're already carrying this. Christian