Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp201557rdb; Tue, 5 Dec 2023 03:06:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFOYQUp1rKXF7s/SyD4oLmAes+JfVUtvln4ZzTfyqSIOWLzJHu0Sc9cnyhtil7HgtFl7TOs X-Received: by 2002:a17:90a:a016:b0:286:6cc1:7815 with SMTP id q22-20020a17090aa01600b002866cc17815mr937785pjp.88.1701774408290; Tue, 05 Dec 2023 03:06:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701774408; cv=none; d=google.com; s=arc-20160816; b=j1oT9LnB+YiRoe1sgncag3ozjXla/RbB3/jXzun4ci65YsBR+Brddv4bTbp1wSQ+ER 4gG8qPxz5U6IMhm5jV3If2/7LuSDg6sh8Weg+XEBu5v7pepj8bMP0yFOK9I14vU44EaW Cd+AFU/WDWoNGHTLwa7NUlxeVVNHZjS1i1P5LqeoQPHF5p4uj9o6BjCa0CiAqvQPXHwi t1G7vMJTACwY5zpnt2FkAZ8H80e9IxBD9a4xd0f52p/F6gWZS3xpgkBYXZkzztx8D0Kv vGPikAuXh/ew2mTu8NiraRKholGypND9tyXlDdvxNOgdydgGCdSjngphArg86dLbJXr9 R3OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sNadDqmgC07C6MbGcwYHSmZvb2deukFjUIJm4ltFbEk=; fh=Tp498Wr8LiY2J3rZTkkq6d58L6YBbfFG3e4m98qgWaA=; b=r9qEaatb/voSBnGZhi1AHTR/Gon27FPFpnFhYX7xH4IuKq8y7nAJcpoYYfJDIX4ulD sFQX7EDe2FlA6aPscXfTKi0fQ3BhclKjFZVBOcgouvSKrqJQBguYCUxBye2gQ4mOH+np QT9hu8Zq3rvhnVhaXGz8XHYX47zWtJKlOuLKX2nYi2sU0vKd1qN+R7IpY5O5GZx1d5To aFilh0LYM3oV58g1DDiNBl4QFuOhpLCqgJe1AikMrRXp6/z6MYqM/gawBryWyM8JhqhN qATgA75HtTvDI82jmGCMRfiy08USGuvyNKhM3/aXGD5cTo4l7GROA+sQ1FemxQBstmeQ l7yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YinYHhv+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id f3-20020a17090a700300b0028665a20c0asi5934848pjk.4.2023.12.05.03.06.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 03:06:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YinYHhv+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 9A1DF8080D78; Tue, 5 Dec 2023 03:06:45 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376608AbjLELGb (ORCPT + 99 others); Tue, 5 Dec 2023 06:06:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345153AbjLELGa (ORCPT ); Tue, 5 Dec 2023 06:06:30 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 648E3122 for ; Tue, 5 Dec 2023 03:06:37 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B16B5C433C7; Tue, 5 Dec 2023 11:06:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701774397; bh=rgJUwJ6GqxS/UtDw9jRVOllmpQab2HhQKk5CRvGD4NA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YinYHhv+6oqy4AS4LYHcW4XAfudoECQpbKl8DmASdgq7tjk5FAu1qSLGG7EPgC8yg +HghCWl5DtDIrJJSKwUxlMtc5+WbeHNQDIy8IB1ZdP2qt+0+m3/I/4gdKkpL2cMoh7 XbNlAAUv7/AiKeT+8XCRUo0taWr6T7dLzcpH/151gKrKFClEz3MZt93xsBbTkKxNNz ofUqL+FbylkjHC2s15WxU3ojQ5tHSjhPyEW5QfIV6jHlkYU9erT66RZ0GzJeTGaFBq Qbt7pvb7vzdUMdQxE2nmyokY6HQtvEjiJA0hpzSEwD1uhAyzQCrFVGw2H1Pb75znqO VPgRxmUdYHeVA== Date: Tue, 5 Dec 2023 12:06:33 +0100 From: Christian Brauner To: Hao Ge Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, gehao618@163.com Subject: Re: [PATCH] fs/namei: Don't update atime when some errors occur in get_link Message-ID: <20231205-endstadium-teich-d8d0bc900e08@brauner> References: <20231205071733.334474-1-gehao@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231205071733.334474-1-gehao@kylinos.cn> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 05 Dec 2023 03:06:45 -0800 (PST) On Tue, Dec 05, 2023 at 03:17:33PM +0800, Hao Ge wrote: > Perhaps we have some errors occur(like security),then we don't update > atime,because we didn't actually access it > > Signed-off-by: Hao Ge > --- We didn't follow the link but we accessed it. I guess it's not completey clear what's correct here so I'd just leave it as is.