Date: Mon, 3 Dec 2007 11:17:02 +0100
From: Ingo Molnar <mingo@elte.hu>
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
       Arjan van de Ven <arjan@infradead.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: sched_yield: delete sysctl_sched_compat_yield
Message-ID: <20071203101702.GB30050@elte.hu>
References: <1196155985.25646.31.camel@ymzhang> <200711301429.15664.nickpiggin@yahoo.com.au> <20071130100845.GB2201@elte.hu> <200712031527.57129.nickpiggin@yahoo.com.au> <20071203084557.GA13156@elte.hu> <1196674869.25646.142.camel@ymzhang>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1196674869.25646.142.camel@ymzhang>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1837
Lines: 40


* Zhang, Yanmin <yanmin_zhang@linux.intel.com> wrote:

> > as far as desktop apps such as firefox goes, the exact opposite is 
> > true. We had two choices basically: either a "more agressive" yield 
> > than before or a "less agressive" yield. Desktop apps were reported 
> > to hurt from a "more agressive" yield (firefox for example gets some 
> > pretty bad delays),
>
> Why not to change source codes of firefox? [...]

because we care a heck of a lot more about a widely used open-source 
package's default "user experience" than we care about closed-source 
volanomark scores...

do you realize the absurdity of that suggestion: in essence we'd punish 
firefox _because it is open-source and can be changed_. So basically 
firefox would get a more preferential treatment if it was closed-source 
and could not be changed? That's totally backwards.

> If the sched_compat_yield=0, the sys_sched_yield almost does nothing 
> but returns, so firefox could just do not call sched_yield. I assume 
> 'sched_compat_yield=0' ~ no_call_to_sched_yield.
> 
> It's easier to delete calls to sched_yield in applications than to 
> tune calls to sched_yield.

We are not at all worried about punishing silly benchmark behavior - and 
volanomark's call to Thread.yield (if that's indeed what is happening - 
could you try to trace it to make sure?) is outright silly. There are 
other chatroom benchmarks such as hackbench.c and hackbench_pth.c that i 
test frequently, and they are not affected by any yield details. (and 
even then it's still taken with a grain of salt - remember dbench)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/