Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Inochi Amaoto <inochiama@outlook.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>
Cc:     Inochi Amaoto <inochiama@outlook.com>,
        Chen Wang <unicorn_wang@outlook.com>,
        Jisheng Zhang <jszhang@kernel.org>, qiujingbao.dlmu@gmail.com,
        dlan@gentoo.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: clock: sophgo: Add CV1800 bindings
Date:   Tue,  5 Dec 2023 19:24:53 +0800
Message-ID: <IA1PR20MB4953F0086FB77F8DC46C8095BB85A@IA1PR20MB4953.namprd20.prod.outlook.com>
In-Reply-To: <05d17d6d-490e-4524-ab1c-4ccc27b0d7bc@linaro.org>
References: <05d17d6d-490e-4524-ab1c-4ccc27b0d7bc@linaro.org>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: IA1PR20MB4953:EE_|PH7PR20MB4988:EE_
X-MS-Office365-Filtering-Correlation-Id: e356a8ae-ede3-4f8e-1766-08dbf584d0de
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: pifHK5vUgIgNqhRQSXgPI/OhIXpO+OUCP2SnIsBW6ZiMfndjZlU8apwJnmRW5Q+FNWV967AkEFfnXLrGMEr57wL/jCuR8KKxMPSKCoxpu4ACo7s+xCZ65sRaLtB1x9IuXR894IGS6ydXqPdwUP6LmbJHD2L2HSn/AuoYzhDE/F8sgcOjwexAhaFfwFT7WqQ06Hk4Bk0e/Q0yIzuOAvqVjor04wlOP2iI7RUDIKyncDR2CMrmC73+6w92jqfk0xggqVGu3PmW5XAZQ5gtdpLqZJvLL6qAJoSzQZR/Q3Z3AYU3V5L+gb0czNwTSPR67gb8+lgorPbcN4WI1QNoMALYMg6ZkxvTGWrJiGWIzehgMWfFhLdunPVqT3ZX5JA3Xvgj4C3NuZBg7/KaoVcpQ4W/dBI/0H9wyQC29LlOsixmwS5G1ek05sdaskGGrH4kgvxZjTyc5/6Agvd+5oqIC1xsCyRJiyYE0loH6KdqtslS8w9BtHz3RP1GyDBo18ytJPrJfkkz5iiHdW+23dV4Kr/tEVcqpn4BLam+VygKsajY3h/ve1j4trL9eUhZssgQJqmTT+mdPbfURTtuWplPnav1iAAuoVJevoKMZyhgCZ5xzyHv60zugh9UKXatpMeJ31Vs
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BLaKgaJRZp9yCattlFpm9X7vTWBYY4m4eHdw8fzisC7lPGlSrellaMQg5n7H?=
 =?us-ascii?Q?r7MfbRNdQpIKfbYNy2Pl3hr96hdv2kkJHVXtFBpt/ZY9bpunssJsLE21fNms?=
 =?us-ascii?Q?6EXHL6EcXylNprGg3JqidJhQk/5RDiaOcGyBJEhMkibYjF/IOLj0ZaNBMzAV?=
 =?us-ascii?Q?HFiKCNLaRzY8Boz7n/WCfwtJWe9k2LqBb8LzvRQRSEpnxjI5zY7gxLpEhAaf?=
 =?us-ascii?Q?6fdcrgpNhWNzxFbJ6teEsF9fZUKgZsVIX7RLwDdPR9V58OfsuHRJKt8cBKFm?=
 =?us-ascii?Q?bW9jelNz1dcIN0ldMIKaVW5s6B9tq79xsTQEtHga6EZmhIAoQ1Sq2JEoqsFo?=
 =?us-ascii?Q?V0eT4vjg+ACq/EdS/1iu3viNBnamMRhLvvHRMhbxSzoRZgq1xahv5H2scYka?=
 =?us-ascii?Q?qXA/4AkraoqlxdPJuJ8SYLvgsLm169OuhxbEmldN7CKNKmrDt1DtyaKfGaRv?=
 =?us-ascii?Q?D3lvXNwLWYQassroo8gHeWx0UZNwyLfY0xJMeQNMvQOGfgYYYCvQGv+ik2Bn?=
 =?us-ascii?Q?F0m+JFfEsX1ogQfpU+/vB3X/o3IsVLXPB/BeHdD4vxb0X2tdsNiSj1jQkF1P?=
 =?us-ascii?Q?SRsY38++Rw6NHiAu7egiIcBjo4o8iNSuDe4mfcQ4u3bn4/79F4dS8DTsyCP0?=
 =?us-ascii?Q?1g/AFu1VcHLkLnxNRB+WeKFqtT5yM+FPXV3kSXxG0A/J1x+yObOzvCjJVaHg?=
 =?us-ascii?Q?zbYLtAmBjfH5dyhX1pzL0YaNroAbUh6Y6N9B6pgjT8ycbMddV8ZHJJpXoiVX?=
 =?us-ascii?Q?RhRsiiMSXwHtFGnmn8niEruNKl2rR6gcnEi5w9/jpFMI4n/Hnc4g4q2z1wof?=
 =?us-ascii?Q?ErwuN3uQCn4V7boPmcaUOxdL4Kt4MAOESyEGLDtTtneYo5Z/K5rCCpBL0dip?=
 =?us-ascii?Q?qlA6ShdDLvtyVcsljJBbEp3ALLBawJM/fiZS80oX2ukvwwADbaV8LF7rIgli?=
 =?us-ascii?Q?m8rW5kB/E36hfeTWinaeHjNaSTdeq1qQt5a5Skzbv0gSR56wdxc6hg0Kk6kN?=
 =?us-ascii?Q?5zLfGdOzzLmkm+TB+DgEKr2ZhNNUMwBPM4OtW//sj45S6iFSPQ9YcBJ/uXJP?=
 =?us-ascii?Q?h2BTixf3OxuPMTIxJZqrfvOuX7GOnC6oWKD0g6RYFTun4+C8n5a4A8y+fb4C?=
 =?us-ascii?Q?ZRRItoPExGcrksB80rfA7SuAsRG8TagTNapo1BqjDNIHankL2kToDYBaYtmm?=
 =?us-ascii?Q?NO5/l4XjNYZ3nkLMdJeu1zf4D2hjsuG1IlQK6ECXldun8Ad5oVdih9Bmtzo?=
 =?us-ascii?Q?=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e356a8ae-ede3-4f8e-1766-08dbf584d0de
X-MS-Exchange-CrossTenant-AuthSource: IA1PR20MB4953.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2023 11:24:59.4040
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR20MB4988
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 05 Dec 2023 03:28:04 -0800 (PST)

>
>On 05/12/2023 10:43, Inochi Amaoto wrote:
>> Add definition for the clock controller of the CV1800 series SoC.
>>
>
>If there is going to be resend:
>
>A nit, subject: drop second/last, redundant "bindings". The
>"dt-bindings" prefix is already stating that these are bindings.
>

OK, thanks.

>> Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
>> Link: https://github.com/milkv-duo/duo-files/blob/main/hardware/CV1800B/CV1800B-CV1801B-Preliminary-Datasheet-full-en.pdf
>> ---
>
>
>> diff --git a/include/dt-bindings/clock/sophgo,cv1800.h b/include/dt-bindings/clock/sophgo,cv1800.h
>> new file mode 100644
>> index 000000000000..6a9897b34978
>> --- /dev/null
>> +++ b/include/dt-bindings/clock/sophgo,cv1800.h
>> @@ -0,0 +1,174 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>
>Why not dual-license? Checkpatch complains about this, so are you sure
>you run it?
>

Yes, I have run it. It seems I misunderstood the warning message.
It only tells me it should be (GPL-2.0-only OR .*). And I think
GPL-2.0 is ok. Thanks for your explanation, I will fix this soon.

>
>Best regards,
>Krzysztof
>
>