Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp212699rdb; Tue, 5 Dec 2023 03:29:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IF94SQsowFoGhE8SiFpOtmiGnuzNz9vYYiXZKRmFzequQB/UKH4yGzcJsmaJ5fYPpXQ/Yna X-Received: by 2002:a17:903:2303:b0:1d0:6ffd:e2c5 with SMTP id d3-20020a170903230300b001d06ffde2c5mr6702918plh.95.1701775740459; Tue, 05 Dec 2023 03:29:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701775740; cv=none; d=google.com; s=arc-20160816; b=RN2/1ikcHUT9jGdf+JuckjneY8/FVQoOhkaI0WyDg9EkzHtmWKAiCkKrYXgbs4Nd/Q Sfhohfr3aD0wTmZr5vD8DxhxB6asAO0Bi2iPsEiYjpd+IzTVvVFdLGN7DoA39NzIIA6o JMlgpPjYQHfCxSxQyZoRiDv/HYK684iv8r0PAQ9/cpfl+EwuNYhtiXIrxZh036Kb3gFt Wq8m334DzKglzV+/zyKWcUSkqcLHSW27HQr7R6e1Y0XzuglIEhtd50ys1q0JdnHpyGvF IWXF/5bN6whPo5NpzaTEnJLaE0sflt+gQKjKofBZtvK3gO6MpE25gY+0w5fMjrOJjvX9 /vIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/v7mvN9deEkGkoO3uLhdgRvmngCCOUew4NWi2nI998Y=; fh=uN3ocIkZZpR4w8rHU+bEt9agKQQkMOlALS3h0ovprww=; b=KqL4j28ncl6DbIaPqXzJmB7LhUPzpQiQyDqhikqST9yNToQ8rumoSK5RQQX7R6F8dm +Q5pzg1PrEUDVsf6Fo1VyvgMWowyY+AT7Fltsb5OQmuOgmEK5Ywtvof4nBDg4yTsvWfw gD9YvCcZW+nvMfYq3QzoSY6LzWX/+jantl8ynmcxIF1JGn6bCEqtBRbfwmAYHJTfd8RL utPjAHE/QKETTHR3+SeAj+RVIExh0LJbh4XwDoOUd/J1/pjSXx2v0rP/YupZr6xs1Lph Kd49xY6FbpleK0DzP1prfSVWPpPQ9hEUcSH+GquxE92E/Uu9pHmomjrdU9kK6H+bsBKs ikaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=fQu4q2yL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id t2-20020a170902e84200b001d0af6323f6si2813883plg.409.2023.12.05.03.29.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 03:29:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=fQu4q2yL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id CAB80803C94B; Tue, 5 Dec 2023 03:28:57 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346895AbjLEL2p (ORCPT + 99 others); Tue, 5 Dec 2023 06:28:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346966AbjLEL22 (ORCPT ); Tue, 5 Dec 2023 06:28:28 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F8572134; Tue, 5 Dec 2023 03:28:00 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-50bf7bc38c0so2455868e87.2; Tue, 05 Dec 2023 03:28:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701775678; x=1702380478; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/v7mvN9deEkGkoO3uLhdgRvmngCCOUew4NWi2nI998Y=; b=fQu4q2yL3XukflwhZ5VcRL/lOS5sePv6kFbOW4t4FdNWwqe1aRT5DH458J10CshIAE pwFZvaBtm9ev2MbS7q9LKQeHtVy8BsYnsS9Cb6DmYtHqaiZZ/u/+9QXA/Zbb7Ja7JbFh 3mgXwMZ5NAC2/O3dPIxX+9v0Fi4cuExcqSg44JMEMuosArNuoOOPJX6dDUpEW0ry0SYO nvquXwBDM5F/oQmyd9HmuSoZW5M5HVzX4u6ZdP/fQim2hIOGqY2ZlnRkreEogXsVgvdj XUjV7QlvPHR78USWexP89poyD4AVagFwhaA24N1V7+v0ARrC9oEIUemVEH5SrYe+ny8R +tNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701775678; x=1702380478; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/v7mvN9deEkGkoO3uLhdgRvmngCCOUew4NWi2nI998Y=; b=snFGANytkuAgvq8Pls+Z9PzAABwljRSN0y9evuBmr1QD/xFzm7czpQGv0o7D8fL1e+ ULNagKtBufeaIq4/orqkSEEcO651Aat0ZhBkl2JxIzLx1P/lU3W+GfuwqOcASC7O0l5m ehzmtK5xrDuo+8uw26QyFh35Qi0eXvRrYTn4aXj8vGLbYGPkTn6v/c2rj/H7ptc6zt8X PpnrVWWkTGhQ9mS4OT1w+B2DiFJJue6P8hdnLbRtvkc807nhplBNNExWU/OhWdz/QaIG YWLit7XvQN6zvZXbfMg40GZnhy9QN6hPSOOcueaDxxL9pBPowEvIkyPlcrMQF33JYj3t qU+g== X-Gm-Message-State: AOJu0YxIst/HGgHDT5WhGbg7We2T92tMOnhfYeG/+hBvfTtcFRgYyHXa VLrRVyI+lDwjPpQV+NbeLv4= X-Received: by 2002:a05:6512:239e:b0:50b:c30b:813a with SMTP id c30-20020a056512239e00b0050bc30b813amr4383751lfv.53.1701775678111; Tue, 05 Dec 2023 03:27:58 -0800 (PST) Received: from skbuf ([188.27.185.68]) by smtp.gmail.com with ESMTPSA id cf6-20020a170906b2c600b00a1937153bddsm5951892ejb.20.2023.12.05.03.27.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 03:27:57 -0800 (PST) Date: Tue, 5 Dec 2023 13:27:55 +0200 From: Vladimir Oltean To: Serge Semin Cc: Andrew Lunn , Heiner Kallweit , Russell King , Alexandre Torgue , Jose Abreu , Jose Abreu , Maxime Chevallier , Tomer Maimon , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , openbmc@lists.ozlabs.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 05/16] net: pcs: xpcs: Move native device ID macro to linux/pcs/pcs-xpcs.h Message-ID: <20231205112755.3am2mazwireflpkq@skbuf> References: <20231205103559.9605-1-fancer.lancer@gmail.com> <20231205103559.9605-1-fancer.lancer@gmail.com> <20231205103559.9605-6-fancer.lancer@gmail.com> <20231205103559.9605-6-fancer.lancer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231205103559.9605-6-fancer.lancer@gmail.com> <20231205103559.9605-6-fancer.lancer@gmail.com> X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 05 Dec 2023 03:28:58 -0800 (PST) On Tue, Dec 05, 2023 at 01:35:26PM +0300, Serge Semin wrote: > In addition to that having all supported DW XPCS device IDs defined in > a sinle place will improve the code maintainability and readability. single