Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Tue, 5 Dec 2023 12:30:50 +0100
From:   Stephan Gerhold <stephan@gerhold.net>
To:     Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc:     Raymond Hackley <raymondhackley@protonmail.com>,
        linux-kernel@vger.kernel.org, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Jakob Hauser <jahau@rocketmail.com>,
        Nikita Travkin <nikita@trvn.ru>, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH] arm64: dts: qcom: msm8916/39-samsung-a2015: Add PMIC and
 charger
Message-ID: <ZW8J6vYKg82Q4JFV@gerhold.net>
References: <20231205093841.24325-1-raymondhackley@protonmail.com>
 <1c62dd8b-72b2-4204-8284-a1dd90d4f909@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1c62dd8b-72b2-4204-8284-a1dd90d4f909@linaro.org>
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, Dec 05, 2023 at 12:17:15PM +0100, Bryan O'Donoghue wrote:
> On 05/12/2023 10:38, Raymond Hackley wrote:
> > The phones listed below have Richtek RT5033 PMIC and charger.
> > Add them to the device trees.
> > 
> > - Samsung Galaxy A3/A5/A7 2015
> > - Samsung Galaxy E5/E7
> > - Samsung Galaxy Grand Max
> > 
> > Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> > [...]
> > +			/*
> > +			 * Needed for camera, but not used yet.
> > +			 * Define empty nodes to allow disabling the unused
> > +			 * regulators.
> > +			 */
> > +			LDO {};
> > +			BUCK {};
> > +		};
> 
> Aren't the camera regulators off until enabled ?
> 

We don't know for sure what state they are in during boot. If we omit
these nodes the regulator core will ignore these regulators completely
and just leave them in whatever state they are.

I would indeed expect them to be off after reset, but there are also
other situations in which Linux might be booted, such as kexec. That's
why it's usually better to be explicit and avoid relying on boot/reset
states altogether.

Thanks,
Stephan