Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <43df8dd9-bcf9-4c69-9e26-5dfdf5c27e81@intel.com>
Date:   Tue, 5 Dec 2023 12:44:27 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V3 net 2/2] net: hns: fix fake link up on xge port
To:     Jijie Shao <shaojijie@huawei.com>, <yisen.zhuang@huawei.com>,
        <salil.mehta@huawei.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
CC:     <shenjian15@huawei.com>, <wangjie125@huawei.com>,
        <liuyonglong@huawei.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20231204143232.3221542-1-shaojijie@huawei.com>
 <20231204143232.3221542-3-shaojijie@huawei.com>
Content-Language: en-US
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20231204143232.3221542-3-shaojijie@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFlKYWh0TFE2RWVZcUdmQjU1QWVLVnYxSmhTWExjMEhvd3FtTEFYWlR2TmJh?=
 =?utf-8?B?eVVmT1JYSkV0dzNhK1lHTUQwRXp4MTRmWTc2cGRPMmp4eER0WGNmSHJWV3E1?=
 =?utf-8?B?QnFrelVvaFFRSFVZYUx6WDFGWW9tc3pGQzh4S3dRMkxUejc5elBaSlhJU2NG?=
 =?utf-8?B?VnBrODdnUDltVjl5bzdhMTl4TjRuQUJWb21DVkNETFZQVlAzQlZMeThPUXFm?=
 =?utf-8?B?R01VZjRnTjNkRW9ZZVJpalpzTlJMRmlNc1JHWDFhREdJSzlRM2JqN0dRTmUw?=
 =?utf-8?B?NW1sSjZWVTA4S0JlUkZjOXN2S1lqc2VPMEE0NlBXZm9KS0xQRDZTN0tYbFdk?=
 =?utf-8?B?cUp5aXVYK0VXUVk3ZTl0cGJubjQ5SFhhQTVUZ3FBQ1hZc0p6VFNzd2poa1pT?=
 =?utf-8?B?dGQyRmxPdXJDWlpEV0VTdkVvVUhXbWxCQjVrQXk4T0J3Q042M0V3OHA5WFI1?=
 =?utf-8?B?ZVJldXQ1bGlxc1JqOGZNTzc1cEVPakZkK1hmS3pwRzA3SWUydVMvS2FzanN0?=
 =?utf-8?B?MVR0UG5NeVpSSU5lYVN0S0NQQTRTdXcvVjk3K3hNWFoyY092d1ZWRjhuYTBF?=
 =?utf-8?B?YnJJUEdjeDBocWJEcUh2dG9HRGZHZ3dHVkhLNFlnYnlTTG1xejAvMzYvVHVy?=
 =?utf-8?B?YU5YVytRMkFYbVpWaVRzZlFTQjRUMVpOTTBWQ1Q2ZkNINnE3S2IvYmpBNnZQ?=
 =?utf-8?B?eFRIam82WngySzNvZ0ZSd1JqdEVrajB2S2JNRkpleTJMVjJ0VzVNbTI0cGtU?=
 =?utf-8?B?a2NRRVFSc1kxNlNOdk9UTzZ2S1NCZEs5U1hMMWlHTFJvT2NCTUp6emlweC9E?=
 =?utf-8?B?b1pocGhCaVV0MXNHTkY5NDI5NjhFWFoyZFlOclcySFpOZFZwRG9JN0pJaXhU?=
 =?utf-8?B?ejA2VDcvdkJ6L2pLVmxJNG8rUjdZNE9uSTZDNDNRdkRaU3hNeVhuYzcrRUF0?=
 =?utf-8?B?SVRtakVjMDhIaWErK3QyRG9VT3BkQ1ZRWk93cXZrWUJraVZJaGZINHAyTnAz?=
 =?utf-8?B?OHM3ZjhFaFZLNXIwdDdiSldvVXVTVWhYMklMMEdTYlhCdjl6QzZrb2pNdFBJ?=
 =?utf-8?B?T2FiL21qbUhMRnNxR1FmdVJSbmFHMlZkdHYxdWJBYnl1UGNpajN4dXAzclhX?=
 =?utf-8?B?cHFSUWhTbi9SbWp3VGQ2ZWd1SzJFN1NYa0Ziam9UYlpuMjN3U0EzYk9TYnF2?=
 =?utf-8?B?SUE0QjdLUEJPV3hSYXdsVVdhelo1U3ZrVHlJRHZ1OFpCY1gyWkZ1SmNaWkFU?=
 =?utf-8?B?SUF2ZENObndXdnQyc29wZGU4ZkwrZGJacERvck4xQjRBOUIwc2JmOFVrQzR0?=
 =?utf-8?B?ZUMxYVZuQnBvT2szVGhzZGIzdDhBcnlpKzV6WkxNVmpObzZoWlYwOFk5cTBY?=
 =?utf-8?B?QTR0aW1pTkxQT0tmQlFuTllQU00xMDh6WWYxOG54RDlRUWZqMGQxU21rUzVl?=
 =?utf-8?B?L3F1eFQ2dkVMbDlzcENsV1UwWW80SFJmaTJTKzdzbXo5Y2xOWTZiRVZxMGxx?=
 =?utf-8?B?bkpNSTYweHhsdFh6TnlEOXRCUmZ3dW0yNlE2VWhHT1c3QzVpR0V0YjRzUS9k?=
 =?utf-8?B?UWtrYTBBQ3llNXNHWVM3UG1LakFFRmNMNk9MNXBjRzlJdCtOOFNadE9hMWVn?=
 =?utf-8?B?emV0VHhhcW96bE1kc0xWZWJIQU5BK2pkZjBocldVRW01Q0lwTVcrVkZtZFVj?=
 =?utf-8?B?d3BBUk83YUxoM3F2cnFWTGo3WDZ0RFo1VWNCK2gwakxZdTdlNEZycmd0NW94?=
 =?utf-8?B?cWIwWFc1b0pKOXBhNVFwb0FRdzNCSSs1ZmVvQ21wREUxcmNORERvcStJRUNI?=
 =?utf-8?B?Vld4S2pEWUFBSEk2TXRkMW41eUFPUU1ic0wyYWVZWml0anNhVXpZZmFoK1lG?=
 =?utf-8?B?cVNRZ3lBek83c0dYVisvV2VoMVJxMDNKNFNpZGxnVjlhck9mcU94MHhBT2hG?=
 =?utf-8?B?SHErdVFHTk4vWlZoTWVueGV1b0kwbDNwamZxd1VTU21xMUNIOGRpZkNsaHNs?=
 =?utf-8?B?MC9ndi9NcXRrR3B5K3pmNmMxbXlkVXRvODBnS3NKQkFweFdMdTJZbUpFZC9L?=
 =?utf-8?B?T1B0c2EwL2ZndzU0bnFXTFcyRHU0bjRUWnBjZ1VTTnVnNHVEcDM5SkFDVXJh?=
 =?utf-8?B?VGxNRVJuUG1EamF6Qm84TEh5bXk0RnBTdGhSUXNGMUd6VzVzTjl2VktMVmgw?=
 =?utf-8?B?TWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 76055fb7-011e-4fc4-e4f1-08dbf5878c81
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2023 11:44:33.2218
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qrq4IbmSBy/WCYH6wQnfx2/tx4iMrZR7utEyViJgsCZxg+FwVDGOf9pe1wZtAGMokIF3P5OmT0lc/mxaIWfyfn7mf2xb2g2SrR+jzgpioRc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4945
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 05 Dec 2023 03:44:49 -0800 (PST)


On 04.12.2023 15:32, Jijie Shao wrote:
> From: Yonglong Liu <liuyonglong@huawei.com>
> 
> If a xge port just connect with an optical module and no fiber,
> it may have a fake link up because there may be interference on
> the hardware. This patch adds an anti-shake to avoid the problem.
> And the time of anti-shake is base on tests.
> 
> Fixes: b917078c1c10 ("net: hns: Add ACPI support to check SFP present")
> Signed-off-by: Yonglong Liu <liuyonglong@huawei.com>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
> ---

Thanks!
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>  .../net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 29 +++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
> index 928d934cb21a..f75668c47935 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
> @@ -66,6 +66,27 @@ static enum mac_mode hns_get_enet_interface(const struct hns_mac_cb *mac_cb)
>  	}
>  }
>  
> +static u32 hns_mac_link_anti_shake(struct mac_driver *mac_ctrl_drv)
> +{
> +#define HNS_MAC_LINK_WAIT_TIME 5
> +#define HNS_MAC_LINK_WAIT_CNT 40
> +
> +	u32 link_status = 0;
> +	int i;
> +
> +	if (!mac_ctrl_drv->get_link_status)
> +		return link_status;
> +
> +	for (i = 0; i < HNS_MAC_LINK_WAIT_CNT; i++) {
> +		msleep(HNS_MAC_LINK_WAIT_TIME);
> +		mac_ctrl_drv->get_link_status(mac_ctrl_drv, &link_status);
> +		if (!link_status)
> +			break;
> +	}
> +
> +	return link_status;
> +}
> +
>  void hns_mac_get_link_status(struct hns_mac_cb *mac_cb, u32 *link_status)
>  {
>  	struct mac_driver *mac_ctrl_drv;
> @@ -83,6 +104,14 @@ void hns_mac_get_link_status(struct hns_mac_cb *mac_cb, u32 *link_status)
>  							       &sfp_prsnt);
>  		if (!ret)
>  			*link_status = *link_status && sfp_prsnt;
> +
> +		/* for FIBER port, it may have a fake link up.
> +		 * when the link status changes from down to up, we need to do
> +		 * anti-shake. the anti-shake time is base on tests.
> +		 * only FIBER port need to do this.
> +		 */
> +		if (*link_status && !mac_cb->link)
> +			*link_status = hns_mac_link_anti_shake(mac_ctrl_drv);
>  	}
>  
>  	mac_cb->link = *link_status;