Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp222517rdb; Tue, 5 Dec 2023 03:50:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IEemow7ObbjIFcTusKVlU4iP1C/CrAbF4p8Jm1VIQovJX0322hMSyFAN90GYLHIB3wUrlYp X-Received: by 2002:a17:903:41cf:b0:1cf:59ad:9637 with SMTP id u15-20020a17090341cf00b001cf59ad9637mr1782260ple.22.1701777014712; Tue, 05 Dec 2023 03:50:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701777014; cv=none; d=google.com; s=arc-20160816; b=xBk4+RbTr34BeXjjQQbUEv6NJMH8QGP8IJCnYEPTKPjuXOPJxBOcCgMuI8s3RHNz4b y3ZSd7DRKbxcuPkecpyog1P3G5AzY5VaUIqyZVX0AO2oD5ljPbzpxqbRmh8mW1rAZluu SqP+fKQ4DIkfS78RfbqrY+rMaQtUVu2L6UyPA9j8Phqc0UnT6ot8qlKx8Jfg9BU9i0QK oTvN2v34vHGeaEqbptObaNyL8UzdlIiF9+zy31UoaBNJ29se7cg6Cuh/eEvX0svp9H8D kSBl6++GzZQbHjgIk04WO+iPJOkzQTcqDLSW0vpWkhGhxBdnqcCjQRQCuHzNE1na3WOM l3rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AcNcuzGaQBjUBsiLWETqgO5QGNFrGHbqm/wUp0AM8dI=; fh=eKlnhI9a4UTV/1Y+BPKY/OGzRnYeoIPkxWMpAQTDs6c=; b=caDdZSSD2R0/i6PMwMb/hEi8GHGYtY4aiyOnAZZ8H7Mz96aW9fiMuvHxpJ2fwfQBnG p0Is397dyyoroNUxQ6zb4X0L7iTY1YKvJnk6tc0EY+pQKZXz/VT5fdHUhQoxvTmq3S3o 3DYWA+TyLQRxF5I3y9cziQHvwXDoGPeapwuKXe3C/XzPyhMqsKqu+t/4tdvUgiIqegST /hEQO0STR+iMylzzWh17kECHwP9dojZZs6zPzABslBm5BXS1b12jMsK8A8AgMAixyDAq 6OcycTuDwM4UHsA1gaAXOg29hrMSWhtFeQvY7seeKhOkcN2uRMlMUM4tosYO7E1A+J9z b+HA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="SEVVCGo/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id p11-20020a17090a868b00b002869011b3cesi4414015pjn.31.2023.12.05.03.50.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 03:50:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="SEVVCGo/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 602C98052BDD; Tue, 5 Dec 2023 03:50:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442323AbjLELtx (ORCPT + 99 others); Tue, 5 Dec 2023 06:49:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347077AbjLELtk (ORCPT ); Tue, 5 Dec 2023 06:49:40 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 660C31AB; Tue, 5 Dec 2023 03:49:46 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-50bf898c43cso1994651e87.1; Tue, 05 Dec 2023 03:49:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701776984; x=1702381784; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AcNcuzGaQBjUBsiLWETqgO5QGNFrGHbqm/wUp0AM8dI=; b=SEVVCGo/NXb7w7bSjOiZx0rYuK6Eyyy6rI6Gyc5cnev3w19Ma7/WpOQ9C9G4onTNPx wKZBDQXA/2MV4lNYaS3zuiFoFg9ZTwn5IU4kIdyvvEoBjcfpp5sgDMTr79/meJ+N6IYv UjIIC4dqE7/9J5S1bgpgL11toczURz8AbNHLOL+ei2tT3BaSjI7HN8xViK7X19GX+WGP C6L0JPvPnsIDkhCPToPi9EcxH625z74X+p5EhPiTk4mzlC7IGRpwkn2Inwfqa5kRtQ65 5MIJCcbtwmByC2tc2nQum1LvzDC637VpJwcU3xkyess+cqPgQJmCZeI/f++hWQ3sEQec YJgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701776984; x=1702381784; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AcNcuzGaQBjUBsiLWETqgO5QGNFrGHbqm/wUp0AM8dI=; b=DcTITSU7NLfBJDMD6ZIFR/m6G2RbEe7GUtYmWk43DpuIleGO0wSv353YaERfYvLVp6 jFdpcqdngvznMyM4RnvbGN/X3HmVLiOQ+jENJYXdMQkHp+329JX1ka/NOqnd+fywYTaI 19BeZ+xNU+0TwAXGQuZsXzXIAfQmzJzv29r5mfXrF2Z1HUTUvdr1/N0GbN/3geKXTfJt MInDixlGftEpc3duOGktoofP1bTEALPFyZMDegOlxb+YDxQy39qmHg1CzbUzb7TahBt0 B1ogjnECDg2ZHeRKMdb60vKwx7EDa4sZ5uWuMBhzxYzsjlr8Vdeo3FkBMmiDvZlDSzOO 72IQ== X-Gm-Message-State: AOJu0YxBz0CE622HQ+NsnTv/VGV3pILyHe80prybPmtsDtojM77zygTD 42aQP0rt+jCnRTYlSQmWW1E= X-Received: by 2002:a05:6512:1394:b0:50c:320:f171 with SMTP id fc20-20020a056512139400b0050c0320f171mr476503lfb.197.1701776983952; Tue, 05 Dec 2023 03:49:43 -0800 (PST) Received: from mobilestation ([178.176.56.174]) by smtp.gmail.com with ESMTPSA id e2-20020a05651236c200b0050bf0921ac1sm792193lfs.206.2023.12.05.03.49.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 03:49:43 -0800 (PST) Date: Tue, 5 Dec 2023 14:49:41 +0300 From: Serge Semin To: Vladimir Oltean Cc: Andrew Lunn , Heiner Kallweit , Russell King , Alexandre Torgue , Jose Abreu , Jose Abreu , Maxime Chevallier , Tomer Maimon , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , openbmc@lists.ozlabs.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 05/16] net: pcs: xpcs: Move native device ID macro to linux/pcs/pcs-xpcs.h Message-ID: <6zejbbv6oriaztbbgyjy6r6hycccq6rvypb5ywxf7nqx3vlq7r@na5eossdsuec> References: <20231205103559.9605-1-fancer.lancer@gmail.com> <20231205103559.9605-1-fancer.lancer@gmail.com> <20231205103559.9605-6-fancer.lancer@gmail.com> <20231205103559.9605-6-fancer.lancer@gmail.com> <20231205112755.3am2mazwireflpkq@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231205112755.3am2mazwireflpkq@skbuf> X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 05 Dec 2023 03:50:12 -0800 (PST) On Tue, Dec 05, 2023 at 01:27:55PM +0200, Vladimir Oltean wrote: > On Tue, Dec 05, 2023 at 01:35:26PM +0300, Serge Semin wrote: > > In addition to that having all supported DW XPCS device IDs defined in > > a sinle place will improve the code maintainability and readability. > > single Got it. Thanks. Seeing there are so many comments about the log messages I'll double check them on v2. -Serge(y)