Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp243861rdb; Tue, 5 Dec 2023 04:27:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IHWzQmg9/pm12Q6SM2uDgGnKdLDg6bpTCRWCSyUajtWcZfb7D2JDlXNHrAieFtekQNffZF8 X-Received: by 2002:a05:6e02:541:b0:35d:63a8:dd88 with SMTP id i1-20020a056e02054100b0035d63a8dd88mr4181890ils.61.1701779259466; Tue, 05 Dec 2023 04:27:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701779259; cv=none; d=google.com; s=arc-20160816; b=ZTaMfbcbFfyicA2anRGmsVhYxSPsmcBWxFo+vvPORDrE+PUwIvdDXR4vRkwYALO8u1 VbgPooaCLkbS2wv2HCtIeUrUeZ7kvIiCjKHrUNKe0/Xultjdj75eUuytNoHgvlW5Fhad 2aOH2Ju2vQOWD/LHpK2ficoOxgYytiqzQ2rvW4a9kr25pHRBZTCY9+Uj8pONfH5zzwsv JRYAtYe1Rpw5eO9CKCJbb1zW6GOebw4CCRByJtRozoFoonHkcfg4BEnymohfugWIhgIB ONbbS2b7mz/ytJYApaxmKcI3dbM4PqYw9BqLi0XoPqAtl50GSK/S5L/0mUYVSlq954cn te0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:autocrypt:from:references:cc:to:content-language :subject:user-agent:mime-version:date:message-id:dkim-signature; bh=aRJJ7WemOgSJ/YKJxC2Of+DlQT2AvNtfSGJVPMHu4Qk=; fh=241Vp76XhryhN4jdwHk0rPqD5iJoXnTbU205f9qwYR8=; b=ITr7tFgPHa3BMWRLoXjbogCOaZdApzRrId8XZTA8U1wMGTEFvnRRVB7xNVy26fgTae Ogp/u7pUdZMxdE686GdBss3jOLjOJ2okyXS9Nhoxp+TI33QwdcceFmqPeWo519W5av8b cjtTUV33h4C9XhJo5cEPdZJYdonng5ar5sNopftVNpO5wHfFeM6tvplQbvZVVCjy2IkL vbm0Zw5+T1kYAJDRDpUhyZfmMUrnEcft3LizcTzTW0DwMSUAk1XNWhaVfp40EAZP59/r RlF1EQtJLmduPKR6mHNwzVX8jP3jYHWCaNftM34jiVXNo22w3t2O5QgBax0676OcB60l /KTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cR++U4cK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id q145-20020a632a97000000b005a9b0fe6afbsi9641324pgq.144.2023.12.05.04.27.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 04:27:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cR++U4cK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 381DC80436B4; Tue, 5 Dec 2023 04:27:37 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345311AbjLEM1K (ORCPT + 99 others); Tue, 5 Dec 2023 07:27:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235633AbjLEM1A (ORCPT ); Tue, 5 Dec 2023 07:27:00 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 160001713 for ; Tue, 5 Dec 2023 04:26:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701779214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aRJJ7WemOgSJ/YKJxC2Of+DlQT2AvNtfSGJVPMHu4Qk=; b=cR++U4cKBKAPNxv8Calyd25cbRpfPDKO0HafhiW5I3ttYWF+HmiIqfcB7AGB2RKJJS7Xqc i5liGwrEKORKi+qMvtJrIcGgS1QL9gqHdvr9ZOgSjpfsvBOc9ucJAsvfa7uJZav0PWppGD ctCdHsPd3rUx0kIOZAKH1aOOi3DJraM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-VXJ4RChmOFup7Hogim2R9A-1; Tue, 05 Dec 2023 07:26:53 -0500 X-MC-Unique: VXJ4RChmOFup7Hogim2R9A-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-33353f98b7bso889811f8f.0 for ; Tue, 05 Dec 2023 04:26:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701779212; x=1702384012; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aRJJ7WemOgSJ/YKJxC2Of+DlQT2AvNtfSGJVPMHu4Qk=; b=YoSUwfNa3XC+qVjIN1C3zPZ4z6OUwq7/DzWqoJKvtc3IIDGu6H06mHrA1zgUHzwQou KuQkhEQxiBkSOsr03KdStjz1mdtbL6BbPxYzPeofVMIXxIyJzf2vFKok/yfVzFllx8ph KZYysImtvcfr1YzXQImkUjKSVK9f74Cn2z9MW0icmOZCetCssg5OU49hbdO2zWZdbRiX ggKAzDC8qohS9BIFdLYgz1uN3iPEzGm4QQpNCJY49aCRPfPTcVNPDnvbZeNtP9fbs0qi rFMaudaDJo8znnhoQa8lJwWIAty8Z96a4sGvg1H1/tOvyWspx7/eLlHbJsmktb8qQwCC Sr3A== X-Gm-Message-State: AOJu0YwEs9DlORqG/FdSDSqEagyZMVospqswbpGBemlr6uT3IcAbb8if bl7pkxV9J/7FCMJcRBZJXkuWENfSstMZPuIPz1c2Ze+gExLgZAJ4NaHfoN0guq2LN6VEzDaxKSw h3ZbiMuqJPMZRWX72TJfCV/zj X-Received: by 2002:adf:ec49:0:b0:333:2fd2:4ad6 with SMTP id w9-20020adfec49000000b003332fd24ad6mr4418260wrn.82.1701779211890; Tue, 05 Dec 2023 04:26:51 -0800 (PST) X-Received: by 2002:adf:ec49:0:b0:333:2fd2:4ad6 with SMTP id w9-20020adfec49000000b003332fd24ad6mr4418247wrn.82.1701779211519; Tue, 05 Dec 2023 04:26:51 -0800 (PST) Received: from ?IPV6:2003:cb:c72f:300:1ec7:2962:8889:ef6? (p200300cbc72f03001ec7296288890ef6.dip0.t-ipconnect.de. [2003:cb:c72f:300:1ec7:2962:8889:ef6]) by smtp.gmail.com with ESMTPSA id a10-20020a5d53ca000000b0033330ace23asm12044230wrw.73.2023.12.05.04.26.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Dec 2023 04:26:50 -0800 (PST) Message-ID: <873e12ec-c153-445c-aaa3-a68c59a01fe8@redhat.com> Date: Tue, 5 Dec 2023 13:26:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 15/39] mm/huge_memory: batch rmap operations in __split_huge_pmd_locked() Content-Language: en-US To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu References: <20231204142146.91437-1-david@redhat.com> <20231204142146.91437-16-david@redhat.com> <3c03d009-6a46-4321-a38b-9707b4558618@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <3c03d009-6a46-4321-a38b-9707b4558618@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 05 Dec 2023 04:27:37 -0800 (PST) On 05.12.23 13:22, Ryan Roberts wrote: > On 04/12/2023 14:21, David Hildenbrand wrote: >> Let's use folio_add_anon_rmap_ptes(), batching the rmap operations. >> >> While at it, use more folio operations (but only in the code branch we're >> touching), use VM_WARN_ON_FOLIO(), and pass RMAP_COMPOUND instead of > > You mean RMAP_EXCLUSIVE? Indeed. [...] >> - if (!freeze) >> - page_ref_add(page, HPAGE_PMD_NR - 1); >> + if (!freeze) { >> + rmap_t rmap_flags = RMAP_NONE; >> + >> + folio_ref_add(folio, HPAGE_PMD_NR - 1); >> + if (anon_exclusive) >> + rmap_flags = RMAP_EXCLUSIVE; > > nit: I'd be inclined to make this |= since you're accumulating optional falgs. > Yes, its the only one so it still works as is... Make sense! -- Cheers, David / dhildenb