Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp256834rdb; Tue, 5 Dec 2023 04:51:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IGXLYvOZ9ze3ZIYmZvKIcU28UoIzp2rtGzOs+GDcuj0KRgyXENqn06SY5Zt89OBIfwz4twa X-Received: by 2002:a17:903:1250:b0:1d0:8db6:17cf with SMTP id u16-20020a170903125000b001d08db617cfmr4814765plh.23.1701780676967; Tue, 05 Dec 2023 04:51:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701780676; cv=none; d=google.com; s=arc-20160816; b=LHiBVHycpVIq5cA5yEZ83gI7tjp3uOcm1wy7ieLntiIa4fs6Lcf4TYFeu9UDm7GERr Z8ArXMfD7yDdCHErk5wkBkylYEuC3wUj5bFvIhJt/vSgFUNSxUHWUHJaW+OkdhX8jpQ7 455DnnJ9p8sQyosbCxMlvD/AcKi2dJH10k1Rl7/esDrPRGRQW684RXyNXXBnkf97Yn1U Rmk3Wuc6/3vIYWt22+FYg+KgJkkq3DTfusxLWZwPwXzRt91yFuuh1/FXTp99zQAWzK1u fqOCGbAwXNLqgOSPrYXdyw9H8aJFTQilowRLsZ871lSYH6DkmAMdw3lLxJTSirREEy8d iakw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=25fvtOBjhBo33iPIPAuHCC+gkTh4mzDUuiueekyS6Ug=; fh=NzvI9WtqGF+hH55HUMMtI61liIRz2/o149Jt8/FcM6s=; b=oeJDykY56ooNyKsNpiK7UbIxqgTBaS5cumWLvPvC+Jo1bDiwT84b0yPiAvQvXq17bM jj7RmRXR9pgxM5J3zPJIkz+oqcwzEP85m/CRqT23xYtGohta2CCkb2HRu9vT0vdPK2fm 4pXhueQqFlvXQSbT79waip86FilElBueLsVNjKPhMHHx9bbZ9TO3vE6F9SpQ/y8MP0ap VpIRf9qEC8wycwEZM2+FXEoxG/6zhIiS6PsysWT4rn3e3wOSjkao9NdWMUSj+4gpKgvV E93jrNrsxVvjvgQothtSjEetfSk1HG51GEAPRO9dJWAoLy/qyzgoWXckUaBY7uOnWHOy hf2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f4SvzZfU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id b23-20020a170902d89700b001d0b7902fbasi2253545plz.189.2023.12.05.04.51.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 04:51:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f4SvzZfU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 32AAD80A87DA; Tue, 5 Dec 2023 04:50:35 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345208AbjLEMuT (ORCPT + 99 others); Tue, 5 Dec 2023 07:50:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345119AbjLEMuS (ORCPT ); Tue, 5 Dec 2023 07:50:18 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7400CA0 for ; Tue, 5 Dec 2023 04:50:24 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPS id 1636EC433C7; Tue, 5 Dec 2023 12:50:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701780624; bh=c3K5tJw47+N/W1nF4uxZF7+ilrykgTTkPU8dcFu2UbE=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=f4SvzZfULqqut3U6Jxms3i7pKTKrOt88dpqXigdH2cFkQ+S1e5KvSWxLOVHtu5IQy JT4qSqDpvcjT7oRc7HI2T/lvuaM234v0WIJzys1ryGpTVHAOiulV6EP/A3rNXBZExv s53hGnsVOUn37Qmk4MPoeobMtba3sDmaBUKweqZSFowMjt0Vv1dqAT7cEPaBQvJvIt VHImXnOur9e/nmsh0LhDiRY2lmm47/NBrjNMoy/aQKcv+cfBV2MRRBXxFMRbmxhgz2 jim19dFINaI8eFR3kKAMIJ8DUA22zDkS7lEmH2WKbIH/ZK8gZkv5ohCHuu4ripKSfP IT2xJVXDelGYg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id EE122C43170; Tue, 5 Dec 2023 12:50:23 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH bpf] xsk: skip polling event check for unbound socket From: patchwork-bot+netdevbpf@kernel.org Message-Id: <170178062397.423.16825004727771471084.git-patchwork-notify@kernel.org> Date: Tue, 05 Dec 2023 12:50:23 +0000 References: <20231201061048.GA1510@libra05> In-Reply-To: <20231201061048.GA1510@libra05> To: Yewon Choi Cc: bjorn@kernel.org, magnus.karlsson@intel.com, maciej.fijalkowski@intel.com, jonathan.lemon@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, threeearcat@gmail.com X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 05 Dec 2023 04:50:35 -0800 (PST) Hello: This patch was applied to bpf/bpf.git (master) by Daniel Borkmann : On Fri, 1 Dec 2023 15:10:52 +0900 you wrote: > In xsk_poll(), checking available events and setting mask bits should > be executed only when a socket has been bound. Setting mask bits for > unbound socket is meaningless. > Currently, it checks events even when xsk_check_common() failed. > To prevent this, we move goto location (skip_tx) after that checking. > > Fixes: 1596dae2f17e ("xsk: check IFF_UP earlier in Tx path") > Signed-off-by: Yewon Choi > > [...] Here is the summary with links: - [bpf] xsk: skip polling event check for unbound socket https://git.kernel.org/bpf/bpf/c/e4d008d49a71 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html