Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp267014rdb; Tue, 5 Dec 2023 05:07:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IG7v6vTQhkEuHoDw1LuhjJNd2VL8XymM+1KFRlnpMnptjkuYh/0PlZKk7d66Y5hvvtmdlXb X-Received: by 2002:a17:90a:fb50:b0:285:80d5:6e51 with SMTP id iq16-20020a17090afb5000b0028580d56e51mr903836pjb.21.1701781641234; Tue, 05 Dec 2023 05:07:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701781641; cv=none; d=google.com; s=arc-20160816; b=VBvLl5zkri0zG9yHXkRsHcsKBTU9xfQD/3jwe/hsHBErhNC3Zw5XStbH+rITRFiRc0 ngFLpjS1t+jNRxTiHoEoWD0LAeYOcvaaBNX6RmLbOUCleEjRZyevBaahQFoVkSqSgS3A OfgjSA+nM3uZzUI6M0Woa3HUkoesL/xp3ihMNMreD8tvugieI8bq/RbgjHkAi7ZXh1L1 fBXp5wwYbrjBLP4LdGAmINUTg1ruTIFOoz6iWAOsE3vRfnt6dqMYvrW164+Z+ouRsmGk HJcHZBJUNhGXHDQeuT3pP50mDWMcXKcFLoBhs1VSHXIdo77HyOL+MARR10lmvUlmJOU+ 3Cog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=esZIg4k1vejK+Ovs7uaHd37lyuP5a7qtqkhY+WqTKN8=; fh=qYSCmyERceYEPFKlTrm4ICHhKAlq7ZjVDbCn77A5Grs=; b=xW2N5jy2N5omUpvvk2NQT6aGnjT/kPR9KAG2GSgSSaOI2sqbEZArLD6f+1tIm/XrBN TfNpQAJDM6eOcpYb4UF7MWNddR+L5FUYc5norGXVVb8qxYcjjENxjQy4kwPVAQn8nWTT yjXm6jMRP0u1tHVM9H6WwmICRB32M9iytWhXxqhFyPxTzMBqPI19XtAGz/UvXFYeBVvM 0M6zVNbs13rKdfZ1c4/zCg/hxO4ybD7A7OgGa7OOfjXOMEe1QJPDQwKzfUIVIUe37FiP iGZ7GD6hd8fWZVwh6sG8eK9oG/SLWEuLwlXQETN4YSVmvH/6l9qsnPFoTlsSXzdzCi4Z mx5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=REsYKDff; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id p19-20020a17090adf9300b002850fcb1197si8343799pjv.14.2023.12.05.05.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 05:07:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=REsYKDff; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 13AFA8047518; Tue, 5 Dec 2023 05:07:17 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345366AbjLENGl (ORCPT + 99 others); Tue, 5 Dec 2023 08:06:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235139AbjLENGk (ORCPT ); Tue, 5 Dec 2023 08:06:40 -0500 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D370E120 for ; Tue, 5 Dec 2023 05:06:46 -0800 (PST) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3B56mS2Q002076; Tue, 5 Dec 2023 07:06:34 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s= PODMain02222019; bh=esZIg4k1vejK+Ovs7uaHd37lyuP5a7qtqkhY+WqTKN8=; b= REsYKDffvO6WSkLUBPuJqg5zx/Xw+dOkgw7s4T+fDRZE3MNyC0YDoLuv3GXpdFcX r6+ickhYpwQraDZa2+wUO3N7D9ou/774jDO+8rTLxUpS/l0bDYyOYtNJAIcNDdy/ Ui1atJr/lBCnV6jalZKSWbvJOLZB/BLYRoz+ts+KXu3ZT92x2LhLn66lhppu5dMI pCjmOZZdiU7cqXTaUaEL95WtFvGflpoQMCJhIjmOMs3CUwKurunn88h2f520wIYk 74EM2cJvd4HYVGH86WQfGYhva7BOJgxLb76dTBInJR/vcuf9ogVk3auPO6D5w9Jc L+Hj8y8CmPXY3xovrQ1fyw== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3ur2v236e4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 05 Dec 2023 07:06:33 -0600 (CST) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 5 Dec 2023 13:06:31 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.40 via Frontend Transport; Tue, 5 Dec 2023 13:06:31 +0000 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id B6B1C474; Tue, 5 Dec 2023 13:06:31 +0000 (UTC) Date: Tue, 5 Dec 2023 13:06:31 +0000 From: Charles Keepax To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= CC: Liam Girdwood , Mark Brown , , , Subject: Re: [PATCH 1/8] regulator: arizona-ldo1: Convert to platform remove callback returning void Message-ID: <20231205130631.GE14858@ediswmail.ad.cirrus.com> References: <76c7af01e2c8b3ab6585a04bc3f0d163fbb7fdf7.1701778038.git.u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <76c7af01e2c8b3ab6585a04bc3f0d163fbb7fdf7.1701778038.git.u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-ORIG-GUID: SjEKKDuG7L3EtcdDoAJUFpHPalutlvn1 X-Proofpoint-GUID: SjEKKDuG7L3EtcdDoAJUFpHPalutlvn1 X-Proofpoint-Spam-Reason: safe X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 05 Dec 2023 05:07:17 -0800 (PST) On Tue, Dec 05, 2023 at 01:26:16PM +0100, Uwe Kleine-K?nig wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-K?nig > --- Acked-by: Charles Keepax Thanks, Charles