Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Tue, 5 Dec 2023 10:44:17 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Marc Zyngier <maz@kernel.org>, ankita@nvidia.com,
        Shameerali Kolothum Thodi 
        <shameerali.kolothum.thodi@huawei.com>, oliver.upton@linux.dev,
        suzuki.poulose@arm.com, yuzenghui@huawei.com, will@kernel.org,
        ardb@kernel.org, akpm@linux-foundation.org, gshan@redhat.com,
        aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com,
        targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com,
        apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com,
        mochs@nvidia.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/1] KVM: arm64: allow the VM to select DEVICE_* and
 NORMAL_NC for IO memory
Message-ID: <20231205144417.GE2692119@nvidia.com>
References: <20231205033015.10044-1-ankita@nvidia.com>
 <86fs0hatt3.wl-maz@kernel.org>
 <ZW8MP2tDt4_9ROBz@arm.com>
 <20231205130517.GD2692119@nvidia.com>
 <ZW81mT4WqKqtLnid@lpieralisi>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZW81mT4WqKqtLnid@lpieralisi>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3Z07Sj/2JVbzSBNWdjB9O9Ifcf5KKOQBFQhZI2OjQBCcD/ypH4PaU3kZW/ER?=
 =?us-ascii?Q?z1gIgtvt084g4lni8UjSJVEYNs7MNBaS36Y7fI5nYJy7W5Zm54fN+K7ITo8T?=
 =?us-ascii?Q?qZ+I79tySF71U+Oh3AWCJlshP4bcO4juoGxrbEU5exWPG31mMz4SnetFISjD?=
 =?us-ascii?Q?utzAiWGXqy46geZJcdVnAA2XUDm7P2JNWWDPUxSnz2A0PNVFIyWM99n8+Rzh?=
 =?us-ascii?Q?St8sO+BoU7k8iq6kB9Nm/KnAn0DYoW2BpflqQT/3jfMkoAyNcKGOEoB+ySfC?=
 =?us-ascii?Q?oxJfKPqEZlw0TvuTWw2HcZ1UD3LXjUtxmKqGWuj//wuck0jqWERBpBL+enoC?=
 =?us-ascii?Q?nc6sfMlQE2y6XeLNUGlb4HsPqLfGnjmTih+vel3XJj+Nca+q6yRoI3CMTBw2?=
 =?us-ascii?Q?L+OsWWaoC5zg50A3lYs+lyDPtRAnoAoe0viJjZ0iQdjubKeYz99SCpCzLAhP?=
 =?us-ascii?Q?6ScGmnLJtkvrrkSbPNNlRrHW1LzxXV1sN91fbzwaVUO2zkGYX6CfzF3vYlCx?=
 =?us-ascii?Q?QvTUj+ATHNQc7gCWVllaibu8PMGP2ASt2AuSiHcTsEFCXoIbzJdpGz1PT1X4?=
 =?us-ascii?Q?xjIedcJGC0fWSOnZjTTm6+XRWsqxk/fwqXkJqvNJNxb+9dS38QKlZqsunutq?=
 =?us-ascii?Q?1dY2pqfSjU34vuQzpqpCNlA/ds1QNGIbyF8SA+n0EFbw7IdLhP6ormtdk4xr?=
 =?us-ascii?Q?kf8GFILu+m3tLEyG5pKym6Qif3tDmBYDwmY7MrD6oJw/rmY4ntudvpf6sHU0?=
 =?us-ascii?Q?DdcHljDdj8mvpK4OC0zEXf9s0ZSiPFch32dbYsTf0wu59r8DNAoV3DFlqdXo?=
 =?us-ascii?Q?edp0JSBytTH5x2Y4xxqbU2dRWpcpPxrMsgfzzlV3VsWHLCslHyw2t2kImzWK?=
 =?us-ascii?Q?CIZiV/AUnvLfu7dNEbl55UH7C1JarvzOnOVt/Ps97KserTkG9zldFfhvfCj1?=
 =?us-ascii?Q?0+h5Rajn78t84m3eMV+9Zcsf8PB8XSOnI8/elrTeKK78dI/OHjKbvnCqe6A/?=
 =?us-ascii?Q?ghLmRkboff1OMW6KWF2lZc6XPo4Fj1H8gYhomyxkytOLst5LFF7AiY0YnXnB?=
 =?us-ascii?Q?PktdJ5b+ghXRtSjZgfScwGMOrxqIbH+PxauB7q2GovHfUf58Wzgmo5xU/KvK?=
 =?us-ascii?Q?sT+v3FxcLlfJY+wBuK/a1CTLTWFHU8rm+RvrkABiz2xZYcdI1YEsVrOEK3SV?=
 =?us-ascii?Q?UCDhjaJBaQvEUupWHj0lft5cAg/tYtzWxWkvxsdSisOEn+diAXs7/EnbLZ0r?=
 =?us-ascii?Q?dZ4oV5WVVsggCGaFwKIWKbJcfnk/v/VDTQUMsDb6z+M+BXcOB9ps8vkrytqY?=
 =?us-ascii?Q?cxHIw3bjQQY+H7NLlJzxCVsp1Zu+02ZXl2xPhOeftuv+6q9sqaQWncAqtAN4?=
 =?us-ascii?Q?aJEN7L1KVrikuxgIw3zPyCiZwjGl+Tw90Iu1xXSC3m+Dk7rTzzcb0uVmpipo?=
 =?us-ascii?Q?FBF8D8TnERcDFtzDPU8Ml6LGC4GZOaiz9YVYLPz/GQktUUNalPSsxtPHDZmD?=
 =?us-ascii?Q?2Ebu6C34NlAdp3D405naaA9gM8UeWYcbINVy40PwuxCNyRdFqRuxySWJ3mWU?=
 =?us-ascii?Q?Xvz4uuFq5Jiy7NpqMUCwbffA0r1ZJF2FVYnOTMKH?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1652f45-1790-4e76-cd37-08dbf5a0a8b2
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2023 14:44:17.8555
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: miXPyv6u1aKOhgkCs50XmdXqkhvqWdU8/Zwt9TcgrYqIaS8zZSY8sIZ9MLHOk9mX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5315
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 05 Dec 2023 06:44:33 -0800 (PST)

On Tue, Dec 05, 2023 at 03:37:13PM +0100, Lorenzo Pieralisi wrote:
> On Tue, Dec 05, 2023 at 09:05:17AM -0400, Jason Gunthorpe wrote:
> > On Tue, Dec 05, 2023 at 11:40:47AM +0000, Catalin Marinas wrote:
> > > > - Will had unanswered questions in another part of the thread:
> > > > 
> > > >   https://lore.kernel.org/all/20231013092954.GB13524@willie-the-truck/
> > > > 
> > > >   Can someone please help concluding it?
> > > 
> > > Is this about reclaiming the device? I think we concluded that we can't
> > > generalise this beyond PCIe, though not sure there was any formal
> > > statement to that thread. The other point Will had was around stating
> > > in the commit message why we only relax this to Normal NC. I haven't
> > > checked the commit message yet, it needs careful reading ;).
> > 
> > Not quite, we said reclaiming is VFIO's problem and if VFIO can't
> > reliably reclaim a device it shouldn't create it in the first place.
> 
> I think that as far as device reclaiming was concerned the question
> posed was related to memory attributes of transactions for guest
> mappings and the related grouping/ordering with device reset MMIO
> transactions - it was not (or wasn't only) about error containment.

Yes. It is VFIO that issues the reset, it is VFIO that must provide
the ordering under the assumption that NORMAL_NC was used.

Jason