Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp334242rdb; Tue, 5 Dec 2023 06:50:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IGIplUOySsghObmASNYHc+YNMWsq18Kv1Kvk4Ge7PlkZRcs1QS5pDe4TNvPGjypg+3z+7cm X-Received: by 2002:a05:6358:27aa:b0:16d:a668:bca9 with SMTP id l42-20020a05635827aa00b0016da668bca9mr2965791rwb.11.1701787830907; Tue, 05 Dec 2023 06:50:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701787830; cv=none; d=google.com; s=arc-20160816; b=rEYagJW8FrHj4fmr9mv+ltpGQXYprjWGZJrFLlE82+21YeCY2cBGLtCAdYSqQ8aRZx Jk1lS30btexgesEw+Yr9XjLWHIhdPdbNaAfidLlVFd/+5DTTXx8JEw3/Bu4QBFSx5tZr MSIGd/7rg3jA4P8u2U2Kf8vscPNAPnsWpxNQlNpmwWRkkDg40VsAHn9HsZeCmfVURF/Z 1iolN8fxz4vZmJrHWjMqhyqtACv3yttRKNFDcV87E1Z5DiEGhawj9yrlg+6/whFTwfAA saEb2/KJ5Ur+66UN3QHJcRA2qdEjG8dlGxbXnyLBeioukK/GKGdsOnukRxSkXY4sM2fy TUKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=AVIyacoqKkC7x1gKxIqCxIn0q4fpQBfPK1r+08y0i3M=; fh=F2ybT0DQoIgZwaW5GRhXQni2djmK89K/TTgIsTmxSMU=; b=oyPA9HIRw1ZkdKlOxRkB5DuoLKS1nZwyXleV+dy/eE/J0dl4rsjAfg45dznHtXqz1S ZD3JEaZhKHD14g55tYtOc2TrY2EBTPoz5XgI9QXnZwOjczxDYZbcx6QnjR0vU9YWVD4a oZXg8IUw89OWQ3Qrj1dmzapBvmdngwHf9NWI3JUCW4dwpfzTq1f13J8ldSAjtqtWv8ML qo5IilWMRngBqIDQzJ4CABUYV3cGBXMgOflkPr6b2SeknegZLpWMN8rbo/2qL53GahFb Ua7sLcVdnpvXJMbC9MAgcFjAUAjaKx/zTVxZMkuSrFBguZ1agmTETnQRJBJfTX+9Yxst yzYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AoullTc7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id v21-20020a63d555000000b005c661efffcbsi5349230pgi.78.2023.12.05.06.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 06:50:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AoullTc7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id DA65280C246D; Tue, 5 Dec 2023 06:50:28 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345724AbjLEOuT (ORCPT + 99 others); Tue, 5 Dec 2023 09:50:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345682AbjLEOuS (ORCPT ); Tue, 5 Dec 2023 09:50:18 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25BC8D44 for ; Tue, 5 Dec 2023 06:50:25 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPS id B8307C433C9; Tue, 5 Dec 2023 14:50:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701787824; bh=VVDxm6oONgHLGn7mC1aQKyK5BXNMwRgtPv7JaM0VSz0=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=AoullTc7wYmOj+z89p8n0TSMtTON/N0kpU2uWqpHCt1yfKp5bmDC2eMfmxm4+6/7s t2FLdJB8OA0QXpOtDyE8uIZ8W5JCm0lYu5vpV7zEnPU5v+adVpyhiN93HgEfqELZpX XaXrRv8dTRskCF4fcrF/f5yFIUoB4OCrE6PmZXQb8ZYyYeQnom3/wNP8cOCy/wVRGO ioiCGdz3PVxp1OIKcddv5bTb6uT794nauXoNnR26ZHKeDKvhKOAdQ1fQX86RaoToMF fRhz901CRC5ONq0jVvyPyH0lZpRkzm3C6SyPkN0gXE/xanDbHx1OGPNs9G+CgfsMkq i07Jq/WZyoQoQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 9B6B5C43170; Tue, 5 Dec 2023 14:50:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] octeontx2-af: fix a use-after-free in rvu_npa_register_reporters From: patchwork-bot+netdevbpf@kernel.org Message-Id: <170178782463.5866.15530520826379861519.git-patchwork-notify@kernel.org> Date: Tue, 05 Dec 2023 14:50:24 +0000 References: <20231202095902.3264863-1-alexious@zju.edu.cn> In-Reply-To: <20231202095902.3264863-1-alexious@zju.edu.cn> To: Zhipeng Lu Cc: sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com, jerinj@marvell.com, hkelam@marvell.com, sbhatta@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, george.cherian@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 05 Dec 2023 06:50:29 -0800 (PST) Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Sat, 2 Dec 2023 17:59:02 +0800 you wrote: > The rvu_dl will be freed in rvu_npa_health_reporters_destroy(rvu_dl) > after the create_workqueue fails, and after that free, the rvu_dl will > be translate back through rvu_npa_health_reporters_create, > rvu_health_reporters_create, and rvu_register_dl. Finally it goes to the > err_dl_health label, being freed again in > rvu_health_reporters_destroy(rvu) by rvu_npa_health_reporters_destroy. > In the second calls of rvu_npa_health_reporters_destroy, however, > it uses rvu_dl->rvu_npa_health_reporter, which is already freed at > the end of rvu_npa_health_reporters_destroy in the first call. > > [...] Here is the summary with links: - octeontx2-af: fix a use-after-free in rvu_npa_register_reporters https://git.kernel.org/netdev/net/c/3c91c909f13f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html