Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Tue, 5 Dec 2023 10:53:41 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Yan Zhao <yan.y.zhao@intel.com>
Cc:     iommu@lists.linux.dev, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, alex.williamson@redhat.com,
        pbonzini@redhat.com, seanjc@google.com, joro@8bytes.org,
        will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com,
        baolu.lu@linux.intel.com, dwmw2@infradead.org, yi.l.liu@intel.com
Subject: Re: [RFC PATCH 16/42] iommufd: Enable device feature IOPF during
 device attachment to KVM HWPT
Message-ID: <20231205145341.GF2787277@nvidia.com>
References: <20231202091211.13376-1-yan.y.zhao@intel.com>
 <20231202092311.14392-1-yan.y.zhao@intel.com>
 <20231204183603.GN1493156@nvidia.com>
 <ZW7NwSCzswweHZh6@yzhao56-desk.sh.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZW7NwSCzswweHZh6@yzhao56-desk.sh.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?52iZaJ10FN49RvDXhAsdW0nQJCSBRZNxRRN092EgZHLn0eSDE9+ARv6SBmEO?=
 =?us-ascii?Q?kqy+ZlWgoP6nTTSOkkzm9LRhCFR4pBv1zA3ZuWUxWWqm5yWtuo4vjnSQazf2?=
 =?us-ascii?Q?YUYTi5xsJgbPjX6Q2eNN+H55F0nnDgSSF0hDRlFjfoa/VfYzVuNwPT+nDUxE?=
 =?us-ascii?Q?s/ds/vD9t0nvqJAatRj3dRw3zOYh2xU44w6qXghWmgxg1xxQBIxWVBOH/5Cn?=
 =?us-ascii?Q?IaInSShPimAStfbeSgoN3ZwkGwoZJw8rKJOtfB7g40GioWhPGW4Cio4bLr/F?=
 =?us-ascii?Q?2j+aq8q2Krdg7s5A1I5Q3IXvikoWAqHRkF59IzsgiiBHczJ3vEpa5nTyP1Qm?=
 =?us-ascii?Q?AIVUURFDMS/aqtCSXtzjqcGJHQ+znPPccxtM6MsQ4kdGPJM3anZ67sJemK8r?=
 =?us-ascii?Q?Ge4pg8Lbivi6yZ+1Jue4CVBQo+r2/QPp5uq+gV8d8gVnM6TzotbAvkoRoWfd?=
 =?us-ascii?Q?b8DNx7X5g1U97gdi3JOAiicyZgEG9FQsqhTgEHGxOWkzwHI25GVrjq4GMea9?=
 =?us-ascii?Q?BM+wgcbcZbjfOo28ID37K5UfnofNBSfNK/2/8zBWOgfVd6fjwlm160YIUpkv?=
 =?us-ascii?Q?FlwRoWGuWKsAfEJQwea1z7hhGRoN8ug27WDIxhSumgW5zr/1nHJ5b9tQTPE9?=
 =?us-ascii?Q?8HsWSc2r2mbUnbXt7sF2IRUhYE9s+aVH+AlVg9uDMHShdopd2uYqKwMh14Kj?=
 =?us-ascii?Q?My4tg0eNMbeRNEf9QwOTcdI4m5J4gEXGbW9X5Gmj686Cml/oUXbZLZ6X7zPd?=
 =?us-ascii?Q?XpefxpU1x9mjnn1hd544w743+ob6F46WTv0s3qh5Y8r9wDRTw4VFdsnexwSS?=
 =?us-ascii?Q?lZg33e/cxvZvt8R1/Yz9hGFHFzOMnIyD3q3TTKU/eQy8WY/HqsETAXYo9B9R?=
 =?us-ascii?Q?RswYf5fEfJqnD+lwImZyuWymLvt5ixKN5rvl52ycsNnGJ/iGcEGuR79xO4e+?=
 =?us-ascii?Q?GxDRyy0sR3lFv2MycCAnPJAKW7dDfCkfYfMSOFYlKg1F0LQHu2JCZC89TSM7?=
 =?us-ascii?Q?3htBe3cv9E5+3gYyTYuclGoBuuSp50WHoJrY47UnwXzWjZchcG3lVYtrZrgS?=
 =?us-ascii?Q?yz5g9latytPhvco/ZKkGwZEc2lYkDMQP9K5VKmQzpuYaUIfHYu96zQWcR+6Z?=
 =?us-ascii?Q?L/B3AeDiQNAqbZbewB1S1SEPqYrANobC+qjrrdiFWf3X8Z1lslSn2SQlBs7H?=
 =?us-ascii?Q?EkK/Debf0ZaUnC2QOWQsm5LnAHzcVzUhlRDXR82YFiMyBrMU3RJ6dfrcdenx?=
 =?us-ascii?Q?1gJjDYjfZUjCe3GPcUs6qWm+DYUzoYdrwydCLuJoJADr9yyCl+/N3aYa2b31?=
 =?us-ascii?Q?O4+u9YayZ+gTJtrqW4ccrgl2RYyS4RCB+7b5CAA92CDsULJMua40y4TQTZyM?=
 =?us-ascii?Q?4raGUqeC7X3m8HWJ94YojnYk3BfxIpYgfYC+mqBEtTbQAWrM5GNrCkHNABSm?=
 =?us-ascii?Q?7C7KxNAIr/i6vi8n751VujbJIFHWOBrKQ+i5YUIA90yD9jVjD7JKy5Jt2zji?=
 =?us-ascii?Q?fCCdXeqgOvN4cEFen2IIbYwDDIFAbIcl9eB5nBI2wu5RTTIMi/xDPiyIbQrD?=
 =?us-ascii?Q?L6RXDnENrhjvhehThq0+G2IN0JxzoR4S2tTZIkNx?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7be6020c-baa0-4b75-c379-08dbf5a1f934
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2023 14:53:42.3708
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /WvJE9sISbHV+tenJe+sMatNRNGWVcuVBS18nquIZBkYRZ1QSeE1ztaOZYQlO+Sx
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9243
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 05 Dec 2023 06:53:57 -0800 (PST)

On Tue, Dec 05, 2023 at 03:14:09PM +0800, Yan Zhao wrote:

> > I would like to remove IOMMU_DEV_FEAT_IOPF completely please
> 
> So, turn on device PRI during device attachment in IOMMU vendor driver?

If a fault requesting domain is attached then PRI should just be
enabled in the driver

Jason