Subject: Re: [v4l-dvb-maintainer] [PATCH 1/2] ivtv: Some general fixes
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: v4l-dvb-maintainer@linuxtv.org, Richard Knutsson <ricknu-0@student.ltu.se>,
       linux-kernel@vger.kernel.org
In-Reply-To: <200712022049.33601.hverkuil@xs4all.nl>
References: <20071202173329.15374.4223.sendpatchset@thinktank.campus.ltu.se>
	 <200712022049.33601.hverkuil@xs4all.nl>
Content-Type: text/plain; charset=utf-8
Date: Mon, 03 Dec 2007 09:52:08 -0200
Message-Id: <1196682728.6027.47.camel@gaivota>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1213
Lines: 31


Em Dom, 2007-12-02 às 20:49 +0100, Hans Verkuil escreveu:
> On Sunday 02 December 2007 18:46, Richard Knutsson wrote:
> > Fix "warning: Using plain integer as NULL pointer".
> 
> Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
> 
> > Remove a gcc-2.95 requirement.
> 
> NACK! The main v4l-dvb repository that contains this driver can also be 
> compiled on older systems. I'd like to keep the option that the driver 
> can be compiled with an older gcc version, unless Mauro thinks 
> otherwise. Other than the removal of one comment and one space there 
> are no other benefits of this change, so I'd prefer to keep it.

>From my POV, I don't see any reason to remove the required space to keep
gcc-2.95 compatibility. 

The required extra whitespace is a small CodingStyle violation, but may
help to use the same driver code for systems that still use gcc-2.95.
So, it seems valid to keep this whitespace. Besides that, it is properly
commented.
 
Cheers,
Mauro

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/