Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Tue, 5 Dec 2023 09:19:21 -0600
From:   Nishanth Menon <nm@ti.com>
To:     "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
CC:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "donald.robson@imgtec.com" <donald.robson@imgtec.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "sarah.walker@imgtec.com" <sarah.walker@imgtec.com>,
        "kristo@kernel.org" <kristo@kernel.org>,
        "vigneshr@ti.com" <vigneshr@ti.com>,
        "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "mripard@kernel.org" <mripard@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am62-main: Add GPU device node
Message-ID: <20231205151921.orba632qpuf2nmxf@wildness>
References: <20231204121522.47862-1-donald.robson@imgtec.com>
 <c20b213534667337f08b75a6c325fafec6526135.camel@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c20b213534667337f08b75a6c325fafec6526135.camel@siemens.com>
Precedence: bulk

On 11:15-20231205, Sverdlin, Alexander wrote:
> Hi Donald, Sarah et al,
> 
> thanks for the patch!
> 
> On Mon, 2023-12-04 at 12:15 +0000, Donald Robson wrote:
> > From: Sarah Walker <sarah.walker@imgtec.com>
> > 
> > Add the Series AXE GPU node to the AM62 device tree.
> > 
> > Signed-off-by: Sarah Walker <sarah.walker@imgtec.com>
> > Signed-off-by: Donald Robson <donald.robson@imgtec.com>
> 
> powervr fd00000.gpu: [drm] loaded firmware powervr/rogue_33.15.11.3_v1.fw
> powervr fd00000.gpu: [drm] FW version v1.0 (build 6503725 OS)
> [drm] Initialized powervr 1.0.0 20230904 for fd00000.gpu on minor 0
> 
> In general it allows the driver to be probed on TI AM625 EK, so
> Tested-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> 
> But I'm not sure if you maybe want to disable it by default like
> other HW blocks for the (potential) boards which don't have video at all.

There is no board level dependency for GPU, so only place we have
permitted status = "disabled" is when the node has specific board
interface level (pinmux...) to  be operational completely.

So, no, default shouldn't have a status = "disabled".

> 
> > ---
> > ?arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 9 +++++++++
> > ?1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > index e5c64c86d1d5..4338fd8ab2d7 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > @@ -965,4 +965,13 @@ mcasp2: audio-controller@2b20000 {
> > ????????????????power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
> > ????????????????status = "disabled";
> > ????????};
> > +
> > +???????gpu: gpu@fd00000 {
> > +???????????????compatible = "ti,am62-gpu", "img,img-axe";
> > +???????????????reg = <0x00 0x0fd00000 0x00 0x20000>;
> > +???????????????clocks = <&k3_clks 187 0>;
> > +???????????????clock-names = "core";
> > +???????????????interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> > +???????????????power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
> > +???????};
> > ?};
> 
> -- 
> Alexander Sverdlin
> Siemens AG
> www.siemens.com

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D