Date: Mon, 03 Dec 2007 22:45:46 +0900 (JST)
Message-Id: <20071203.224546.35471256.anemo@mba.ocn.ne.jp>
To: giometti@enneenne.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: heartbeat for leds on i2c bus
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
In-Reply-To: <20071203103557.GT10305@enneenne.com>
References: <20071203103557.GT10305@enneenne.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1061
Lines: 24

On Mon, 3 Dec 2007 11:35:57 +0100, Rodolfo Giometti <giometti@enneenne.com> wrote:
> If I try to use the heartbeat trigger I hang the system... I suppose
> it is due the fact the led_set_brightness() function is called inside
> a kernel timer.
> 
> How I can solve this problem? I thought to modify the trigger adding a
> kernel thread who manage the led which in turn is controlled by the
> kernel timer. It could be the right solution?

Yes, the heartbeat trigger driver assumes brightness_set() routine can
be called from timer.  Other led-triggers also have this assumption.

So I'd suggest using workqueue for your led driver, as like as the
leds-gpio driver.  Or you can just use the leds-gpio driver and
implement the gpio interface (gpio_set_value_cansleep) instead of the
led interface.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/