Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp378786rdb; Tue, 5 Dec 2023 07:55:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqQZ+SaUGxk6I+gPQD4ptrM41rn7UDUI01lqxtYAppZdACYgOd2fTcpEh3rl2zQt4FdFhV X-Received: by 2002:a05:6870:658f:b0:1fa:fb5a:19da with SMTP id fp15-20020a056870658f00b001fafb5a19damr6960053oab.32.1701791702619; Tue, 05 Dec 2023 07:55:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701791702; cv=none; d=google.com; s=arc-20160816; b=C6GoM8Fqv5LKlhMGxqtCFwQFNOXKjsnsZYZ+F6nn7M3HkUGXIpb96S06bMFJNZ+d9p r6kQRKFDZgIhgT/GxDWUAdMAj+pb9uzFiopwFSqnOVlXf3Dlmp56nkUJj9Hi5QPm6nd2 HbH1f9+vy0y+2qyAnEHmuQHa5E9oG8JQBG7Ct8h81vdLFZznUFnYuMMiIEy0LeOdpp/e xAln/fp4cbGWt2g1CMDs17p3RREGRNkSdjO0gyxhbwAEFLIh6RZfkPpmoRbP7u2yIaND G4J/4jKDhWatO98Ck6I6TJFq7KQSq9VBimrWGt5amiihaPFitCS9M+ACm4a6OWQDozj+ x4ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6EFXXMtI8hRL+NN/MbTo+S3d0DsQDxu2iYKNnKnKBac=; fh=DQJFzYhDw7s0aDcP4xCXMnXDV+wvgCJQmGzbcu5VG4A=; b=IC1jgYZcm5L/r3drV6/iFtZahy61NnEZYbKReODa6JYZFU6zpElk/cBuR8ImN4NDEG CODpYplVHJvtr0qjalEAylXnJ8eJIMgfTd7ylulEfUIBq/dMYfwtNBSXXrSAK5CHHIOQ xJuY/YLw8ezpLGSQKeFnwme4KOkik+FiTD/SZjPMDJjaiYsG+FGgMG7LeQG9YCe9X8AY 1nOIvMYLLu0mY3U5Mz6PqB9PRTz23sYzexjNA4JRvFJRw/9/wTDtNSkNoM3CRqCM2H42 AjVwuSzWmWDbpVv5zgbgzU1yfzXjYseioJHcTOy3/ePWfmUbv4N0YqeYTtauKrw49zOj omtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dRgmc4Xm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id t13-20020a92ca8d000000b0035d4e1e91dbsi965869ilo.34.2023.12.05.07.55.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 07:55:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dRgmc4Xm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id EF8CA80DA376; Tue, 5 Dec 2023 07:54:59 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442505AbjLEPyo (ORCPT + 99 others); Tue, 5 Dec 2023 10:54:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346918AbjLEPyn (ORCPT ); Tue, 5 Dec 2023 10:54:43 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16207D3 for ; Tue, 5 Dec 2023 07:54:50 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FA5EC433C7; Tue, 5 Dec 2023 15:54:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701791689; bh=o4aVIuxjrPEXq7MUNeoMQrjgq/QwX2+q3NVUago8P7Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dRgmc4XmccVhcTfMfbDmDehBpfSndSKD/y93zlELkc5mWZiKKovHFS3gWclmxXVIy hZEI2z6LQK8m+cCfbjUlGDqAa/y9XMPoyKOszXOZQbz12D+ubBvBzAYDhwZCdqk8ir jZmw7iPfYEayqp7ormZgukPAeck0Q0Mx8qnDPfDOu/B31JUC2HYxSIKujZkzwszZGu cwD62+lDx4Ccb4CQNig2XqPubnDuBMrTVt/Wg2RsUPW4ZohUJWMI+bvpGeTV6k0nyy LusVQ4WkTjrlV8H+o1KEPGx+ADPDOut+I09KhEOyeEokMw8RRFYciqvOvc9dv4ipn0 TCg8Z1eAYbQUw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 3CDEB40094; Tue, 5 Dec 2023 12:54:47 -0300 (-03) Date: Tue, 5 Dec 2023 12:54:47 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ian Rogers , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Nick Terrell , Kan Liang , Andi Kleen , Kajol Jain , Athira Rajeev , Huacai Chen , Masami Hiramatsu , Vincent Whitchurch , "Steinar H. Gunderson" , Liam Howlett , Miguel Ojeda , Colin Ian King , Dmitrii Dolgov <9erthalion6@gmail.com>, Yang Jihong , Ming Wang , James Clark , K Prateek Nayak , Sean Christopherson , Leo Yan , Ravi Bangoria , German Gomez , Changbin Du , Paolo Bonzini , Li Dong , Sandipan Das , liuwenyu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Guilherme Amadio Subject: Re: [PATCH v5 08/50] perf record: Be lazier in allocating lost samples buffer Message-ID: References: <20231127220902.1315692-1-irogers@google.com> <20231127220902.1315692-9-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 05 Dec 2023 07:55:00 -0800 (PST) Em Sat, Dec 02, 2023 at 03:56:48PM -0800, Namhyung Kim escreveu: > On Thu, Nov 30, 2023 at 10:29 AM Ian Rogers wrote: > > On Wed, Nov 29, 2023 at 6:09 PM Namhyung Kim wrote: > > > To minimize the allocation size, this can be > > > sizeof(*lost) + session->machines.host.id_hdr_size > > > instead of PERF_SAMPLE_MAX_SIZE. > > > > Sounds good, should probably be a follow up. The current size is > > PERF_SAMPLE_MAX_SIZE. > > Yep, I'm ok with having it as a follow-up. > > Acked-by: Namhyung Kim Thanks, applied to perf-tools-next. - Arnaldo