Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp379692rdb; Tue, 5 Dec 2023 07:56:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IFsiOCMR7kPu+b+lvu48ZBRZfepC8TqjHE8/3E7esv9K2fVi0EkoCbDXrOBLg4pfFFWV2Se X-Received: by 2002:a05:6214:2aa2:b0:67a:4933:1479 with SMTP id js2-20020a0562142aa200b0067a49331479mr2289506qvb.4.1701791792414; Tue, 05 Dec 2023 07:56:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701791792; cv=none; d=google.com; s=arc-20160816; b=wKwxiXjimcqb3F7OIfNRkDilM6wjINwGBlTul+73ofOHNGBJB1EojlRyZX0twI19GC fychjnyuusP/Dv/NhiIeJ7yybkH/djGbzN5rcZk+PKPFYEfj9JpHkxY7fttBNHzeMP6J ezhfnQkwMdU7QXyV18EbeJjTSlwujxu3TD3qikUG4vCh9oOkgjUi9L9Vjf0273J4+h2+ SlVCqPEqfMS7oRPn1vHMVhn7sPdDhEtBY8B+DPfI1Zb9t6dS0BY9gaIWTvLIET4Jwnfj zv+jMnz52wvVxTmio5NQs7F7990zqRBnMpFl0Vu3vIKJ2tCkewUT7znfa4g88ctHJFK5 zNiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RJRnFHmsIh5l3yBg9s0L1COB2bLiMSTofQttcKJJTcI=; fh=jbH4EzgDLZdTEIe7S3ys99vKGCfzMeshChcqwxuqYV0=; b=lVWz3kTk700EBdD7pfAe0vfrCXd2Of+XhifbE5JOTTRO2a9/gcflENFlpj6oLA3g9A 8BRdeGxzXlP+L89DYEycuFOfmXYdmyOsvxHz1QT1HHkhsrITCxgnbp4MvPYPizND8MSl 7gJyptZ8aQSEiu94hOQYsSRFv1jXNsI3ojZ4ymcV+M5KSThzM5MpHE/hk08GpMxb4tsI oIflhOTVzlXdfjTTjpxTwQPx06gwClWhfn15zEJmvCQ36exIDTXm7t5b7CKG0gkhH+GW GrZ4GGYu2Z2Aj8MfGBHbpwtVuKbTLtbSIR+xkB16p5BidoeJGSpcXv7JoTGirJqIV5s8 mqDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="Zi/EE8zE"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id gg5-20020a056214252500b0067a1d390340si7529472qvb.120.2023.12.05.07.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 07:56:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="Zi/EE8zE"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id B8822807C659; Tue, 5 Dec 2023 07:56:17 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235514AbjLEPzt (ORCPT + 99 others); Tue, 5 Dec 2023 10:55:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346919AbjLEPzq (ORCPT ); Tue, 5 Dec 2023 10:55:46 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00EDDBA; Tue, 5 Dec 2023 07:55:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701791753; x=1733327753; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=cjRwytJeG5TG/a1uu/+8HD2/PFh3IJgfHgcnXENi5L4=; b=Zi/EE8zE7wIrMMRuoTqGM8QHnI520S3SS4Uobg8JvU69nvxkW/xovV8p MjBHoWmsmVFDwWkGzzyO4pKoBLDLd+FDoogxwsJ2UZAiAUOgmPnuWIakr Dzirc0MELP9gxe9r7oMFc7qnGFL+F9ncsqsI+uAdCE9AcTLFxpg/85YFd 4kIgso5mOGEUoFfAoe4C4f8u5Ru8DJmIftRLzYBbk2WAnNZfNo6VKFbHQ eAtfxCoiuGoQo4f1fJbedvC+7WD0aHXng5w0JWwwDoE7x4JRh5safvC98 Dkj7x1nHeY5M2nQbrYzdpjTLh3fikC2k9dnGDD8e/qwCsWXS7G+WI5hoj g==; X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="7259414" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="7259414" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 07:55:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="861786429" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="861786429" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 07:55:49 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rAXly-000000024rT-06ck; Tue, 05 Dec 2023 17:55:46 +0200 Date: Tue, 5 Dec 2023 17:55:45 +0200 From: Andy Shevchenko To: Dawei Li Cc: Ilpo =?utf-8?Q?J=EF=BF=BDrvinen?= , Greg Kroah-Hartman , Jiri Slaby , jszhang@kernel.org, LKML , linux-serial , set_pte_at@outlook.com, stable@kernel.org Subject: Re: [PATCH] serial: dw8250: Make DLF feature independent of ADDITIONAL_FEATURE Message-ID: References: <20231204130820.2823688-1-dawei.li@shingroup.cn> <48f6fcce-4b5-a7c0-2fc0-989b9a2fba8@linux.intel.com> <6863B74199951BD2+ZW6DIO1n0phYBjg9@centos8> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6863B74199951BD2+ZW6DIO1n0phYBjg9@centos8> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 05 Dec 2023 07:56:17 -0800 (PST) On Tue, Dec 05, 2023 at 09:55:44AM +0800, Dawei Li wrote: > On Mon, Dec 04, 2023 at 03:29:35PM +0200, Andy Shevchenko wrote: > > On Mon, Dec 04, 2023 at 03:20:09PM +0200, Ilpo J?rvinen wrote: > > > On Mon, 4 Dec 2023, Dawei Li wrote: ... > > > The very same code change is already in tty-next (from another author). > > > > For your convenience: > > > > d804987153e7 ("serial: 8250_dw: Decouple DLF register check from UCV") > > [sigh] > > Apparently I thought tty/for-linus is the "bug fixing" branch for tty by > mistake, and didn't realize the same fix patch has been landed in tty-next > for a while. > > Thanks for the update. > > Anyway, I believe the fixing patch should cc stable and be getting backported? > I hit the bug on 5.10.x, it's possible the bug has been there before that. When that commit meets upstream you can always resend it for stable. The process is documented. -- With Best Regards, Andy Shevchenko