Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp392889rdb; Tue, 5 Dec 2023 08:12:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IFEBh3JUNNC24wHYz49A9GDodQm4TaFa7a6+pV1vEOJsmN3vP2saDuu34DSKSWR0jvtZeeq X-Received: by 2002:a05:6e02:1d04:b0:35d:64b5:a963 with SMTP id i4-20020a056e021d0400b0035d64b5a963mr7485982ila.25.1701792744026; Tue, 05 Dec 2023 08:12:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701792743; cv=none; d=google.com; s=arc-20160816; b=F6d/m4HAVK4RonZaAJSRaeYEXUflPAJye1T9QZguj6rtIib7rigHDgG0wtDy1Q8k1a LZ3KrYLFZkegKkNA5vWfWVEIBYnEZruFlZO9UcrbULGDfie/4Wu/GIOPAjrOmwUV3YtP UsOK/MWyPl3/DD20INQfRwG0Hg96gloxEZ2f80C/G9us3lL77JpVKmRZaJNdeIuo3p+d 5w4QIRuydH4TgfXDYh/5NSuxq1Cxg3Z7371NxiuAT7zt/8M8RYIUURLzg3/gsFoUiZRE WlEK/ycd7+O1DamUhuRVsQj1JNlucgccsOXY/WPjUI2vMgt6cU/uIZp+shsrAs3jLdJP yC2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=qY1LMRShQos4cOUj5m8nrwBWGW3c+E6CbPk+tSDN93I=; fh=z7dP0sUsXLtnomzA6+FUC3zkdfBao0VqwDEfI89QmpM=; b=D22db3VgQZjoHUjAXY9d2FpteoUE2ZiJ5+hP5VhqBhbb/d0MTiZw0TKMGrrx+jUfWD bEbYKucIuXwRRSSsby1phnv1Atz/dPsbwodFRpPKksVJuoa8ibsHKEzxDnK4/VQ0YOGP Gw8oRmxb9IG28tWNOqBbzQN+Di/7Ztom7jW0CWYzBJlsQlLDZeXO6kzl6E2oIz5koIDO EHS/DZxV9Ps++qR1qSgwEwhKxuSQFuWV/aXQGjKAUXPA/dtMCnMoDcs6iv+uCExmBvJO K2tBfpvmhCa+JBEVV4zhwcOE8hLCA1bzZcAaX0rUM6qiwgNZAsR/Zo1ZdVxk7aFnj9o5 SKKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fOCIUyOy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id i4-20020a63cd04000000b005c663eae37asi5680534pgg.252.2023.12.05.08.12.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 08:12:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fOCIUyOy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 7631A80789FA; Tue, 5 Dec 2023 08:10:28 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345077AbjLEQKF (ORCPT + 99 others); Tue, 5 Dec 2023 11:10:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231929AbjLEQKC (ORCPT ); Tue, 5 Dec 2023 11:10:02 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D850197; Tue, 5 Dec 2023 08:10:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701792608; x=1733328608; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=9VlXC9T0HJrRA8I/AjcRFH7MOmlq9IpZCfivuySrewU=; b=fOCIUyOyTlLx/fc3rdBbjdpBrUu4NQHGbX3+2SksLvlGwXkfZ7JYmCX2 7n7MneTLdbeYcTCTUfOfOZmOWDFAyqkmLvSpNm4BQ+M7NYpEsTc+q4bGr x3FeqVnvHTdiC4Tl8dqYE8cjN7q0o19AOWRGPoLyEkdUkQt5PAel26OY/ n1ong6QDEdAWIeom7bEt3I9UPR4l/nQLxbXmOO1OmkOeSwSghvWzels3N UfvKKcaGC/vfUE56MlF7OPTrCn/H86iFuMDiOcRYNBsofkWvMyzkTKgmE kzMdWcKF59i88ObRKeYXTTkHUpEzZw92W8c3o6swwjoWWmUC3a89g2rrq g==; X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="392780281" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="392780281" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 08:10:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="888992817" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="888992817" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 08:10:04 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rAXzk-0000000251u-3cM9; Tue, 05 Dec 2023 18:10:00 +0200 Date: Tue, 5 Dec 2023 18:10:00 +0200 From: Andy Shevchenko To: Tony Lindgren Cc: Greg Kroah-Hartman , Jiri Slaby , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , "David S . Miller" , Dhruva Gole , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v4 4/4] serial: 8250: Add preferred console in serial8250_isa_init_ports() Message-ID: References: <20231205073255.20562-1-tony@atomide.com> <20231205073255.20562-5-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 05 Dec 2023 08:10:28 -0800 (PST) On Tue, Dec 05, 2023 at 06:08:37PM +0200, Andy Shevchenko wrote: > On Tue, Dec 05, 2023 at 09:32:36AM +0200, Tony Lindgren wrote: ... > > + pr_err("Could not add preferred console for %s idx %i\n", > > + serial8250_reg.dev_name, idx); And, btw, you can simply reuse name here pr_err("Could not add preferred console for %s\n", name); Would it work? -- With Best Regards, Andy Shevchenko