Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp394241rdb; Tue, 5 Dec 2023 08:14:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IGrt6OVqg1Rn2cBnI/KBsl5zmND7tsI1lmRFoqB8zwp8VuUryy++3XjkIYdklQ3nkOY2gus X-Received: by 2002:a05:6a20:5497:b0:18c:4105:9a9b with SMTP id i23-20020a056a20549700b0018c41059a9bmr4570309pzk.12.1701792864821; Tue, 05 Dec 2023 08:14:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701792864; cv=none; d=google.com; s=arc-20160816; b=bIuCm2Kdhz0GOhCOTa8gnHz2SyJc8bgIiaxnVefuRWbKJnDWDtuBlkPsL/iuU3LtQ8 eBRiV8tVO7NNtkg8SKfrm3OhdCetP8h7ls4kH4k639TcZKL/afW4T1/GXtQlq5cq8gZ2 VOnI/+Ridtk+LVRiVo0L9vY0Rtjyd50hM2Fp7ftw8hTIWXJ6UgdqCZdPJZuXjzuNLz9h Szpx7gpgetkdQrF+BOMqtDCWZPSsIPn1ZCuTH781zp3XkqZsyvbEww1kA/YZA9Fd+FDl nFugCss1k/h+eyu9U1fshzn5z01W4C6Q/VEchcjXpMv2GLtUXzUl9bnUEd+pQfwDX966 tU9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sZ6cQwR1CSTknBvlXMd0N0DciK+IOZpOKGbLnNlOj9o=; fh=oo99/BGMiDT1fXBO4nTKfJaus5S+Q1V7xPQRARghon8=; b=zR0JRTPD0YgV8qhyMHwK1MD5blFPaY4kGLb5VYg/nEhnBXqh/2XcYvtHYAGm0Dr+vf FcbATgAovQRO5MCtLs4TfG6U2rs4WPqd0eLIkKDQ+ecUN50VJ5rV5C+o54qNKecAC9O5 SK9LVGrWN8LRsxUmB86cG2Gf1qcpGB7aA8GvZkZCJccporaMqcOg1fyUemeUD6KpuOaz 3AY7SHvwWoGemCt8K0FUzz4X4DpuB+/e68cj0RPlKIKRelzKNqN7kWFd6YPoMhwI7+I7 qI6FD2ovja9UO0nFpYy40gp2xJZrNAWPQHt1EDT2szCbQYzPig9uPpURC/MijmGYb3Pf udDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="CkA/wmYS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id pg2-20020a17090b1e0200b00286ab9c716fsi3698115pjb.104.2023.12.05.08.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 08:14:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="CkA/wmYS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 45917804238C; Tue, 5 Dec 2023 08:14:10 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231888AbjLEQNz (ORCPT + 99 others); Tue, 5 Dec 2023 11:13:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231920AbjLEQNy (ORCPT ); Tue, 5 Dec 2023 11:13:54 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFC4B9E for ; Tue, 5 Dec 2023 08:14:00 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BAF4C433C9; Tue, 5 Dec 2023 16:13:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701792840; bh=ru2Yf4e2J+5cS2zc1QOY6JOr4Q5ZMrCeka8oIoe8iAc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CkA/wmYSZZ4ekKAvd12zaT1b3VgxWrPSB/VMN5QvQQzuZh5GoehADzQVGrABSmUSk sqC5OV922UTccz+YnMFpwCqWyosrrjhxs/x1f9D8H1rC+l//ey1XblksBplk4noFlW L4bEs0arekh5l8tGAYd4ntf5ToSKcq+roU6Qio2IOWLj7CT0AN7QYsQbOmTvmmdGC4 BtjnuhDMjHv2B9o/L68tLpHFRhJkeo8sss+Bdw3zg1G1VYErimy8vCMU3U2xuZvy4a 2a6qKqavUaKIc+43DCIN3mWIl1Jup8yT6SBNig59OTvIV1H20NHiLDhxyiLaVSmjeb Brc52So+XpBiA== Date: Tue, 5 Dec 2023 16:13:55 +0000 From: Mark Brown To: Pierre-Louis Bossart Cc: Gergo Koteles , Shenghao Ding , Kevin Lu , Baojun Xu , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 2/2] ALSA: hda/tas2563: Add tas2563 HDA driver Message-ID: References: <4a2f31d4eb8479789ceb1daf2e93ec0e25c23171.1701733441.git.soyer@irl.hu> <90765ee0-a814-4852-9b2a-020cda98d930@linux.intel.com> <974d41f6c703d9b65ebcd75a2c659cecf13bd877.camel@irl.hu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GodoWbeZVkkSioJV" Content-Disposition: inline In-Reply-To: X-Cookie: I've Been Moved! X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 05 Dec 2023 08:14:10 -0800 (PST) --GodoWbeZVkkSioJV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 05, 2023 at 10:01:08AM -0600, Pierre-Louis Bossart wrote: > >>> +static const struct dev_pm_ops tas2563_hda_pm_ops = { > >>> + SYSTEM_SLEEP_PM_OPS(tas2563_system_suspend, tas2563_system_resume) > >> where's the pm_runtime stuff? > > The amp stores its state in software shutdown mode. > > The tas2563_hda_playback_hook wakes/shutdowns the amp, not the > > pm_runtime. > My point was that you have all these pm_runtime_ calls in the code, but > nothing that provides pm_runtime suspend-resume functions so not sure > what exactly the result is? It *could* be ACPI doing something I guess... --GodoWbeZVkkSioJV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmVvTEIACgkQJNaLcl1U h9By3Af/UZHQo24BocMAB4/saETBOo5GGwsh7kVw55UIvFTRy65mXMVBsOnLmP3J x6TBjezeo/Zi6COh1+dtdzCfO2wEA5j6sW95WMvsIlj6Z1rpwKIfPTk4kXI7GxIz a3I/9acM3/W6UZizagHBWXK0QgQuCi/fL/1aVh8VYwCGKi+5MOQxNftGfiYrXpJh X4V8p+vTxR+ex/CRNi6lgrM2vEnk9fFfhAesugBjCN+J1KJ2gPO1oL+5SiHf/sJ/ rjOebOBFlzOru4UhBUjaTSXCOoVFpgJ2eoimKQzmtgo4pHq1TmTKWlSYEo45wk4p QKIq5JCEqxA4Vl2tZ/3/KNmkckGbAw== =x4+9 -----END PGP SIGNATURE----- --GodoWbeZVkkSioJV--