Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <0a5f769e-a474-40c6-a886-135716e90dd2@quicinc.com>
Date:   Tue, 5 Dec 2023 22:18:07 +0530
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v3 0/3] Ethernet DWMAC5 fault IRQ support
Content-Language: en-US
To:     Serge Semin <fancer.lancer@gmail.com>,
        Andrew Halaney <ahalaney@redhat.com>
CC:     Vinod Koul <vkoul@kernel.org>,
        Bhupesh Sharma <bhupesh.sharma@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        <netdev@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        Prasad Sodagudi <psodagud@quicinc.com>, <kernel@quicinc.com>
References: <cover.1701695218.git.quic_jsuraj@quicinc.com>
 <rw5vfdvre5rt4rwytfsp3qy6sgsdr3dm6oefr4sap2aqbvpw42@c2dxz42tucby>
 <zzkw5obc3z5fndowmrycy77gtjf6wscvkj7klnn34f3ycs3her@hmh5aebpbi3s>
From:   Suraj Jaiswal <quic_jsuraj@quicinc.com>
In-Reply-To: <zzkw5obc3z5fndowmrycy77gtjf6wscvkj7klnn34f3ycs3her@hmh5aebpbi3s>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi @serge,
there is some more DT_CHECKER warning & need to fix that before uploading the new patch .
Will fix the warning & then will update the version ,

Thanks
Suraj

On 12/5/2023 3:35 PM, Serge Semin wrote:
> Hi Suraj
> 
> On Mon, Dec 04, 2023 at 02:16:12PM -0600, Andrew Halaney wrote:
>> On Mon, Dec 04, 2023 at 06:56:14PM +0530, Suraj Jaiswal wrote:
>>> Add support to listen Ethernet HW safery IRQ. The safety IRQ will be
>>
>> s/safery/safety/
>>
>>> triggered for ECC, DPP, FSM error.
>>>
>>> Changes since v3:
>>
>> This is listed as v3 in the subject, but it should now be v4 since the
>> last version was v3.
> 
> There are several style-type problems I would like to share. But as
> Andrew correctly noted the series version was incorrectly left
> unchanged. Please resubmit the series with the version incremented.
> I'll send my comments to that new thread so the discussion history and
> the lore archive would look cleaner. Thanks.
> 
> -Serge(y)
> 
>>
>>> - Fix DT_CHECKER warning
>>> - use name safety for the IRQ.
>>>  
>>>
>>> Suraj Jaiswal (3):
>>>   dt-bindings: net: qcom,ethqos: add binding doc for safety IRQ for
>>>     sa8775p
>>>   arm64: dts: qcom: sa8775p: enable safety IRQ
>>>   net: stmmac: Add driver support for DWMAC5 safety IRQ Support
>>>
>>>  .../devicetree/bindings/net/qcom,ethqos.yaml   |  9 ++++++---
>>>  .../devicetree/bindings/net/snps,dwmac.yaml    |  5 +++--
>>>  arch/arm64/boot/dts/qcom/sa8775p.dtsi          | 10 ++++++----
>>>  drivers/net/ethernet/stmicro/stmmac/common.h   |  1 +
>>>  drivers/net/ethernet/stmicro/stmmac/stmmac.h   |  2 ++
>>>  .../net/ethernet/stmicro/stmmac/stmmac_main.c  | 18 ++++++++++++++++++
>>>  .../ethernet/stmicro/stmmac/stmmac_platform.c  |  9 +++++++++
>>>  7 files changed, 45 insertions(+), 9 deletions(-)
>>>
>>> -- 
>>> 2.25.1
>>>
>>
>>