Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp425802rdb; Tue, 5 Dec 2023 09:04:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSaDFAgFznEJK/+ZEhMyICCKsFm76jnfAwuRllmzdem1QoVrvMvJKyPsjM918TfEzFeWfV X-Received: by 2002:a17:90a:fe06:b0:286:96bf:53e7 with SMTP id ck6-20020a17090afe0600b0028696bf53e7mr1491937pjb.89.1701795855213; Tue, 05 Dec 2023 09:04:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701795854; cv=none; d=google.com; s=arc-20160816; b=hg26a1YIlSSrWh7b6WrSYrS3RM8tjVLw5zA1l83X61VVmjXW2fZ524zauCxFL3Qno5 Tt5RFNpe7FIgkt3HM1WuTOe+fgUOdz/uYz/lw+kdKaCx13WjPqrnm1U/9V/4525AnQlt xY+PKhpS93Rls2/sjZWkmihnwZXTtyrxDo6W4zDwsGq3qccwV2yhITuHTzR0az4H7IxH H1wIRh0h7ceIdEj3O3HK106yKKfTYlHDabbyM8lcYtWN/tWuuTpJNto+0Dun4jK9CvBr LaSWJKnFOHf2gvMxW9kycRNuilYO71Lax4O+eAuJFj3grXCzzVgfekPDmGNeVE1LFoJe KncQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=5Kxt6CKccKyM2aD5KqaYbJ+5NRAtsSu20TdTe87tfro=; fh=SqofucVUnLjGMGSwbPza5I40H5BCVHGKOfcDxW3ckZA=; b=RugQYGXTKaKcXC4wGspzniSQ8OGA8xq6eqAGMTxgDz1bhJQ739e119Oqh1oDazPOXo EKZPlmc29f2f90P++SDPQhZCMCJqiDxKlyxZ1sixwECNA5YtodLjxvI4y3bSn4Z50MFn +h+bT9YfX2wCwNwoFlgbFJJsBfx6NJNJAZk3n8FRoiW3OTFq2D8LeuHJj3DKWiOxa4ht kIBxaZCyb3s8KLEN9eD3tWODhqZotWuFU9JoOzWwMCjnvzli8htUwH5nGArSVyHTv0fR GF7Umj4jtC7Feq2OhDrUMLD0XkaraUtarlyryMDucOZqFkcbN5utinYV8oNcw8njdUo/ CC8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id mi2-20020a17090b4b4200b0028023efb800si3825007pjb.18.2023.12.05.09.04.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 09:04:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 656C58042003; Tue, 5 Dec 2023 09:04:07 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345169AbjLERDu (ORCPT + 99 others); Tue, 5 Dec 2023 12:03:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232086AbjLERDt (ORCPT ); Tue, 5 Dec 2023 12:03:49 -0500 Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CBD9A1; Tue, 5 Dec 2023 09:03:55 -0800 (PST) Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-58ceab7daddso2484286eaf.3; Tue, 05 Dec 2023 09:03:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701795835; x=1702400635; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5Kxt6CKccKyM2aD5KqaYbJ+5NRAtsSu20TdTe87tfro=; b=gC36X4NARMJFnoLUNZ6eIGcjEc1l5871SjthUiIspKmoaHf1kKjnlSO/V046uFgT2E ANpe+rE5YEEqD2ycQzEEJ2mRgqdkimd665BviZzZGLt00siu1fKb6fMq6SofmFtGR9Px /zZsUIDflXJhqBv7j8JhsaId5oPThrEeECQf5cm+TU/s04ZWVnfKzi3t9ivWG7FV5IV7 HAKl0s0DEmaS9cO/6BzT6PWwXhne8jh6A1fDwzLnkdgkZjOzP56x2wDgqZCl+pc1x+lZ w4m5sa7rw0F01s7QLkdN9wIPpD6NKIHh+cJB34LW3DHrhW2juZF4rQu33NAJsvjscxVW LC8Q== X-Gm-Message-State: AOJu0YyRYu6XQo6MkLfAFga6iBIY3nm9gjjsFU1upk6OFnZLq5EGsGF2 MNkzx2aSUSOJ7Mqx2nFdsWg= X-Received: by 2002:a05:6358:6f95:b0:16e:43a1:6881 with SMTP id s21-20020a0563586f9500b0016e43a16881mr2252180rwn.26.1701795834695; Tue, 05 Dec 2023 09:03:54 -0800 (PST) Received: from [172.20.2.177] (rrcs-173-197-90-226.west.biz.rr.com. [173.197.90.226]) by smtp.gmail.com with ESMTPSA id s25-20020a639259000000b00578afd8e012sm5146562pgn.92.2023.12.05.09.03.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Dec 2023 09:03:54 -0800 (PST) Message-ID: <189fa9b2-bcc8-4839-ac04-33a29bba9aaa@acm.org> Date: Tue, 5 Dec 2023 09:03:48 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next RFC 01/14] block: add some bdev apis Content-Language: en-US To: Yu Kuai , axboe@kernel.dk, roger.pau@citrix.com, colyli@suse.de, kent.overstreet@gmail.com, joern@lazybastard.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, sth@linux.ibm.com, hoeppner@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, jejb@linux.ibm.com, martin.petersen@oracle.com, clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, nico@fluxnic.net, xiang@kernel.org, chao@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, agruenba@redhat.com, jack@suse.com, konishi.ryusuke@gmail.com, willy@infradead.org, akpm@linux-foundation.org, hare@suse.de, p.raghav@samsung.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, gfs2@lists.linux.dev, linux-nilfs@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com References: <20231205123728.1866699-1-yukuai1@huaweicloud.com> <20231205123728.1866699-2-yukuai1@huaweicloud.com> From: Bart Van Assche In-Reply-To: <20231205123728.1866699-2-yukuai1@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 05 Dec 2023 09:04:07 -0800 (PST) On 12/5/23 04:37, Yu Kuai wrote: > +static inline u8 block_bits(struct block_device *bdev) > +{ > + return bdev->bd_inode->i_blkbits; > +} This function needs a name that's more descriptive. Thanks, Bart.