Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp431493rdb; Tue, 5 Dec 2023 09:11:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IGKvYMgsYgdKnhIXJi5KBfqztbGPcx6H49dQKiCF1Ai0D9VlCVVyUVvB+EL7L0bkrccvsT0 X-Received: by 2002:a17:902:a505:b0:1d0:8122:9007 with SMTP id s5-20020a170902a50500b001d081229007mr2997295plq.18.1701796306943; Tue, 05 Dec 2023 09:11:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701796306; cv=none; d=google.com; s=arc-20160816; b=zmFRLYKmxaHvffb1hIUdusRfvkVfi5EqilJsNt4Wlu7ri5KDgvo7EYRKE0Gfmqr545 dm4FdgXTVPbMxA3s+Zp+LVZrcXutJU5lWaWaxdLjPdwD92blX0snNavnIQLCRGnjb6Qo 2+vEtXHBFr6ITkp5oOavYNrxMnu5iJzsa+4m+yni+nubT6sDOY844BO0/jzvp7jrFcEP /+ml0uGxJ/1mBOkM5kI9J86R9PNilfiiCzaQ7BDfbLfdZrFCvRv99ZOu/GS2AWs8xLht ctC/H94bI5krcelJfbX2HU2lUgCCcIrTaTQgtRm9P4AFcW+Ys7WJ82d50UJRCnIyhT+I 2oCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to :message-id:mime-version:user-agent:feedback-id:dkim-signature :dkim-signature; bh=BSHv0HRg2s93B8FPGN2syxnLQruwc1c3RDbBmnf0NEA=; fh=9Q+9YPV2Lq8OFeH9+HG/eSL65Zna5Bfu4bFjn4QgE3g=; b=kbcpz+5im0opHNFm+SCj5Njs7+kRchKIayGXu113vm9bWIDN7CNf9+BicM4IdqKbMO 1iTOXMTm0Ys9LtNilx/ewCBBlLa+7Nji+kYgYlRANBPK8vAHawXZe8TnOe/ccjVCE9Fe pJHGcgpN8s9h5xCZNmdf5Z3YDNXLLkR9d9Ctq6cfmcFfLH7LO+0IsYzyFKmOZ7l+C+yS q/CWuASPfkbt/ExCYU05k0qOyUZeVwEoi/K+aOpVeDaHj6huUbFa1lfc6beerUSQSKRS iA7kqqBwbb9KFhP/HduKmAjalWH8c66tDKTJ8qOg3EI4ahqCW/n5jhrAF0gFSjATiEY1 F2sQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (expired) header.i=@arndb.de header.s=fm3 header.b=u1IX5t1r; dkim=neutral (expired) header.i=@messagingengine.com header.s=fm1 header.b=FcbZZZvk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id b2-20020a170902b60200b001cfb4d36d44si9578310pls.64.2023.12.05.09.11.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 09:11:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=neutral (expired) header.i=@arndb.de header.s=fm3 header.b=u1IX5t1r; dkim=neutral (expired) header.i=@messagingengine.com header.s=fm1 header.b=FcbZZZvk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 456CA80A64CC; Tue, 5 Dec 2023 06:44:19 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345580AbjLEOoC (ORCPT + 99 others); Tue, 5 Dec 2023 09:44:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235514AbjLEOn5 (ORCPT ); Tue, 5 Dec 2023 09:43:57 -0500 Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2B671BE; Tue, 5 Dec 2023 06:44:02 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 442705809BA; Tue, 5 Dec 2023 09:43:59 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 05 Dec 2023 09:43:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1701787439; x=1701794639; bh=BS Hv0HRg2s93B8FPGN2syxnLQruwc1c3RDbBmnf0NEA=; b=u1IX5t1rodixlie6Mp rRUGBkq+57oNX93kpP2WS0tc+JxK4MUExGO2BGRuFejA6BmZqnSeaTZiRIxRStDL PQkXiXRkw9/hqC390WBM1S7CAdB4ZeuRU3fCqjtLTsAzg0iBX74PNC9gWve7FDcT 66Sxd5Ux/KhUHR2sJxHlUdfImBvKyrF1ZoNHQH8Ist/eIHOWwVxqHRD0QDhH9OgY ui1N18qdxTUktEgpWUHksybaxQwrY/oUHRWVZAobZzqMzb2sqZaA2pT+SuyK2mSg d3OVMe+wvWkw9pbnjOPUkws4CeWlZ4kICoKVv29QlJ4H9UZvFrq3ECN/JBDhQTRK umxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701787439; x=1701794639; bh=BSHv0HRg2s93B 8FPGN2syxnLQruwc1c3RDbBmnf0NEA=; b=FcbZZZvkeXMfqqU2ugxqiRbdUcPJ5 ymo1akoaXYdzDU7GzGTPnxzpiOwGl1wu0hJn3v0TqLY7lnrLXpWf8QMm0jsxivaj gBJ3SV+YQz+K9y7x+StZJUm16xqa+k+WorwzZB3lHp3AmYm9bh/IxV1JT5ByY7i9 7sF8GdI5s+08I881coqR/RCg28ZLyeWQWjGLeEWqUIbbYcbEIGm2wFDTNltjQ6pO eRwc6Tzva5UXZ5WVl5FDzUBd0pn4qK8hKXfjmqC9DpQHRh/gzz/LrX0IJo4xnxLc fbSd44UIKgcoYIMwTBr+YpQ4732fj6MYbgUKgJ3Q+ZYU6x0nTnoQqsILQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudejkedgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 66E5AB60089; Tue, 5 Dec 2023 09:43:57 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1178-geeaf0069a7-fm-20231114.001-geeaf0069 MIME-Version: 1.0 Message-Id: In-Reply-To: <8ec1ae92206c090c79a9ab9586bd17349798b08f.camel@redhat.com> References: <20231204123834.29247-6-pstanner@redhat.com> <202312051813.09WbvusW-lkp@intel.com> <8ec1ae92206c090c79a9ab9586bd17349798b08f.camel@redhat.com> Date: Tue, 05 Dec 2023 15:43:36 +0100 From: "Arnd Bergmann" To: "Philipp Stanner" , "kernel test robot" , "Bjorn Helgaas" , "Hanjun Guo" , "Neil Brown" , "Kent Overstreet" , "Jakub Kicinski" , "Niklas Schnelle" , "Uladzislau Koshchanka" , "John Sanpe" , "Dave Jiang" , "Masami Hiramatsu" , "Kees Cook" , "David Gow" , "Herbert Xu" , "Shuah Khan" , "wuqiang.matt" , "Yury Norov" , "Jason Baron" , "Andrew Morton" , "Ben Dooks" , "Danilo Krummrich" Cc: oe-kbuild-all@lists.linux.dev, "Linux Memory Management List" , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Linux-Arch , stable@vger.kernel.org Subject: Re: [PATCH v3 5/5] lib, pci: unify generic pci_iounmap() Content-Type: text/plain X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 05 Dec 2023 06:44:19 -0800 (PST) On Tue, Dec 5, 2023, at 15:34, Philipp Stanner wrote: > Alright, so it seems that not all architectures provide ioport_unmap(). > So I'll provide yet another preprocessor guard in v4. Wohooo, we love > them... Right, I think CONFIG_HAS_IOPORT_MAP is the symbol you need to check here. There are a few targets that have inb/outb but can't map them to __iomem pointers for some reason, as well as more that have neither CONFIG_HAS_IOPORT nor CONFIG_HAS_IOPORT_MAP. Arnd