Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp431970rdb; Tue, 5 Dec 2023 09:12:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IEhatAbAeGf7aLjxWbNTD85zggPgRl6CzdlOfFpQP5PM3b1gJaUt/wLT5qrTkgez71AXcFI X-Received: by 2002:a17:90b:e0b:b0:286:6cc0:b917 with SMTP id ge11-20020a17090b0e0b00b002866cc0b917mr1247748pjb.78.1701796349775; Tue, 05 Dec 2023 09:12:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701796349; cv=none; d=google.com; s=arc-20160816; b=mlMuwGPJho+T1t9OSuO8DXtXlp9mFdl1FhRVrJSW7WhakDXhofogxQL8ahYk3m7Myo js4/ND6werJ5ZVwyq7qk2gCRzPqQGObRLRkHjKr0rlNm5pzgvB291ieTC1EsDzN4Loxp ee/IvQeGjipcEgJXlOe7ayeeG7Tu8geHsSGKhN/LR9vkzLNSS2UpGik6ePMXkiPK22VC VJPvZAZPbAUnwpt8Rzr4Algvmwz9PvZ9tU3/ZW9fZecgPH92XJphop0bg7Ysrg88qL9g EdPBJj1H16dyxU0Sc+nzln/DrJmDbMMvuIjKgOKKNAfas1pCqNGJIzpckSzJz9+rLMTS zHlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=0a7dXaJZWBeRPIyY6a/DzZozCKXJtstEwFuNS+g9HbQ=; fh=9LhKqsVrl1TNvuEqoBMdBZqzVpo12dckkPwL3oxqBhk=; b=DPNtJfLTnxqrFpJ2BOQa9OrqEwK8ww3kSVe2Y7qxlyhw3rncX0X6yCPBTBSVHMDrqF 5BBGugRl79AfJGtnVt7Ncz376YPfqr1XDnuYHQJmFet0PXuaQeNwhIrA6vLYxRbhOY37 Pxx2rdYrkKgHWQFKbSG6D0qQcVUfVUeBwvZjQ1cOW2PaPaeHDYr0/5b8CO4eSCq5+x0a vBCn/Gn9OVCfJN9zednRuLopq1fVvxdfm88KqRkeoJ8PsFDghb+q2tDYaw5VNXkSkl0c Zbb1LvMWce/l7vyqfEhnvrtdDyRMOtuwOoprX7d8JPaOoqDoL5vxnqDJONwIgMpRodJq RgLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id fy22-20020a17090b021600b00285ebeed85fsi4163371pjb.123.2023.12.05.09.12.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 09:12:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 23229807FD66; Tue, 5 Dec 2023 09:10:36 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232145AbjLERKV (ORCPT + 99 others); Tue, 5 Dec 2023 12:10:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjLERKT (ORCPT ); Tue, 5 Dec 2023 12:10:19 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BF1EA1 for ; Tue, 5 Dec 2023 09:10:26 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAYw9-000794-7P; Tue, 05 Dec 2023 18:10:21 +0100 Received: from [2a0a:edc0:2:b01:1d::c0] (helo=ptx.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAYw8-00Dn2f-CA; Tue, 05 Dec 2023 18:10:20 +0100 Received: from ore by ptx.whiteo.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1rAYw8-005QXO-9O; Tue, 05 Dec 2023 18:10:20 +0100 Date: Tue, 5 Dec 2023 18:10:20 +0100 From: Oleksij Rempel To: xingwei lee Cc: kernel@pengutronix.de, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, mkl@pengutronix.de, robin@protonic.nl, socketcan@hartkopp.net, stable@vger.kernel.org, syzbot+daa36413a5cedf799ae4@syzkaller.appspotmail.com Subject: Re: [PATCH v1] net: can: j1939: enhanced error handling for tightly received RTS messages in xtp_rx_rts_session_new Message-ID: <20231205171020.GM981228@pengutronix.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 05 Dec 2023 09:10:36 -0800 (PST) Hi, On Mon, Dec 04, 2023 at 11:25:40PM +0800, xingwei lee wrote: > Hello, Oleksij. > I have reproduced this bug with repro.c I assume, with this patch the reproduce will trigger only warning instead of backtrace. Correct? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |