Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <a173781e-b3b6-47a7-8bda-fb289fd9ffd5@infradead.org>
Date:   Tue, 5 Dec 2023 09:29:05 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: linux-next: Tree for Dec 5 (soc/qcom/qcom_stats)
Content-Language: en-US
From:   Randy Dunlap <rdunlap@infradead.org>
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>
References: <20231205135708.4a5a8413@canb.auug.org.au>
 <50d8f1dd-4df2-446a-bd82-47d96637b507@infradead.org>
In-Reply-To: <50d8f1dd-4df2-446a-bd82-47d96637b507@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/5/23 09:17, Randy Dunlap wrote:
> 
> 
> On 12/4/23 18:57, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20231204:
>>
> 
> on powerpc 32-bit:
> 
> ERROR: modpost: "__udivdi3" [drivers/soc/qcom/qcom_stats.ko] undefined!
> 
> 

Hi,

Looks like this is coming from the use of mult_frac() if I am reading the
generated .s file correctly:

 # ../drivers/soc/qcom/qcom_stats.c:224: 		entry[i].dur = mult_frac(MSEC_PER_SEC, entry[i].dur, ARCH_TIMER_FREQ);
	mulhwu 3,22,4	 # tmp194, tmp190, MEM[(long long unsigned int *)_107 + 16B]
	mulli 9,9,1000	 # tmp185, MEM[(long long unsigned int *)_107 + 16B],
	mulli 4,4,1000	 # tmp3, MEM[(long long unsigned int *)_107 + 16B],
	add 3,9,3	 #, tmp185, tmp194
	bl __udivdi3		 #

-- 
~Randy