Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp462654rdb; Tue, 5 Dec 2023 10:02:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IGzBVBvL355N2Dqd0GKy77SdC/JdFuruhU9CmZpNbXPvfptNkI6W/JZnRywHLd719yCxdAi X-Received: by 2002:a17:902:e54e:b0:1d0:cd87:64cf with SMTP id n14-20020a170902e54e00b001d0cd8764cfmr611765plf.76.1701799329201; Tue, 05 Dec 2023 10:02:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701799329; cv=none; d=google.com; s=arc-20160816; b=0whcXscZ8//zXX+709GKGLUcIyY4dU921ROIxlipWgK2FZxp6Da92+5fSCGbhsvZVe mhtXpU39fbn7w72RXtUFJEaoYrTZDMjXrd1+oYxiGXi6RgcL/IU47SFYw/RXPQmSHfRw 1WGkkcG/GyM1xsYIg1zuS/sKwxt68tWRwWoORGM6/6x4b6uabYZFRmrAUCxdEZHylKpq i1l4UVQFcsZ9OlbB0GFhWfSmAi7Ee0OIOGQb3nnOXMkMe+ZoI/pYgdt7S35UHNCiuGkw eEKnIndmT1OabgYCjj7su+2a9AZ/qte0jUVG48Tty7lkGC03gSHji6zx3zDlUekWiIwy rHVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=S/xVyfEs/keN1FaFVBg1GFxYZRg3hbSLiWxcW7jKCsE=; fh=119i2HicJnNDzA/uMhKjuP4NlcuddyKAZxxlPxqPtCU=; b=qzqWIVZhqtUgeyc6xZptXBoNr7Hs6i9uJGB3eu8sMyY3QbsqdccA1uM13Bv1XMtNgI 49bsKGf0DL1MLJNnE8yuZtdh9qGO17xeg2e5hE9JHeBCwJBhT1UsvIm5tvCZhcvIn2BL u2U8XnDSZtBbnIPQl6tvlDk5GPU+YkA4vwGWZUFWGXf67sFASuLSWWkJjHjexqGcVHm0 ug2rABcIOFnNI+gsSzWbZr0r2dsN8ccR3sDAxT5+2PQYj4PlA1ZTIllYSKOW1TMohozU gupi2Xrpdm+hUjALl3u6FP3DHYY5U6YmEVQQBLU7Ae0M1Rn2mlEazcN4mrZtcPGd/nBw ci8A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id bj6-20020a170902850600b001d06eae7137si6024749plb.260.2023.12.05.10.01.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 10:02:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id AA82A8030B8A; Tue, 5 Dec 2023 10:01:48 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345566AbjLESBi (ORCPT + 99 others); Tue, 5 Dec 2023 13:01:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229569AbjLESBi (ORCPT ); Tue, 5 Dec 2023 13:01:38 -0500 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AB8651BC; Tue, 5 Dec 2023 10:01:44 -0800 (PST) Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1rAZjr-0003nO-00; Tue, 05 Dec 2023 19:01:43 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id BCBD4C0A2B; Tue, 5 Dec 2023 18:52:36 +0100 (CET) Date: Tue, 5 Dec 2023 18:52:36 +0100 From: Thomas Bogendoerfer To: Jiaxun Yang Cc: "linux-mips@vger.kernel.org" , linux-kernel@vger.kernel.org, "stable@vger.kernel.org" , Aurelien Jarno Subject: Re: [PATCH] MIPS: kernel: Clear FPU states when setting up kernel threads Message-ID: References: <20231130163601.185270-1-tsbogend@alpha.franken.de> <6f290f4b-5dc2-44f3-9f2d-01496f78d629@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6f290f4b-5dc2-44f3-9f2d-01496f78d629@app.fastmail.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 05 Dec 2023 10:01:48 -0800 (PST) On Fri, Dec 01, 2023 at 11:12:21AM +0000, Jiaxun Yang wrote: > > > 在2023年11月30日十一月 下午4:36,Thomas Bogendoerfer写道: > > io_uring sets up the io worker kernel thread via a syscall out of an > > user space prrocess. This process might have used FPU and since > > copy_thread() didn't clear FPU states for kernel threads a BUG() > > is triggered for using FPU inside kernel. Move code around > > to always clear FPU state for user and kernel threads. > > > > Cc: stable@vger.kernel.org > > Reported-by: Aurelien Jarno > > Closes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1055021 > > Signed-off-by: Thomas Bogendoerfer > > Reviewed-by: Jiaxun Yang > > Perhaps > Suggested-by: Jiaxun Yang > > As well :-) I've added both Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]